PaymentInformation - Code Metrics - magium/MagiumMagento - Measure and Improve Code Quality continuously with Scrutinizer

PaymentInformation A
last analyzed 2017-11-09 15:32 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	18
lcom	1
cbo	1
dl	0
loc	136
rs	10
c	0
b	0
f	0

13 Methods

Rating	Name	Size	Complexity
A	getCreditCardNumber()	4	1
A	setCreditCardNumber()	4	1
A	setExpiryDate()	4	1
A	getCvv()	4	1
A	setCvv()	4	1
A	__construct()	14	1
B	setDefaults()	18	6
A	getExpiryMonth()	4	1
A	getExpiryYear()	4	1
A	getType()	4	1
A	setExpiryMonth()	4	1
A	setExpiryYear()	4	1
A	setType()	4	1

<?php

namespace Magium\Magento\Actions\Checkout;

use Magium\AbstractConfigurableElement;
use Magium\Util\Configuration\ConfigurationCollector\DefaultPropertyCollector;
use Magium\Util\Configuration\StandardConfigurationProvider;

class PaymentInformation extends AbstractConfigurableElement
{
    const ACTION = 'Checkout\PaymentInformation';

    public $creditCardNumber;
    public $expiryYear;
    public $expiryMonth;
    public $cvv;
    public $type;

    public function __construct(StandardConfigurationProvider $configurationProvider, DefaultPropertyCollector $collector)
    {
        /*
         * Note: payment information is placed in this class instead of the payment step because I wanted to make
         * the payment easily configurable which is why this class extends AbstractConfigurableElement.  The payment
         * step class does not extend AbstractConfigurableElement (because it needs the constructor for dependency
         * injection) and so this class is here so payment can be globally configured.
         *
         * This way if you want to handle your own credit card you only have to configure this class
        */

        parent::__construct($configurationProvider, $collector);
        $this->setDefaults();
    }


    protected function setDefaults()
    {
        if (!$this->creditCardNumber) {
            $this->creditCardNumber = '4111111111111111';
        }
        if (!$this->expiryMonth) {
            $this->expiryMonth = '1';
        }
        if (!$this->expiryYear) {
            $this->expiryYear = date('Y', time() + (60 * 60 * 24 * 365 * 5));  // January plus 5 years
        }
        if (!$this->cvv) {
            $this->cvv = '123';
        }
        if (!$this->type) {
            $this->type = 'VI';
        }
    }

    /**
     * @return string
     */
    public function getCreditCardNumber()
    {
        return $this->creditCardNumber;
    }

    /**
     * @param string $creditCardNumber
     */
    public function setCreditCardNumber($creditCardNumber)
    {
        $this->creditCardNumber = $creditCardNumber;
    }

    /**
     * @return string
     */
    public function getExpiryMonth()
    {
        return $this->expiryMonth;
    }

    /**
     * @return string
     */
    public function getExpiryYear()
    {
        return $this->expiryYear;
    }

    /**
     * @param string $expiryDate
     */
    public function setExpiryDate($expiryDate)
    {
        $this->expiryDate = $expiryDate;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @return string
     */
    public function getCvv()
    {
        return $this->cvv;
    }

    /**
     * @param string $cvv
     */
    public function setCvv($cvv)
    {
        $this->cvv = $cvv;
    }

    /**
     * @param mixed $expiryMonth
     */
    public function setExpiryMonth($expiryMonth)
    {
        $this->expiryMonth = $expiryMonth;
    }

    /**
     * @param mixed $expiryYear
     */
    public function setExpiryYear($expiryYear)
    {
        $this->expiryYear = $expiryYear;
    }

    /**
     * @param mixed $type
     */
    public function setType($type)
    {
        $this->type = $type;
    }



}

1			<?php
2
3			namespace Magium\Magento\Actions\Checkout;
4
5			use Magium\AbstractConfigurableElement;
6			use Magium\Util\Configuration\ConfigurationCollector\DefaultPropertyCollector;
7			use Magium\Util\Configuration\StandardConfigurationProvider;
8
9			class PaymentInformation extends AbstractConfigurableElement
10			{
11			const ACTION = 'Checkout\PaymentInformation';
12
13			public $creditCardNumber;
14			public $expiryYear;
15			public $expiryMonth;
16			public $cvv;
17			public $type;
18
19			public function __construct(StandardConfigurationProvider $configurationProvider, DefaultPropertyCollector $collector)
20			{
21			/*
22			* Note: payment information is placed in this class instead of the payment step because I wanted to make
23			* the payment easily configurable which is why this class extends AbstractConfigurableElement. The payment
24			* step class does not extend AbstractConfigurableElement (because it needs the constructor for dependency
25			* injection) and so this class is here so payment can be globally configured.
26			*
27			* This way if you want to handle your own credit card you only have to configure this class
28			*/
29
30			parent::__construct($configurationProvider, $collector);
31			$this->setDefaults();
32			}
33
34
35			protected function setDefaults()
36			{
37			if (!$this->creditCardNumber) {
38			$this->creditCardNumber = '4111111111111111';
39			}
40			if (!$this->expiryMonth) {
41			$this->expiryMonth = '1';
42			}
43			if (!$this->expiryYear) {
44			$this->expiryYear = date('Y', time() + (60 * 60 * 24 * 365 * 5)); // January plus 5 years
45			}
46			if (!$this->cvv) {
47			$this->cvv = '123';
48			}
49			if (!$this->type) {
50			$this->type = 'VI';
51			}
52			}
53
54			/**
55			* @return string
56			*/
57			public function getCreditCardNumber()
58			{
59			return $this->creditCardNumber;
60			}
61
62			/**
63			* @param string $creditCardNumber
64			*/
65			public function setCreditCardNumber($creditCardNumber)
66			{
67			$this->creditCardNumber = $creditCardNumber;
68			}
69
70			/**
71			* @return string
72			*/
73			public function getExpiryMonth()
74			{
75			return $this->expiryMonth;
76			}
77
78			/**
79			* @return string
80			*/
81			public function getExpiryYear()
82			{
83			return $this->expiryYear;
84			}
85
86			/**
87			* @param string $expiryDate
88			*/
89			public function setExpiryDate($expiryDate)
90			{
91			$this->expiryDate = $expiryDate;
			0 ignored issues – show Documentation introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report The property `expiryDate` does not exist on `object<Magium\Magento\Ac...out\PaymentInformation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
92			}
93
94			/**
95			* @return string
96			*/
97			public function getType()
98			{
99			return $this->type;
100			}
101
102			/**
103			* @return string
104			*/
105			public function getCvv()
106			{
107			return $this->cvv;
108			}
109
110			/**
111			* @param string $cvv
112			*/
113			public function setCvv($cvv)
114			{
115			$this->cvv = $cvv;
116			}
117
118			/**
119			* @param mixed $expiryMonth
120			*/
121			public function setExpiryMonth($expiryMonth)
122			{
123			$this->expiryMonth = $expiryMonth;
124			}
125
126			/**
127			* @param mixed $expiryYear
128			*/
129			public function setExpiryYear($expiryYear)
130			{
131			$this->expiryYear = $expiryYear;
132			}
133
134			/**
135			* @param mixed $type
136			*/
137			public function setType($type)
138			{
139			$this->type = $type;
140			}
141
142
143
144			}

magium / MagiumMagento

GitHub Access Token became invalid

PaymentInformation A last analyzed 2017-11-09 15:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

Duplication Side-by-Side

Filter issues like

PaymentInformation A
last analyzed 2017-11-09 15:32 UTC