Inspection of "Develop" - magium/Magium - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#150)

by Kevin

created 2016-11-30 16:29 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 
         $this->logger->debug(
             sprintf(
-                'Executing: ' . $command_name
+                'Executing: '.$command_name
             ),
             $extra
         );

Please login to merge, or discard this patch.

lib/Util/Api/Request.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
                 $payload = ['payload' => json_encode($payload)];
             }
 
-            $url = 'http://' . $this->apiConfiguration->getApiHostname() . $url;
+            $url = 'http://'.$this->apiConfiguration->getApiHostname().$url;
 
             $factory = new Factory();
             $requestSigner = $factory->newRequestSigner();

Please login to merge, or discard this patch.

lib/Util/Configuration/ConfigurationReader.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -26,12 +26,12 @@
 block discarded – undo
             }
             $count = 0;
             while ($count++ < 10) {
-                $filePath = $dir . '/' . $file;
+                $filePath = $dir.'/'.$file;
                 if (file_exists($filePath)) {
                     $this->config = json_decode(file_get_contents($filePath), true);
                     break;
                 }
-                $dir = realpath($dir . '/..');
+                $dir = realpath($dir.'/..');
             }
         }
 

Please login to merge, or discard this patch.

lib/Util/Log/Logger.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -80,13 +80,13 @@  discard block
 block discarded – undo
     public function logAssertionSuccess(AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_PASSED]);
-        $this->info(get_class($assertion) . ' - passed', $this->createExtra($extra));
+        $this->info(get_class($assertion).' - passed', $this->createExtra($extra));
     }
 
     public function logAssertionFailure(Exception $e, AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_FAILED, 'stack_trace' => $e->getTrace()]);
-        $this->err(get_class($assertion) . ' - ' . $e->getMessage(), $this->createExtra($extra));
+        $this->err(get_class($assertion).' - '.$e->getMessage(), $this->createExtra($extra));
     }
 
     public function createExtra($includeArray = [])
@@ -148,9 +148,9 @@  discard block
 block discarded – undo
     {
         if ($test instanceof \PHPUnit_Framework_TestCase) {
             if (!$this->testName) {
-                $this->setTestName(get_class($test) . '::' . $test->getName());
+                $this->setTestName(get_class($test).'::'.$test->getName());
             }
-            $this->invokedTest = get_class($test) . '::' . $test->getName();
+            $this->invokedTest = get_class($test).'::'.$test->getName();
             $this->setTestStatus(self::STATUS_PASSED);
         }
 

Please login to merge, or discard this patch.

lib/Util/EmailGenerator/Generator.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,6 +11,6 @@
 block discarded – undo
         $encoded = base64_encode($rand);
         $username = preg_replace('/\W/', '', $encoded);
 
-        return $username . '@' . $domain;
+        return $username.'@'.$domain;
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

lib/Extractors/Navigation/Menu.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -109,7 +109,7 @@  discard block
 block discarded – undo
         $html = $this->webDriver->byXpath('//body')->getAttribute('innerHTML');
         $doc = new \DOMDocument();
         libxml_use_internal_errors(true);
-        $doc->loadHTML('<html><body>' . $html . '</body></html>');
+        $doc->loadHTML('<html><body>'.$html.'</body></html>');
         $xpath = new \DOMXPath($doc);
 
         $baseMatches = $this->getBaseMatches($xpath, $baseChild);
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
         }
 
         if (!count($finalMatches)) {
-            throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: ' . $this->path);
+            throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: '.$this->path);
         }
 
         $this->baseXpath = $finalMatches[0]['baseNodePath'];
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
     {
         $baseMatches = [];
         foreach ($this->baseSearchOrder as $base) {
-            $baseQuery = '//' . $base;
+            $baseQuery = '//'.$base;
             $nodeList = $xpath->query($baseQuery);
             foreach ($nodeList as $index => $node) {
                 /* @var $node \DOMElement */
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
                     if ($element->isDisplayed()) {
                         foreach ($this->childSearchOrder as $order) {
                             $childQueryXpath = sprintf($order, $baseChild);
-                            $childQuery = $path . '/descendant::' . $childQueryXpath;
+                            $childQuery = $path.'/descendant::'.$childQueryXpath;
                             $childNodeList = $xpath->query($childQuery);
                             if ($childNodeList instanceof \DOMNodeList) {
                                 foreach ($childNodeList as $node) {

Please login to merge, or discard this patch.

lib/Navigators/InstructionNavigator.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
                 case self::INSTRUCTION_MOUSE_CLICK:
                     $element = $this->webdriver->byXpath($xpath);
                     if (!$element->isDisplayed()) {
-                        throw new ElementNotVisibleException('The element is not visible: ' . $xpath);
+                        throw new ElementNotVisibleException('The element is not visible: '.$xpath);
                     }
                     $element->click();
                     break;
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
                 case self::INSTRUCTION_WAIT_FOR_NOT_EXISTS:
                     $this->webdriver->wait()->until(
                         ExpectedCondition::not(
-                            ExpectedCondition::elementExists( $xpath, WebDriver::BY_XPATH)
+                            ExpectedCondition::elementExists($xpath, WebDriver::BY_XPATH)
                         )
                     );
                     break;
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
                     );
                     break;
                 default:
-                    throw new InvalidConfigurationException('Unknown login instruction: ' .$instruction );
+                    throw new InvalidConfigurationException('Unknown login instruction: '.$instruction);
             }
         }
 

Please login to merge, or discard this patch.

lib/Navigators/LinkSequence.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -52,7 +52,7 @@  discard block
 block discarded – undo
             $xpath = sprintf('//a[concat(" ",normalize-space(.)," ") = " %s "]|//*[concat(" ",normalize-space(.)," ") = " %s "]/ancestor::a', $part, $part);
             $elements = $this->webDriver->findElements(WebDriverBy::xpath($xpath));
             $action = false;
-            $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: ' . $xpath);
+            $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: '.$xpath);
             foreach ($elements as $element) {
                 // Sometimes responsive templates have multiple nav menus.  So we iterate over the results to find a visible element.
                 if (!$element->isDisplayed()) {
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
                 $action = true;
                 break; // If either of these options work we don't need to iterate over the remain elements
             }
-            $this->testCase->assertTrue($action, 'No action was taken.  Elements not visible?  Xpath: ' . $xpath);
+            $this->testCase->assertTrue($action, 'No action was taken.  Elements not visible?  Xpath: '.$xpath);
         }
 
         // We will have already clicked it previously

Please login to merge, or discard this patch.

lib/Cli/Command/UnsetSetting.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,11 +33,11 @@  discard block
 block discarded – undo
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (!file_exists($this->path . '/magium.json')) {
+        if (!file_exists($this->path.'/magium.json')) {
             throw new NotFoundException('Configuration file not found.  Please execute magium:init.');
         }
         $reader = new \Zend\Config\Reader\Json();
-        $config = new Config($reader->fromFile($this->path . '/magium.json'), true);
+        $config = new Config($reader->fromFile($this->path.'/magium.json'), true);
 
         $name = $input->getArgument('name');
         $value = $input->getArgument('value');
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
         $config->config->$name = $value;
 
         $writer = new Json();
-        $writer->toFile($this->path . '/magium.json', $config);
+        $writer->toFile($this->path.'/magium.json', $config);
         $output->writeln(sprintf('Wrote value for "%s" to %s/magium.json', $name, $this->path));
     }
 

Please login to merge, or discard this patch.

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33
34	34	$this->logger->debug(
35	35	sprintf(
36		- 'Executing: ' . $command_name
	36	+ 'Executing: '.$command_name
37	37	),
38	38	$extra
39	39	);

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33	$payload = ['payload' => json_encode($payload)];
34	34	}
35	35
36		- $url = 'http://' . $this->apiConfiguration->getApiHostname() . $url;
	36	+ $url = 'http://'.$this->apiConfiguration->getApiHostname().$url;
37	37
38	38	$factory = new Factory();
39	39	$requestSigner = $factory->newRequestSigner();

		@@ -80,13 +80,13 @@ discard block
		block discarded – undo
80	80	public function logAssertionSuccess(AbstractAssertion $assertion, array $extra)
81	81	{
82	82	$extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_PASSED]);
83		- $this->info(get_class($assertion) . ' - passed', $this->createExtra($extra));
	83	+ $this->info(get_class($assertion).' - passed', $this->createExtra($extra));
84	84	}
85	85
86	86	public function logAssertionFailure(Exception $e, AbstractAssertion $assertion, array $extra)
87	87	{
88	88	$extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_FAILED, 'stack_trace' => $e->getTrace()]);
89		- $this->err(get_class($assertion) . ' - ' . $e->getMessage(), $this->createExtra($extra));
	89	+ $this->err(get_class($assertion).' - '.$e->getMessage(), $this->createExtra($extra));
90	90	}
91	91
92	92	public function createExtra($includeArray = [])
		@@ -148,9 +148,9 @@ discard block
		block discarded – undo
148	148	{
149	149	if ($test instanceof \PHPUnit_Framework_TestCase) {
150	150	if (!$this->testName) {
151		- $this->setTestName(get_class($test) . '::' . $test->getName());
	151	+ $this->setTestName(get_class($test).'::'.$test->getName());
152	152	}
153		- $this->invokedTest = get_class($test) . '::' . $test->getName();
	153	+ $this->invokedTest = get_class($test).'::'.$test->getName();
154	154	$this->setTestStatus(self::STATUS_PASSED);
155	155	}
156	156

		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	$html = $this->webDriver->byXpath('//body')->getAttribute('innerHTML');
110	110	$doc = new \DOMDocument();
111	111	libxml_use_internal_errors(true);
112		- $doc->loadHTML('<html><body>' . $html . '</body></html>');
	112	+ $doc->loadHTML('<html><body>'.$html.'</body></html>');
113	113	$xpath = new \DOMXPath($doc);
114	114
115	115	$baseMatches = $this->getBaseMatches($xpath, $baseChild);
		@@ -121,7 +121,7 @@ discard block
		block discarded – undo
121	121	}
122	122
123	123	if (!count($finalMatches)) {
124		- throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: ' . $this->path);
	124	+ throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: '.$this->path);
125	125	}
126	126
127	127	$this->baseXpath = $finalMatches[0]['baseNodePath'];
		@@ -179,7 +179,7 @@ discard block
		block discarded – undo
179	179	{
180	180	$baseMatches = [];
181	181	foreach ($this->baseSearchOrder as $base) {
182		- $baseQuery = '//' . $base;
	182	+ $baseQuery = '//'.$base;
183	183	$nodeList = $xpath->query($baseQuery);
184	184	foreach ($nodeList as $index => $node) {
185	185	/* @var $node \DOMElement */
		@@ -190,7 +190,7 @@ discard block
		block discarded – undo
190	190	if ($element->isDisplayed()) {
191	191	foreach ($this->childSearchOrder as $order) {
192	192	$childQueryXpath = sprintf($order, $baseChild);
193		- $childQuery = $path . '/descendant::' . $childQueryXpath;
	193	+ $childQuery = $path.'/descendant::'.$childQueryXpath;
194	194	$childNodeList = $xpath->query($childQuery);
195	195	if ($childNodeList instanceof \DOMNodeList) {
196	196	foreach ($childNodeList as $node) {

		@@ -33,11 +33,11 @@ discard block
		block discarded – undo
33	33
34	34	protected function execute(InputInterface $input, OutputInterface $output)
35	35	{
36		- if (!file_exists($this->path . '/magium.json')) {
	36	+ if (!file_exists($this->path.'/magium.json')) {
37	37	throw new NotFoundException('Configuration file not found. Please execute magium:init.');
38	38	}
39	39	$reader = new \Zend\Config\Reader\Json();
40		- $config = new Config($reader->fromFile($this->path . '/magium.json'), true);
	40	+ $config = new Config($reader->fromFile($this->path.'/magium.json'), true);
41	41
42	42	$name = $input->getArgument('name');
43	43	$value = $input->getArgument('value');
		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	$config->config->$name = $value;
53	53
54	54	$writer = new Json();
55		- $writer->toFile($this->path . '/magium.json', $config);
	55	+ $writer->toFile($this->path.'/magium.json', $config);
56	56	$output->writeln(sprintf('Wrote value for "%s" to %s/magium.json', $name, $this->path));
57	57	}
58	58

		@@ -26,12 +26,12 @@
		block discarded – undo
26	26	}
27	27	$count = 0;
28	28	while ($count++ < 10) {
29		- $filePath = $dir . '/' . $file;
	29	+ $filePath = $dir.'/'.$file;
30	30	if (file_exists($filePath)) {
31	31	$this->config = json_decode(file_get_contents($filePath), true);
32	32	break;
33	33	}
34		- $dir = realpath($dir . '/..');
	34	+ $dir = realpath($dir.'/..');
35	35	}
36	36	}
37	37

		@@ -11,6 +11,6 @@
		block discarded – undo
11	11	$encoded = base64_encode($rand);
12	12	$username = preg_replace('/\W/', '', $encoded);
13	13
14		- return $username . '@' . $domain;
	14	+ return $username.'@'.$domain;
15	15	}
16	16	}
17	17	\ No newline at end of file

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	case self::INSTRUCTION_MOUSE_CLICK:
73	73	$element = $this->webdriver->byXpath($xpath);
74	74	if (!$element->isDisplayed()) {
75		- throw new ElementNotVisibleException('The element is not visible: ' . $xpath);
	75	+ throw new ElementNotVisibleException('The element is not visible: '.$xpath);
76	76	}
77	77	$element->click();
78	78	break;
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	case self::INSTRUCTION_WAIT_FOR_NOT_EXISTS:
87	87	$this->webdriver->wait()->until(
88	88	ExpectedCondition::not(
89		- ExpectedCondition::elementExists( $xpath, WebDriver::BY_XPATH)
	89	+ ExpectedCondition::elementExists($xpath, WebDriver::BY_XPATH)
90	90	)
91	91	);
92	92	break;
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	);
106	106	break;
107	107	default:
108		- throw new InvalidConfigurationException('Unknown login instruction: ' .$instruction );
	108	+ throw new InvalidConfigurationException('Unknown login instruction: '.$instruction);
109	109	}
110	110	}
111	111

		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	$xpath = sprintf('//a[concat(" ",normalize-space(.)," ") = " %s "]\|//*[concat(" ",normalize-space(.)," ") = " %s "]/ancestor::a', $part, $part);
53	53	$elements = $this->webDriver->findElements(WebDriverBy::xpath($xpath));
54	54	$action = false;
55		- $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: ' . $xpath);
	55	+ $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: '.$xpath);
56	56	foreach ($elements as $element) {
57	57	// Sometimes responsive templates have multiple nav menus. So we iterate over the results to find a visible element.
58	58	if (!$element->isDisplayed()) {
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66	$action = true;
67	67	break; // If either of these options work we don't need to iterate over the remain elements
68	68	}
69		- $this->testCase->assertTrue($action, 'No action was taken. Elements not visible? Xpath: ' . $xpath);
	69	+ $this->testCase->assertTrue($action, 'No action was taken. Elements not visible? Xpath: '.$xpath);
70	70	}
71	71
72	72	// We will have already clicked it previously

magium / Magium

Pull Request — master (#150)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch