magium / Magium

lib/TestCase/Executor.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
     public function evaluate($string)
     {
-        $string = '<?php ' . $string;
+        $string = '<?php '.$string;
         $comparison1 = $comparison2 = '';
         $operator = null;
         $tokens = token_get_all($string);

Braces +6 added lines, -2 removed lines

@@ -49,10 +49,14 @@
 
         if ($operator === null) {
             $isTrue = in_array($comparison1, $this->reservedTrue);
-            if ($isTrue) return true;
+            if ($isTrue) {
+                return true;
+            }
 
             $isFalse = in_array($comparison1, $this->reservedFalse);
-            if ($isFalse) return false;
+            if ($isFalse) {
+                return false;
+            }
 
             return (boolean)$comparison1;
         } else {

lib/Util/Configuration/ClassConfigurationReader.php

Spacing +4 added lines, -4 removed lines

@@ -44,9 +44,9 @@ 
             $isVendor = array_pop($testParts) == 'vendor';
 
             if ($isVendor) {
-                $path = realpath(__DIR__ . '/../../../../..'); // Get out of the Magium directories
+                $path = realpath(__DIR__.'/../../../../..'); // Get out of the Magium directories
             } else {
-                $path = realpath(__DIR__ . '/../../..');
+                $path = realpath(__DIR__.'/../../..');
             }
 
             $count = 0;
@@ -76,8 +76,8 @@ 
         $classes = $this->introspectClass($config);
 
         foreach ($classes as $class) {
-            $configurationFile = $class . '.php';
-            $configurationFile = $configurationDir . DIRECTORY_SEPARATOR . str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
+            $configurationFile = $class.'.php';
+            $configurationFile = $configurationDir.DIRECTORY_SEPARATOR.str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
 
             if (file_exists($configurationFile)) {
                 include $configurationFile;

Braces +3 added lines, -1 removed lines

@@ -71,7 +71,9 @@
             }
         }
 
-        if (!is_dir($configurationDir)) return;
+        if (!is_dir($configurationDir)) {
+            return;
+        }
 
         $classes = $this->introspectClass($config);
 

lib/Util/Configuration/AbstractConfigurationReader.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
             $reflectionClass = $class;
         }
 
-        foreach ($originalReflectionClass->getInterfaceNames() as $name){
+        foreach ($originalReflectionClass->getInterfaceNames() as $name) {
             $this->addClass($name);
             $interfaces[] = $name;
             $reflectionInterface = new \ReflectionClass($name);

lib/Assertions/LoggingAssertionExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         }
         try {
             $assertion->assert();
-            $this->logger->logAssertionSuccess( $assertion, $extra );
+            $this->logger->logAssertionSuccess($assertion, $extra);
         } catch (\Exception $e) {
             $this->logger->logAssertionFailure($e, $assertion, $extra);
             $this->testCase->fail($e->getMessage());

lib/TestCase/Configurable/Interpolator.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 
     public function interpolate($string)
     {
-        $this->logger->info('Interpolating string: ' . $string);
+        $this->logger->info('Interpolating string: '.$string);
         $matches = null;
         // Finding {{$product->setEntityId(123)->load()}} type methods
         if (preg_match('/\{\{(?:\$)([^{]+)\}\}/', $string, $matches)) {

lib/Assertions/Element/Clickable.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Facebook\WebDriver\WebDriverBy;
 use Magium\AbstractTestCase;
-use Magium\InvalidTestTypeException;
 use Magium\WebDriver\ExpectedCondition;
 
 class Clickable extends AbstractSelectorAssertion

lib/Assertions/Element/NotClickable.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Facebook\WebDriver\WebDriverBy;
 use Magium\AbstractTestCase;
-use Magium\InvalidTestTypeException;
 use Magium\WebDriver\ExpectedCondition;
 
 class NotClickable extends AbstractSelectorAssertion

lib/Util/Log/LoggerPHPUnit5.php

Doc Comments +6 added lines

@@ -45,11 +45,17 @@
         return $this->invokedTest;
     }
 
+    /**
+     * @param string $name
+     */
     public function setTestName($name)
     {
         $this->testName = $name;
     }
 
+    /**
+     * @param string $status
+     */
     public function setTestStatus($status)
     {
         $this->status = $status;

Spacing +4 added lines, -4 removed lines

@@ -73,13 +73,13 @@ 
     public function logAssertionSuccess(AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_PASSED]);
-        $this->info(get_class($assertion) . ' - passed', $this->createExtra($extra));
+        $this->info(get_class($assertion).' - passed', $this->createExtra($extra));
     }
 
     public function logAssertionFailure(Exception $e, AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_FAILED, 'stack_trace' => $e->getTrace()]);
-        $this->err(get_class($assertion) . ' - ' . $e->getMessage(), $this->createExtra($extra));
+        $this->err(get_class($assertion).' - '.$e->getMessage(), $this->createExtra($extra));
     }
 
     public function createExtra($includeArray = [])
@@ -146,9 +146,9 @@ 
     {
         if ($test instanceof TestCase) {
             if (!$this->testName) {
-                $this->setTestName(get_class($test) . '::' . $test->getName());
+                $this->setTestName(get_class($test).'::'.$test->getName());
             }
-            $this->invokedTest = get_class($test) . '::' . $test->getName();
+            $this->invokedTest = get_class($test).'::'.$test->getName();
             $this->setTestStatus(self::STATUS_PASSED);
         }
 

lib/WebDriver/WebDriver.php

Doc Comments +7 added lines

@@ -59,6 +59,10 @@ 
     }
 
 
+    /**
+     * @param string $by
+     * @param string $selector
+     */
     public function logFind($by, $selector)
     {
         if ($this->logger instanceof \Magium\Util\Log\LoggerInterface) {
@@ -135,6 +139,9 @@ 
         return $element;
     }
 
+    /**
+     * @param string $selector
+     */
     public function elementExists($selector, $by = 'byId')
     {
         try {