magium / Magium

lib/Assertions/Browser/AssetIsCached.php

Spacing +2 added lines, -2 removed lines

@@ -28,12 +28,12 @@
 
         foreach ($assets as $asset) {
             if (strpos($asset['name'], $this->url) !== false) {
-                $this->testCase->assertEquals(0, $asset['duration'], 'Asset was not cached: ' . $asset['name']);
+                $this->testCase->assertEquals(0, $asset['duration'], 'Asset was not cached: '.$asset['name']);
                 $foundAsset = true;
             }
         }
 
-        $this->testCase->assertTrue($foundAsset, 'Unable to find asset: ' . $this->url);
+        $this->testCase->assertTrue($foundAsset, 'Unable to find asset: '.$this->url);
     }
 
 }
\ No newline at end of file

lib/Assertions/Browser/LogEmpty.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     {
         $log = $this->webDriver->manage()->getLog('browser');
         foreach ($log as $l) {
-            $this->logger->err('Message found: ' . serialize($l));
+            $this->logger->err('Message found: '.serialize($l));
         }
         $this->testCase->assertCount(0, $log);
     }

lib/Actions/SetFormValue.php

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
 
     public function setById($id, $value)
     {
-        $this->set('id:' . $id, $value);
+        $this->set('id:'.$id, $value);
     }
 
     public function set($name, $value)
@@ -41,7 +41,7 @@ 
         } else {
             $element = $this->webDriver->byXpath(sprintf('//label[.="%s"]', $name));
             if (!$element->getAttribute('for')) {
-                throw new NotFoundException('Unable to find the "for" attribute for a label with the text: ' . $name);
+                throw new NotFoundException('Unable to find the "for" attribute for a label with the text: '.$name);
             }
             $formElement = $this->webDriver->byId($element->getAttribute('for'));
         }

lib/Util/Configuration/StandardConfigurationProvider.php

Spacing +4 added lines, -4 removed lines

@@ -31,10 +31,10 @@
 
     public function configureDi(Di $di)
     {
-        $di->instanceManager()->addSharedInstance($this->configurationReader,               get_class($this->configurationReader));
-        $di->instanceManager()->addSharedInstance($this->classConfigurationReader,          get_class($this->classConfigurationReader));
-        $di->instanceManager()->addSharedInstance($this->environmentConfigurationReader,    get_class($this->environmentConfigurationReader));
-        $di->instanceManager()->addSharedInstance($this,                                    get_class($this));
+        $di->instanceManager()->addSharedInstance($this->configurationReader, get_class($this->configurationReader));
+        $di->instanceManager()->addSharedInstance($this->classConfigurationReader, get_class($this->classConfigurationReader));
+        $di->instanceManager()->addSharedInstance($this->environmentConfigurationReader, get_class($this->environmentConfigurationReader));
+        $di->instanceManager()->addSharedInstance($this, get_class($this));
     }
 
     public function configureObject(ConfigurableObjectInterface $obj)

lib/Util/Configuration/EnvironmentConfigurationReader.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
         foreach ($classes as $class) {
 
-            $variablePrefix = 'MAGIUM_' . str_replace('\\', '_', strtoupper($class)) . '_';
+            $variablePrefix = 'MAGIUM_'.str_replace('\\', '_', strtoupper($class)).'_';
 
             // Fixes https://github.com/magium/Magium/issues/114
             $props = array_merge($_SERVER, $_ENV);

lib/Introspection/Introspector.php

Doc Comments +6 added lines

@@ -96,6 +96,9 @@ 
         return $classes;
     }
 
+    /**
+     * @param string $class
+     */
     protected function processClass($class)
     {
         try {
@@ -137,6 +140,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $file
+     */
     protected function getClassNameInFile($file)
     {
         $namespace = $class = '';

Spacing +4 added lines, -4 removed lines

@@ -150,7 +150,7 @@ 
                 && $tokens[$i][0] == T_STRING
             ) {
 
-                $class = $namespace . $tokens[$i][1];
+                $class = $namespace.$tokens[$i][1];
                 $this->logger->debug(sprintf('Extracted %s from %s', $class, $file));
                 return $class;
             } else if ($tokens[$i - 2][0] == T_NAMESPACE
@@ -158,10 +158,10 @@ 
                 && $tokens[$i][0] == T_STRING) {
 
                 $plus = 0;
-                while ($tokens[$i+$plus] != ';') {
-                    $token = $tokens[$i+$plus];
+                while ($tokens[$i + $plus] != ';') {
+                    $token = $tokens[$i + $plus];
                     if ($token[0] == T_STRING) {
-                        $namespace .= $token[1] . '\\';
+                        $namespace .= $token[1].'\\';
                     }
                     $plus++;
                 }

Braces +3 added lines, -1 removed lines

@@ -141,7 +141,9 @@
     {
         $namespace = $class = '';
         $content = file_get_contents($file);
-        if (!$content) return null;
+        if (!$content) {
+            return null;
+        }
         $tokens = token_get_all($content);
         $count = count($tokens);
         for ($i = 2; $i < $count; $i++) {

lib/TestCase/Executor.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
     public function evaluate($string)
     {
-        $string = '<?php ' . $string;
+        $string = '<?php '.$string;
         $comparison1 = $comparison2 = '';
         $operator = null;
         $tokens = token_get_all($string);

Braces +6 added lines, -2 removed lines

@@ -49,10 +49,14 @@
 
         if ($operator === null) {
             $isTrue = in_array($comparison1, $this->reservedTrue);
-            if ($isTrue) return true;
+            if ($isTrue) {
+                return true;
+            }
 
             $isFalse = in_array($comparison1, $this->reservedFalse);
-            if ($isFalse) return false;
+            if ($isFalse) {
+                return false;
+            }
 
             return (boolean)$comparison1;
         } else {

lib/WebDriver/WebDriver.php

Doc Comments +7 added lines

@@ -60,6 +60,10 @@ 
     }
 
 
+    /**
+     * @param string $by
+     * @param string $selector
+     */
     public function logFind($by, $selector)
     {
         if ($this->logger instanceof Logger) {
@@ -136,6 +140,9 @@ 
         return $element;
     }
 
+    /**
+     * @param string $selector
+     */
     public function elementExists($selector, $by = 'byId')
     {
         try {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Facebook\WebDriver\Exception\WebDriverException;
 use Facebook\WebDriver\Remote\DriverCommand;
 use Facebook\WebDriver\Remote\HttpCommandExecutor;
-use Facebook\WebDriver\Remote\RemoteExecuteMethod;
 use Facebook\WebDriver\Remote\RemoteWebDriver;
 use Facebook\WebDriver\Remote\WebDriverCommand;
 use Facebook\WebDriver\WebDriverBy;

lib/Util/Configuration/ClassConfigurationReader.php

Spacing +4 added lines, -4 removed lines

@@ -44,9 +44,9 @@ 
             $isVendor = array_pop($testParts) == 'vendor';
 
             if ($isVendor) {
-                $path = realpath(__DIR__ . '/../../../../..'); // Get out of the Magium directories
+                $path = realpath(__DIR__.'/../../../../..'); // Get out of the Magium directories
             } else {
-                $path = realpath(__DIR__ . '/../../..');
+                $path = realpath(__DIR__.'/../../..');
             }
 
             $count = 0;
@@ -76,8 +76,8 @@ 
         $classes = $this->introspectClass($config);
 
         foreach ($classes as $class) {
-            $configurationFile = $class . '.php';
-            $configurationFile = $configurationDir . DIRECTORY_SEPARATOR . str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
+            $configurationFile = $class.'.php';
+            $configurationFile = $configurationDir.DIRECTORY_SEPARATOR.str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
 
             if (file_exists($configurationFile)) {
                 include $configurationFile;

Braces +3 added lines, -1 removed lines

@@ -71,7 +71,9 @@
             }
         }
 
-        if (!is_dir($configurationDir)) return;
+        if (!is_dir($configurationDir)) {
+            return;
+        }
 
         $classes = $this->introspectClass($config);