Completed
Pull Request — master (#148)
by Kevin
02:16
created
example_configuration_not_used/Magium/Themes/ThemeConfiguration.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,3 +1,3 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-$this->baseUrl                      = 'http://magento19.loc//';
4 3
\ No newline at end of file
4
+$this->baseUrl = 'http://magento19.loc//';
5 5
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Extractors/Navigation/UnableToExtractMenuXpathException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,4 +2,4 @@
 block discarded – undo
2 2
 
3 3
 namespace Magium\Extractors\Navigation;
4 4
 
5
-class UnableToExtractMenuXpathException extends \Exception{}
6 5
\ No newline at end of file
6
+class UnableToExtractMenuXpathException extends \Exception {}
7 7
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Extractors/Navigation/MissingNavigationSchemeException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,4 +2,4 @@
 block discarded – undo
2 2
 
3 3
 namespace Magium\Extractors\Navigation;
4 4
 
5
-class MissingNavigationSchemeException extends \Exception{}
6 5
\ No newline at end of file
6
+class MissingNavigationSchemeException extends \Exception {}
7 7
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Extractors/DateTime.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,9 @@
 block discarded – undo
53 53
         $max = false;
54 54
         $min = PHP_INT_MAX;
55 55
         foreach ($matchedParts as $part) {
56
-            if ($part === null) continue;
56
+            if ($part === null) {
57
+                continue;
58
+            }
57 59
             if ($part >= $max) {
58 60
                 $max = $part;
59 61
             }
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
                  * We re-run the test method each time because Dec 01 01:01:01 could match only the first 01.  So we
44 44
                  * have to be a bit greedy here.
45 45
                  */
46
-                $fn = 'test' . ucfirst($term);
46
+                $fn = 'test'.ucfirst($term);
47 47
                 if ($this->$fn($part) && $matchedParts[$term] === null) {
48 48
                     $matchedParts[$term] = $key;
49 49
                 }
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         }
68 68
         $foundDate = '';
69 69
         for ($i = (int)$min; $i <= (int)$max; $i++) {
70
-            $foundDate .= ' ' . $parts[$i];
70
+            $foundDate .= ' '.$parts[$i];
71 71
         }
72 72
         $parse = date_parse(trim($foundDate));
73 73
         if (isset($parse['error_count']) && $parse['error_count'] == 0) {
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
             return true;
114 114
         }
115 115
         $parse = date_parse($part);
116
-        if (!empty($parse) && $parse['day'] !== false && $parse['error_count'] == 0 ) {
116
+        if (!empty($parse) && $parse['day'] !== false && $parse['error_count'] == 0) {
117 117
             return true;
118 118
         } else if (preg_match('/^\d{1,2}[\/\\-]\d{1,2}[\/\\-]\d{1,2}$/', $part)) {
119 119
             return true;
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             return true;
128 128
         }
129 129
         $parse = date_parse($part);
130
-        if (!empty($parse) && $parse['month'] !== false && $parse['error_count'] == 0 ) {
130
+        if (!empty($parse) && $parse['month'] !== false && $parse['error_count'] == 0) {
131 131
             return true;
132 132
         } else if (preg_match('/^\d{1,2}[\/\\-]\d{1,2}[\/\\-]\d{1,2}$/', $part)) {
133 133
             return true;
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         if (!empty($parse) && $parse['year'] !== false && $parse['error_count'] == 0) {
142 142
             return true;
143 143
             // DateTime parses 2015 as 20:15:00, so this is to account for the unique condition.
144
-        } else if (strlen($part) ==4 ) {
144
+        } else if (strlen($part) == 4) {
145 145
             if ($parse['second'] === 0 && $parse['hour'] == substr($part, 0, 2) && $parse['minute'] == substr($part, 2, 2)) {
146 146
                 return true;
147 147
             }
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
             return false;
163 163
         }
164 164
         $parse = date_parse($part);
165
-        if (!empty($parse) && $parse['hour'] !== false && $parse['error_count'] == 0 ) {
165
+        if (!empty($parse) && $parse['hour'] !== false && $parse['error_count'] == 0) {
166 166
             return true;
167 167
         }
168 168
         return false;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
             return false;
180 180
         }
181 181
         $parse = date_parse($part);
182
-        if (!empty($parse) && $parse['minute'] !== false && $parse['error_count'] == 0 ) {
182
+        if (!empty($parse) && $parse['minute'] !== false && $parse['error_count'] == 0) {
183 183
             return true;
184 184
 
185 185
         }
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
             return false;
198 198
         }
199 199
         $parse = date_parse($part);
200
-        if (!empty($parse) && $parse['second'] !== false && $parse['error_count'] == 0 ) {
200
+        if (!empty($parse) && $parse['second'] !== false && $parse['error_count'] == 0) {
201 201
             return true;
202 202
         }
203 203
         return false;
Please login to merge, or discard this patch.
lib/Extractors/AbstractAddressExtractor.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
         $this->name = trim(array_pop($rows));
32 32
         while (count($rows) > 0) {
33 33
             $row = array_shift($rows);
34
-            if (strpos($row, 'T: ') ===0) {
34
+            if (strpos($row, 'T: ') === 0) {
35 35
                 $this->phone = trim(substr($row, 3));
36 36
                 continue;
37
-            } else if (strpos($row, 'F: ') ===0) {
37
+            } else if (strpos($row, 'F: ') === 0) {
38 38
                 $this->fax = trim(substr($row, 3));
39 39
                 continue;
40 40
             }
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             $this->street1 = trim(array_shift($rows));
60 60
             $this->business = trim(array_shift($rows));
61 61
             //Easy
62
-        }else if (count($rows) == 1) {
62
+        } else if (count($rows) == 1) {
63 63
             $this->street1 = trim(array_shift($rows));
64 64
 
65 65
             // Not so easy
@@ -70,8 +70,8 @@  discard block
 block discarded – undo
70 70
                 $this->street1 = $stOrBus;
71 71
                 $this->business = trim(array_shift($rows));
72 72
             } else {
73
-                $this->street1 =trim(array_shift($rows));
74
-                $this->street2 =  $stOrBus;
73
+                $this->street1 = trim(array_shift($rows));
74
+                $this->street2 = $stOrBus;
75 75
             }
76 76
 
77 77
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
             $this->street1 = trim(array_shift($rows));
60 60
             $this->business = trim(array_shift($rows));
61 61
             //Easy
62
-        }else if (count($rows) == 1) {
62
+        } else if (count($rows) == 1) {
63 63
             $this->street1 = trim(array_shift($rows));
64 64
 
65 65
             // Not so easy
Please login to merge, or discard this patch.
lib/Assertions/LoggingAssertionExecutor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
         }
32 32
         try {
33 33
             $assertion->assert();
34
-            $this->logger->logAssertionSuccess( $assertion, $extra );
34
+            $this->logger->logAssertionSuccess($assertion, $extra);
35 35
         } catch (\Exception $e) {
36 36
             $this->logger->logAssertionFailure($assertion, $extra);
37 37
             throw $e;
Please login to merge, or discard this patch.
lib/WebDriver/ExpectedCondition.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
     public static function elementExists($selector, $by = 'byId')
12 12
     {
13 13
         return new WebDriverExpectedCondition(
14
-            function ($driver) use ($selector, $by) {
14
+            function($driver) use ($selector, $by) {
15 15
                 try {
16 16
                     $element = $driver->$by($selector);
17 17
                     return $element instanceof WebDriverElement;
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
     public static function elementRemoved(WebDriverElement $element)
27 27
     {
28 28
         return new WebDriverExpectedCondition(
29
-            function () use ($element) {
29
+            function() use ($element) {
30 30
                 try {
31 31
                     $element->isDisplayed();
32 32
                     return false;
Please login to merge, or discard this patch.
lib/WebDriver/WebDriverElementProxy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
     public function __call($name, $arguments)
28 28
     {
29 29
         if (strpos($name, '::') > 0) {
30
-            list(   , $name) = explode('::', $name);
30
+            list(, $name) = explode('::', $name);
31 31
         }
32 32
         if (!$this->element instanceof WebDriverElement) {
33 33
             $this->element = $this->webDriver->{$this->by}($this->selector);
Please login to merge, or discard this patch.
lib/Util/Configuration/ClassConfigurationReader.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,9 @@
 block discarded – undo
53 53
             }
54 54
         }
55 55
 
56
-        if (!is_dir($configurationDir)) return;
56
+        if (!is_dir($configurationDir)) {
57
+            return;
58
+        }
57 59
 
58 60
         $configurationFile = get_class($config) . '.php';
59 61
         $configurationFile = $configurationDir . DIRECTORY_SEPARATOR . str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
             $isVendor = array_pop($testParts) == 'vendor';
45 45
 
46 46
             if ($isVendor) {
47
-                $path = realpath(__DIR__ . '/../../../../..'); // Get out of the Magium directories
47
+                $path = realpath(__DIR__.'/../../../../..'); // Get out of the Magium directories
48 48
             } else {
49
-                $path = realpath(__DIR__ . '/../../..');
49
+                $path = realpath(__DIR__.'/../../..');
50 50
             }
51 51
 
52 52
             $count = 0;
@@ -73,8 +73,8 @@  discard block
 block discarded – undo
73 73
 
74 74
         if (!is_dir($configurationDir)) return;
75 75
 
76
-        $configurationFile = get_class($config) . '.php';
77
-        $configurationFile = $configurationDir . DIRECTORY_SEPARATOR . str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
76
+        $configurationFile = get_class($config).'.php';
77
+        $configurationFile = $configurationDir.DIRECTORY_SEPARATOR.str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
78 78
 
79 79
         if (file_exists($configurationFile)) {
80 80
             include $configurationFile;
Please login to merge, or discard this patch.