magium / Magium

lib/WebDriver/WebDriverElementProxy.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     public function __call($name, $arguments)
     {
         if (strpos($name, '::') > 0) {
-            list(   , $name) = explode('::', $name);
+            list(, $name) = explode('::', $name);
         }
         if (!$this->element instanceof WebDriverElement) {
             $this->element = $this->webDriver->{$this->by}($this->selector);

lib/Navigators/InstructionNavigator.php

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
                 case self::INSTRUCTION_WAIT_FOR_NOT_EXISTS:
                     $this->webdriver->wait()->until(
                         ExpectedCondition::not(
-                            ExpectedCondition::elementExists( $xpath, WebDriver::BY_XPATH)
+                            ExpectedCondition::elementExists($xpath, WebDriver::BY_XPATH)
                         )
                     );
                     break;
@@ -105,7 +105,7 @@ 
                     );
                     break;
                 default:
-                    throw new InvalidConfigurationException('Unknown login instruction: ' .$instruction );
+                    throw new InvalidConfigurationException('Unknown login instruction: ' . $instruction);
             }
         }
 

lib/Cli/Command/AbstractApiEnablement.php

Doc Comments +4 added lines

@@ -15,6 +15,10 @@
 {
 
     abstract function getApiName();
+
+    /**
+     * @return string
+     */
     abstract function getApiDescription();
     abstract function getValue();
 

Unused Use Statements -4 removed lines

@@ -2,13 +2,9 @@
 
 namespace Magium\Cli\Command;
 
-use Magium\InvalidConfigurationException;
-use Magium\NotFoundException;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 abstract class AbstractApiEnablement extends Command

lib/Cli/Command/ApiDisable.php

Unused Use Statements -7 removed lines

@@ -2,14 +2,7 @@
 
 namespace Magium\Cli\Command;
 
-use Magium\InvalidConfigurationException;
-use Magium\NotFoundException;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Output\OutputInterface;
 
 class ApiDisable extends AbstractApiEnablement
 {

lib/Cli/Command/ApiEnable.php

Unused Use Statements -7 removed lines

@@ -2,14 +2,7 @@
 
 namespace Magium\Cli\Command;
 
-use Magium\InvalidConfigurationException;
-use Magium\NotFoundException;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Output\OutputInterface;
 
 class ApiEnable extends AbstractApiEnablement
 {

lib/Cli/Command/ApiPing.php

Unused Use Statements -5 removed lines

@@ -4,14 +4,9 @@
 
 use Guzzle\Http\Client;
 use Magium\Cli\Command\Test\TestSkeleton;
-use Magium\InvalidConfigurationException;
-use Magium\NotFoundException;
 use Magium\Util\Api\ApiConfiguration;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ApiPing extends Command

Spacing +11 added lines, -11 removed lines

@@ -33,21 +33,21 @@ 
         $api->setEnabled(true); // Gotta force this for this test
 
         $output->writeln('Sending un-authenticated payload...');
-        $client = new Client('http://' . $api->getApiHostname(). '/api/ping');
+        $client = new Client('http://' . $api->getApiHostname() . '/api/ping');
         $request = $client->get();
         $response = $request->send();
         $output->writeln(
             'Checking for 200 status message... '
-            . ($response->getStatusCode() == '200'?'OK':'Failed')
+            . ($response->getStatusCode() == '200' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for application/json content type... '
-            . (stripos($response->getContentType(), 'application/json') !== false?'OK':'Failed')
+            . (stripos($response->getContentType(), 'application/json') !== false ? 'OK' : 'Failed')
         );
         $content = json_decode($response->getBody(), true);
         $output->writeln(
             'Checking for successful response... '
-            . (is_array($content) && isset($content['status']) && $content['status'] === 'success'?'OK':'Failed')
+            . (is_array($content) && isset($content['status']) && $content['status'] === 'success' ? 'OK' : 'Failed')
         );
 
         $output->writeln('');
@@ -59,16 +59,16 @@ 
 
         $output->writeln(
             'Checking for 200 status message... '
-            . ($response->getStatusCode() == '200'?'OK':'Failed')
+            . ($response->getStatusCode() == '200' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for application/json content type... '
-            . (stripos($response->getContentType(), 'application/json') !== false?'OK':'Failed')
+            . (stripos($response->getContentType(), 'application/json') !== false ? 'OK' : 'Failed')
         );
         $content = $request->getPayload($response);
         $output->writeln(
             'Checking for successful response... '
-            . (is_array($content) && isset($content['status']) && $content['status'] === 'success'?'OK':'Failed')
+            . (is_array($content) && isset($content['status']) && $content['status'] === 'success' ? 'OK' : 'Failed')
         );
 
 
@@ -79,20 +79,20 @@ 
         $response = $request->push('/api/echo-authed', ['message' => 'hello world']);
         $output->writeln(
             'Checking for 200 status message... '
-            . ($response->getStatusCode() == '200'?'OK':'Failed')
+            . ($response->getStatusCode() == '200' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for application/json content type... '
-            . (stripos($response->getContentType(), 'application/json') !== false?'OK':'Failed')
+            . (stripos($response->getContentType(), 'application/json') !== false ? 'OK' : 'Failed')
         );
         $content = $request->getPayload($response);
         $output->writeln(
             'Checking for successful response... '
-            . (is_array($content) && isset($content['status']) && $content['status'] === 'success'?'OK':'Failed')
+            . (is_array($content) && isset($content['status']) && $content['status'] === 'success' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for matching echo message... '
-            . (is_array($content) && isset($content['message']) && $content['message'] === 'hello world'?'OK':'Failed')
+            . (is_array($content) && isset($content['message']) && $content['message'] === 'hello world' ? 'OK' : 'Failed')
         );
     }
     

lib/Util/Api/Clairvoyant/Clairvoyant.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getProjectId()
     {