magium / Magium

lib/Cli/Command/ApiPing.php

Unused Use Statements -4 removed lines

@@ -5,13 +5,9 @@
 use Guzzle\Http\Client;
 use Magium\Cli\Command\Test\TestSkeleton;
 use Magium\InvalidConfigurationException;
-use Magium\NotFoundException;
 use Magium\Util\Api\ApiConfiguration;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ApiPing extends Command

Spacing +12 added lines, -12 removed lines

@@ -31,26 +31,26 @@ 
         $api = $test->get('Magium\Util\Api\ApiConfiguration');
         /* @var $api ApiConfiguration */
         if (!$api instanceof ApiConfiguration) {
-            throw new InvalidConfigurationException('Did not receive an instance of ApiConfiguration; received ' . get_class($api));
+            throw new InvalidConfigurationException('Did not receive an instance of ApiConfiguration; received '.get_class($api));
         }
         $api->setEnabled(true); // Gotta force this for this test
 
         $output->writeln('Sending un-authenticated payload...');
-        $client = new Client('http://' . $api->getApiHostname(). '/api/ping');
+        $client = new Client('http://'.$api->getApiHostname().'/api/ping');
         $request = $client->get();
         $response = $request->send();
         $output->writeln(
             'Checking for 200 status message... '
-            . ($response->getStatusCode() == '200'?'OK':'Failed')
+            . ($response->getStatusCode() == '200' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for application/json content type... '
-            . (stripos($response->getContentType(), 'application/json') !== false?'OK':'Failed')
+            . (stripos($response->getContentType(), 'application/json') !== false ? 'OK' : 'Failed')
         );
         $content = json_decode($response->getBody(), true);
         $output->writeln(
             'Checking for successful response... '
-            . (is_array($content) && isset($content['status']) && $content['status'] === 'success'?'OK':'Failed')
+            . (is_array($content) && isset($content['status']) && $content['status'] === 'success' ? 'OK' : 'Failed')
         );
 
         $output->writeln('');
@@ -62,16 +62,16 @@ 
 
         $output->writeln(
             'Checking for 200 status message... '
-            . ($response->getStatusCode() == '200'?'OK':'Failed')
+            . ($response->getStatusCode() == '200' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for application/json content type... '
-            . (stripos($response->getContentType(), 'application/json') !== false?'OK':'Failed')
+            . (stripos($response->getContentType(), 'application/json') !== false ? 'OK' : 'Failed')
         );
         $content = $request->getPayload($response);
         $output->writeln(
             'Checking for successful response... '
-            . (is_array($content) && isset($content['status']) && $content['status'] === 'success'?'OK':'Failed')
+            . (is_array($content) && isset($content['status']) && $content['status'] === 'success' ? 'OK' : 'Failed')
         );
 
 
@@ -82,20 +82,20 @@ 
         $response = $request->push('/api/echo-authed', ['message' => 'hello world']);
         $output->writeln(
             'Checking for 200 status message... '
-            . ($response->getStatusCode() == '200'?'OK':'Failed')
+            . ($response->getStatusCode() == '200' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for application/json content type... '
-            . (stripos($response->getContentType(), 'application/json') !== false?'OK':'Failed')
+            . (stripos($response->getContentType(), 'application/json') !== false ? 'OK' : 'Failed')
         );
         $content = $request->getPayload($response);
         $output->writeln(
             'Checking for successful response... '
-            . (is_array($content) && isset($content['status']) && $content['status'] === 'success'?'OK':'Failed')
+            . (is_array($content) && isset($content['status']) && $content['status'] === 'success' ? 'OK' : 'Failed')
         );
         $output->writeln(
             'Checking for matching echo message... '
-            . (is_array($content) && isset($content['message']) && $content['message'] === 'hello world'?'OK':'Failed')
+            . (is_array($content) && isset($content['message']) && $content['message'] === 'hello world' ? 'OK' : 'Failed')
         );
     }
     

lib/Util/Configuration/ClassConfigurationReader.php

Braces +3 added lines, -1 removed lines

@@ -53,7 +53,9 @@
             }
         }
 
-        if (!is_dir($configurationDir)) return;
+        if (!is_dir($configurationDir)) {
+            return;
+        }
 
         $configurationFile = get_class($config) . '.php';
         $configurationFile = $configurationDir . DIRECTORY_SEPARATOR . str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);

Spacing +4 added lines, -4 removed lines

@@ -44,9 +44,9 @@ 
             $isVendor = array_pop($testParts) == 'vendor';
 
             if ($isVendor) {
-                $path = realpath(__DIR__ . '/../../../../..'); // Get out of the Magium directories
+                $path = realpath(__DIR__.'/../../../../..'); // Get out of the Magium directories
             } else {
-                $path = realpath(__DIR__ . '/../../..');
+                $path = realpath(__DIR__.'/../../..');
             }
 
             $count = 0;
@@ -85,8 +85,8 @@ 
         $classes = array_reverse($classes);
 
         foreach ($classes as $class) {
-            $configurationFile = $class . '.php';
-            $configurationFile = $configurationDir . DIRECTORY_SEPARATOR . str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
+            $configurationFile = $class.'.php';
+            $configurationFile = $configurationDir.DIRECTORY_SEPARATOR.str_replace('\\', DIRECTORY_SEPARATOR, $configurationFile);
 
             if (file_exists($configurationFile)) {
                 include $configurationFile;

lib/Cli/CommandLoader.php

Spacing +4 added lines, -4 removed lines

@@ -19,7 +19,7 @@ 
     )
     {
         if (!is_dir($configDir)) {
-            throw new NotFoundException('Configuration dir not found: ' . $configDir);
+            throw new NotFoundException('Configuration dir not found: '.$configDir);
         }
         $this->config = $configDir;
 
@@ -28,14 +28,14 @@ 
 
     public function load()
     {
-        self::addCommandDir('Magium\Cli\Command', __DIR__ . '/Command');
+        self::addCommandDir('Magium\Cli\Command', __DIR__.'/Command');
 
         foreach (self::$dirs as $namespace => $dir) {
-            $files = glob($dir . '/*.php');
+            $files = glob($dir.'/*.php');
 
             foreach ($files as $file) {
                 $class = substr(basename($file), 0, -4);
-                $className = $namespace . '\\' . $class;
+                $className = $namespace.'\\'.$class;
                 if (class_exists($className)) {
                     $reflection = new \ReflectionClass($className);
                     if (!$reflection->isInstantiable()) {

lib/Cli/Command/SetElementValue.php

Spacing +4 added lines, -4 removed lines

@@ -34,11 +34,11 @@ 
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (!file_exists($this->path . '/magium.json')) {
+        if (!file_exists($this->path.'/magium.json')) {
             throw new NotFoundException('Configuration file not found.  Please execute magium:init.');
         }
         $reader = new \Zend\Config\Reader\Json();
-        $config = new Config($reader->fromFile($this->path . '/magium.json'), true);
+        $config = new Config($reader->fromFile($this->path.'/magium.json'), true);
 
         $class = $input->getArgument('class');
         $property = $input->getArgument('property');
@@ -51,7 +51,7 @@ 
             $config->magium = [];
         }
         if (!class_exists($class)) {
-            throw new NotFoundException('Could not find class: ' . $class . '.  You might need to escape blackslashes (\\\\)');
+            throw new NotFoundException('Could not find class: '.$class.'.  You might need to escape blackslashes (\\\\)');
         }
         $class = strtolower($class);
         $s = $config->magium;
@@ -62,7 +62,7 @@ 
         $s[$class]->$property = $value;
 
         $writer = new Json();
-        $writer->toFile($this->path . '/magium.json', $config);
+        $writer->toFile($this->path.'/magium.json', $config);
         $output->writeln(sprintf('Wrote value %s for "%s:%s" to %s/magium.json', $value, $class, $property, $this->path));
     }
 

lib/Cli/Command/GetElementValue.php

Spacing +3 added lines, -3 removed lines

@@ -37,7 +37,7 @@ 
         $collector = new DefaultPropertyCollector();
         $class = $input->getArgument('class');
         if (!class_exists($class)) {
-            throw new NotFoundException('Could not find the class: ' . $class);
+            throw new NotFoundException('Could not find the class: '.$class);
         }
         if (!is_subclass_of($class, 'Magium\AbstractConfigurableElement')) {
             throw new \InvalidArgumentException('Class must be a sub-class of Magium\AbstractConfigurableElement');
@@ -58,9 +58,9 @@ 
         foreach ($print as $property) {
             $output->writeln('');
             $output->writeln($property->getName());
-            $output->writeln("\tDefault Value: " . $property->getDefaultValue());
+            $output->writeln("\tDefault Value: ".$property->getDefaultValue());
             if ($property->getDescription()) {
-                $output->writeln("\t" . $property->getDescription());
+                $output->writeln("\t".$property->getDescription());
             }
         }
     }

lib/Cli/Command/AbstractApiEnablement.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 
     protected function configure()
     {
-        $this->setName('api:' . $this->getApiName());
+        $this->setName('api:'.$this->getApiName());
         $this->setDescription($this->getApiDescription());
     }
 

lib/Cli/Command/Init.php

Spacing +6 added lines, -6 removed lines

@@ -32,22 +32,22 @@
     {
         $path = $this->path;
         if ($path && $path[0] != '/' && $path[1] != ':') {
-            $path = getcwd() . '/' . $path;
+            $path = getcwd().'/'.$path;
         }
         $calcPath = $path;
         $path = realpath($path);
         if ($path === false) {
-            throw new NotFoundException('Path not found: ' . $calcPath);
+            throw new NotFoundException('Path not found: '.$calcPath);
         }
         if (!is_writable($path)) {
-            throw new NotAccessibleException('Could not write to path: ' . $calcPath);
+            throw new NotAccessibleException('Could not write to path: '.$calcPath);
         }
-        $fullPath = $path . '/magium.json';
+        $fullPath = $path.'/magium.json';
         if (file_exists($fullPath)) {
-            throw new ExistsException('The file exists already.  Will not overwrite: ' . $fullPath);
+            throw new ExistsException('The file exists already.  Will not overwrite: '.$fullPath);
         }
         file_put_contents($fullPath, '{}');
-        $output->writeln('Created empty JSON configuration file: ' . realpath($fullPath));
+        $output->writeln('Created empty JSON configuration file: '.realpath($fullPath));
 
     }
 

lib/Cli/Command/ListElements.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
     public static function addDirectory($dir, $namespace)
     {
         if ($dir != realpath($dir)) {
-            throw new InvalidConfigurationException('Path not found.  Please ensure that you pass the realpath() in: ' . $dir);
+            throw new InvalidConfigurationException('Path not found.  Please ensure that you pass the realpath() in: '.$dir);
         }
         self::$dirs[$dir] = $namespace;
     }
@@ -75,7 +75,7 @@ 
             'Set if you want the namespace output escaped (useful for copy and paste)'
         );
 
-        self::addDirectory(realpath(__DIR__ . '/../..'), 'Magium');
+        self::addDirectory(realpath(__DIR__.'/../..'), 'Magium');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
@@ -98,7 +98,7 @@ 
 
         sort($paths);
         $filter = $input->getArgument('filter');
-        if (count($paths) > 0 ) {
+        if (count($paths) > 0) {
             $output->writeln('Classes found: ');
             $escape = $input->getOption('escape');
 
@@ -107,7 +107,7 @@ 
                     $path = str_replace('\\', '\\\\', $path);
                 }
                 if ($filter && stripos($path, $filter) !== false) {
-                    $output->writeln("\t" . $path);
+                    $output->writeln("\t".$path);
                 }
             }
         } else {

lib/Cli/Command/SetSetting.php

Spacing +3 added lines, -3 removed lines

@@ -33,11 +33,11 @@ 
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (!file_exists($this->path . '/magium.json')) {
+        if (!file_exists($this->path.'/magium.json')) {
             throw new NotFoundException('Configuration file not found.  Please execute magium:init.');
         }
         $reader = new \Zend\Config\Reader\Json();
-        $config = new Config($reader->fromFile($this->path . '/magium.json'), true);
+        $config = new Config($reader->fromFile($this->path.'/magium.json'), true);
 
         $name = $input->getArgument('name');
         $value = $input->getArgument('value');
@@ -52,7 +52,7 @@ 
         $config->config->$name = $value;
 
         $writer = new Json();
-        $writer->toFile($this->path . '/magium.json', $config);
+        $writer->toFile($this->path.'/magium.json', $config);
         $output->writeln(sprintf('Wrote value for "%s" to %s/magium.json', $name, $this->path));
     }