magium / Magium

lib/Extractors/AbstractAddressExtractor.php

Doc Comments +13 added lines, -10 removed lines

@@ -19,6 +19,9 @@ 
 
     protected $remainingRows;
 
+    /**
+     * @return string
+     */
     abstract function getBaseXpath();
 
     public function extract()
@@ -90,7 +93,7 @@ 
 
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getName()
     {
@@ -98,7 +101,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getBusiness()
     {
@@ -106,7 +109,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getStreet1()
     {
@@ -114,7 +117,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getStreet2()
     {
@@ -122,7 +125,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getCity()
     {
@@ -130,7 +133,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getRegion()
     {
@@ -138,7 +141,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getPostCode()
     {
@@ -146,7 +149,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getCountry()
     {
@@ -154,7 +157,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getPhone()
     {
@@ -162,7 +165,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getFax()
     {

Spacing +5 added lines, -5 removed lines

@@ -31,10 +31,10 @@ 
         $this->name = trim(array_pop($rows));
         while (count($rows) > 0) {
             $row = array_shift($rows);
-            if (strpos($row, 'T: ') ===0) {
+            if (strpos($row, 'T: ') === 0) {
                 $this->phone = trim(substr($row, 3));
                 continue;
-            } else if (strpos($row, 'F: ') ===0) {
+            } else if (strpos($row, 'F: ') === 0) {
                 $this->fax = trim(substr($row, 3));
                 continue;
             }
@@ -59,7 +59,7 @@ 
             $this->street1 = trim(array_shift($rows));
             $this->business = trim(array_shift($rows));
             //Easy
-        }else if (count($rows) == 1) {
+        } else if (count($rows) == 1) {
             $this->street1 = trim(array_shift($rows));
 
             // Not so easy
@@ -70,8 +70,8 @@ 
                 $this->street1 = $stOrBus;
                 $this->business = trim(array_shift($rows));
             } else {
-                $this->street1 =trim(array_shift($rows));
-                $this->street2 =  $stOrBus;
+                $this->street1 = trim(array_shift($rows));
+                $this->street2 = $stOrBus;
             }
 
         }

Braces +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
             $this->street1 = trim(array_shift($rows));
             $this->business = trim(array_shift($rows));
             //Easy
-        }else if (count($rows) == 1) {
+        } else if (count($rows) == 1) {
             $this->street1 = trim(array_shift($rows));
 
             // Not so easy

lib/Util/Log/Logger.php

Doc Comments +6 added lines

@@ -45,11 +45,17 @@
     }
 
 
+    /**
+     * @param string $name
+     */
     public function setTestName($name)
     {
         $this->testName = $name;
     }
 
+    /**
+     * @param string $status
+     */
     public function setTestStatus($status)
     {
         $this->status = $status;

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Exception;
 use Magium\Assertions\AbstractAssertion;
-use Magium\Assertions\AbstractSelectorAssertion;
 use Magium\Util\Phpunit\MasterListener;
 use Magium\Util\Phpunit\MasterListenerAware;
 use PHPUnit_Framework_AssertionFailedError;

lib/Util/Translator/Translator.php

Doc Comments +3 added lines

@@ -91,6 +91,9 @@
     }
 
 
+    /**
+     * @param string $textDomain
+     */
     protected function translatePart($translate, $result, $textDomain, $locale)
     {
         $newResult = parent::translate($result, $textDomain, $locale);

lib/WebDriver/WebDriver.php

Doc Comments +7 added lines

@@ -28,6 +28,10 @@ 
     protected $logger;
 
 
+    /**
+     * @param string $by
+     * @param string $selector
+     */
     public function logFind($by, $selector)
     {
         if ($this->logger instanceof Logger) {
@@ -94,6 +98,9 @@ 
         return $element;
     }
 
+    /**
+     * @param string $selector
+     */
     public function elementExists($selector, $by = 'byId')
     {
         try {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Facebook\WebDriver\Exception\WebDriverException;
 use Facebook\WebDriver\Remote\HttpCommandExecutor;
-use Facebook\WebDriver\Remote\RemoteExecuteMethod;
 use Facebook\WebDriver\Remote\RemoteWebDriver;
 use Facebook\WebDriver\WebDriverBy;
 use Facebook\WebDriver\WebDriverElement;

lib/WebDriver/WebDriverElementProxy.php

Doc Comments +3 added lines

@@ -24,6 +24,9 @@
         $this->by = $by;
     }
 
+    /**
+     * @param string $name
+     */
     public function __call($name, $arguments)
     {
         if (strpos($name, '::') > 0) {

example_configuration_not_used/Magium/Themes/ThemeConfiguration.php

Spacing +1 added lines, -1 removed lines

@@ -1,3 +1,3 @@
 <?php
 
-$this->baseUrl                      = 'http://magento19.loc//';
\ No newline at end of file
+$this->baseUrl = 'http://magento19.loc//';
\ No newline at end of file

lib/Extractors/Navigation/UnableToExtractMenuXpathException.php

Spacing +1 added lines, -1 removed lines

@@ -2,4 +2,4 @@
 
 namespace Magium\Extractors\Navigation;
 
-class UnableToExtractMenuXpathException extends \Exception{}
\ No newline at end of file
+class UnableToExtractMenuXpathException extends \Exception {}
\ No newline at end of file

lib/Extractors/Navigation/MissingNavigationSchemeException.php

Spacing +1 added lines, -1 removed lines

@@ -2,4 +2,4 @@
 
 namespace Magium\Extractors\Navigation;
 
-class MissingNavigationSchemeException extends \Exception{}
\ No newline at end of file
+class MissingNavigationSchemeException extends \Exception {}
\ No newline at end of file

lib/Extractors/DateTime.php

Spacing +6 added lines, -6 removed lines

@@ -113,7 +113,7 @@ 
             return true;
         }
         $parse = date_parse($part);
-        if ($parse && $parse['day'] !== false && $parse['error_count'] == 0 ) {
+        if ($parse && $parse['day'] !== false && $parse['error_count'] == 0) {
             return true;
         } else if (preg_match('/^\d{1,2}[\/\\-]\d{1,2}[\/\\-]\d{1,2}$/', $part)) {
             return true;
@@ -127,7 +127,7 @@ 
             return true;
         }
         $parse = date_parse($part);
-        if ($parse && $parse['month'] !== false && $parse['error_count'] == 0 ) {
+        if ($parse && $parse['month'] !== false && $parse['error_count'] == 0) {
             return true;
         } else if (preg_match('/^\d{1,2}[\/\\-]\d{1,2}[\/\\-]\d{1,2}$/', $part)) {
             return true;
@@ -141,7 +141,7 @@ 
         if ($parse && $parse['year'] !== false && $parse['error_count'] == 0) {
             return true;
             // DateTime parses 2015 as 20:15:00, so this is to account for the unique condition.
-        } else if (strlen($part) ==4 ) {
+        } else if (strlen($part) == 4) {
             if ($parse['second'] === 0 && $parse['hour'] == substr($part, 0, 2) && $parse['minute'] == substr($part, 2, 2)) {
                 return true;
             }
@@ -162,7 +162,7 @@ 
             return false;
         }
         $parse = date_parse($part);
-        if ($parse && $parse['hour'] !== false && $parse['error_count'] == 0 ) {
+        if ($parse && $parse['hour'] !== false && $parse['error_count'] == 0) {
             return true;
         }
         return false;
@@ -179,7 +179,7 @@ 
             return false;
         }
         $parse = date_parse($part);
-        if ($parse && $parse['minute'] !== false && $parse['error_count'] == 0 ) {
+        if ($parse && $parse['minute'] !== false && $parse['error_count'] == 0) {
             return true;
 
         }
@@ -197,7 +197,7 @@ 
             return false;
         }
         $parse = date_parse($part);
-        if ($parse && $parse['second'] !== false && $parse['error_count'] == 0 ) {
+        if ($parse && $parse['second'] !== false && $parse['error_count'] == 0) {
             return true;
         }
         return false;

Braces +3 added lines, -1 removed lines

@@ -53,7 +53,9 @@
         $max = false;
         $min = PHP_INT_MAX;
         foreach ($matchedParts as $part) {
-            if ($part === null) continue;
+            if ($part === null) {
+                continue;
+            }
             if ($part >= $max) {
                 $max = $part;
             }