EnvironmentConfigurationReader::configure() - Code Metrics - magium/Magium - Measure and Improve Code Quality continuously with Scrutinizer

EnvironmentConfigurationReader::configure() A
last analyzed 2018-02-12 14:00 UTC

↳ Parent: EnvironmentConfigurationReader

Complexity

Conditions	4
Paths	4

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	4
nop	1

<?php

namespace Magium\Util\Configuration;

class EnvironmentConfigurationReader extends AbstractConfigurationReader

{


    public function configure(ConfigurableObjectInterface $config)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $classes = $this->introspectClass($config);

        foreach ($classes as $class) {

            $variablePrefix = 'MAGIUM_' . str_replace('\\', '_', strtoupper($class)) . '_';

            // Fixes https://github.com/magium/Magium/issues/114
            $props = array_merge($_SERVER, $_ENV);

            foreach ($props as $key => $value) {
                if (strpos($key, $variablePrefix) === 0) {
                    $property = substr($key, strlen($variablePrefix));
                    $config->set($property, $value);
                }
            }
        }
    }

}


1			<?php
2
3			namespace Magium\Util\Configuration;
4
5			class EnvironmentConfigurationReader extends AbstractConfigurationReader
6
7			{
			0 ignored issues – show Coding Style introduced 2016-11-30 16:32 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the line following the class declaration; found 1 line(s) Loading history...
8
9			public function configure(ConfigurableObjectInterface $config)
			0 ignored issues – show Coding Style introduced 2017-08-09 22:16 UTC by Report Bug Copy Issue Report `configure` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-08-09 22:16 UTC by Report Bug Copy Issue Report `configure` uses the super-global variable `$_ENV` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
10			{
11			$classes = $this->introspectClass($config);
12
13			foreach ($classes as $class) {
14
15			$variablePrefix = 'MAGIUM_' . str_replace('\\', '_', strtoupper($class)) . '_';
16
17			// Fixes https://github.com/magium/Magium/issues/114
18			$props = array_merge($_SERVER, $_ENV);
19
20			foreach ($props as $key => $value) {
21			if (strpos($key, $variablePrefix) === 0) {
22			$property = substr($key, strlen($variablePrefix));
23			$config->set($property, $value);
24			}
25			}
26			}
27			}
28
29			}
30

magium / Magium

EnvironmentConfigurationReader::configure() A last analyzed 2018-02-12 14:00 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EnvironmentConfigurationReader::configure() A
last analyzed 2018-02-12 14:00 UTC