RemoveBuyNowVal::execute() - Code Metrics - Inspection of "Add Old Cart Restore Feature" - mageprince/magento2-buynow - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#49)

by Mage

created 2022-06-11 11:30 UTC

RemoveBuyNowVal::execute() A

↳ Parent: RemoveBuyNowVal

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	5
rs	10

<?php

/**
 * MagePrince
 * Copyright (C) 2020 Mageprince <[email protected]>
 *
 * @package Mageprince_BuyNow
 * @copyright Copyright (c) 2020 Mageprince (http://www.mageprince.com/)
 * @license http://opensource.org/licenses/gpl-3.0.html GNU General Public License,version 3 (GPL-3.0)
 * @author MagePrince <[email protected]>
 */

namespace Mageprince\BuyNow\Observer;

use Magento\Checkout\Model\Cart as CustomerCart;
filter:
    dependency_paths: ["lib/*"]

class RemoveBuyNowVal implements \Magento\Framework\Event\ObserverInterface
filter:
    dependency_paths: ["lib/*"]
{
    /**
     * @param \Magento\Quote\Model\QuoteFactory $quoteFactory
     * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository
     * @param CustomerCart $cart
     */
    public function __construct(
        \Magento\Quote\Model\QuoteFactory $quoteFactory,
filter:
    dependency_paths: ["lib/*"]
        \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository,
filter:
    dependency_paths: ["lib/*"]
        CustomerCart $cart
    ) {
        $this->quoteFactory = $quoteFactory;

        $this->customerRepository = $customerRepository;

        $this->cart = $cart;

    }

    public function execute(\Magento\Framework\Event\Observer $observer)
filter:
    dependency_paths: ["lib/*"]
    {
        if ($this->cart->getQuote()->getItemsCount() > 1) {
            $this->cart->getQuote()->setBuyNowId(0);
            $this->cart->getQuote()->save();
        }
    }
}


1			<?php
2
3			/**
4			* MagePrince
5			* Copyright (C) 2020 Mageprince <[email protected]>
6			*
7			* @package Mageprince_BuyNow
8			* @copyright Copyright (c) 2020 Mageprince (http://www.mageprince.com/)
9			* @license http://opensource.org/licenses/gpl-3.0.html GNU General Public License,version 3 (GPL-3.0)
10			* @author MagePrince <[email protected]>
11			*/
12
13			namespace Mageprince\BuyNow\Observer;
14
15			use Magento\Checkout\Model\Cart as CustomerCart;
			0 ignored issues – show Bug introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The type `Magento\Checkout\Model\Cart` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16
17			class RemoveBuyNowVal implements \Magento\Framework\Event\ObserverInterface
			0 ignored issues – show Bug introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Event\ObserverInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18			{
19			/**
20			* @param \Magento\Quote\Model\QuoteFactory $quoteFactory
21			* @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository
22			* @param CustomerCart $cart
23			*/
24			public function __construct(
25			\Magento\Quote\Model\QuoteFactory $quoteFactory,
			0 ignored issues – show Bug introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The type `Magento\Quote\Model\QuoteFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
26			\Magento\Customer\Api\CustomerRepositoryInterface $customerRepository,
			0 ignored issues – show Bug introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The type `Magento\Customer\Api\CustomerRepositoryInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
27			CustomerCart $cart
28			) {
29			$this->quoteFactory = $quoteFactory;
			0 ignored issues – show Bug Best Practice introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The property `quoteFactory` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
30			$this->customerRepository = $customerRepository;
			0 ignored issues – show Bug Best Practice introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The property `customerRepository` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
31			$this->cart = $cart;
			0 ignored issues – show Bug Best Practice introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The property `cart` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
32			}
33
34			public function execute(\Magento\Framework\Event\Observer $observer)
			0 ignored issues – show Bug introduced 2022-06-04 10:47 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Event\Observer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
35			{
36			if ($this->cart->getQuote()->getItemsCount() > 1) {
37			$this->cart->getQuote()->setBuyNowId(0);
38			$this->cart->getQuote()->save();
39			}
40			}
41			}
42

mageprince / magento2-buynow

Pull Request — master (#49)

RemoveBuyNowVal::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like