GetSoftDependencies::__construct() - Code Metrics - Inspection of "Add scrutinizer-ci config" - magento-hackathon/magerun2-generate-dependencies - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 897468...9581f6 )

by Lars

created 2019-02-09 23:29 UTC

GetSoftDependencies::__construct() A

↳ Parent: GetSoftDependencies

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php


namespace MagentoHackathon\Service;

use Magento\Framework\Component\ComponentRegistrar;
filter:
    dependency_paths: ["lib/*"]
use SimpleXMLElement;

class GetSoftDependencies
{
    /** @var ComponentRegistrar $registrar */
    private $componentRegistrar;

    public function __construct($componentRegistrar)
    {
        $this->componentRegistrar = $componentRegistrar;
    }

    /**
     * @param SimpleXMLElement $softDependenciesXml
     * @return array
     */
    public function execute(SimpleXMLElement $softDependenciesXml)
    {

        $path = $this->componentRegistrar->getPaths(ComponentRegistrar::MODULE);

        $softDependencies = [[]];

        if (isset($softDependenciesXml->module->sequence)) {
            return $softDependencies;
        }

        foreach ($softDependenciesXml->module->sequence->module as $module) {
            $moduleName = (string)$module->attributes()->name;
            if (\array_key_exists($moduleName, $path)) {
                $composerFilePath = preg_replace('/\/src$/', '', $path[$moduleName]);

            }
        }

        return array_merge(...$softDependencies);
    }
}


1			<?php
2
3
4			namespace MagentoHackathon\Service;
5
6			use Magento\Framework\Component\ComponentRegistrar;
			0 ignored issues – show Bug introduced 2019-02-09 23:42 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Component\ComponentRegistrar` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use SimpleXMLElement;
8
9			class GetSoftDependencies
10			{
11			/** @var ComponentRegistrar $registrar */
12			private $componentRegistrar;
13
14			public function __construct($componentRegistrar)
15			{
16			$this->componentRegistrar = $componentRegistrar;
17			}
18
19			/**
20			* @param SimpleXMLElement $softDependenciesXml
21			* @return array
22			*/
23			public function execute(SimpleXMLElement $softDependenciesXml)
24			{
25
26			$path = $this->componentRegistrar->getPaths(ComponentRegistrar::MODULE);
27
28			$softDependencies = [[]];
29
30			if (isset($softDependenciesXml->module->sequence)) {
31			return $softDependencies;
32			}
33
34			foreach ($softDependenciesXml->module->sequence->module as $module) {
35			$moduleName = (string)$module->attributes()->name;
36			if (\array_key_exists($moduleName, $path)) {
37			$composerFilePath = preg_replace('/\/src$/', '', $path[$moduleName]);
			0 ignored issues – show Unused Code introduced 2019-02-09 23:42 UTC by Report Bug Copy Issue Report The assignment to `$composerFilePath` is dead and can be removed. Loading history...
38			}
39			}
40
41			return array_merge(...$softDependencies);
42			}
43			}
44

magento-hackathon / magerun2-generate-dependencies

Push — master ( 897468...9581f6 )

GetSoftDependencies::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like