Form::_prepareForm() - Code Metrics - Inspection of "Merge pull request #28 from torhoehn/feature/admin..." - magento-hackathon/DevDashboard2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 568d87...b0a8a2 )

by Fabian

created 2021-02-07 12:53 UTC

Form::_prepareForm() B

↳ Parent: Form

Complexity

Conditions	1
Paths	1

Size

Total Lines	110
Code Lines	72

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	72
c	1
b	0
f	1
dl	0
loc	110
rs	8.6109
cc	1
nc	1
nop	0

How to fix Long Method

<?php
declare(strict_types=1);

namespace Firegento\DevDashboard\Block\System\Account\Edit;

use Magento\Config\Model\Config\Source\Yesno;
use Magento\Framework\App\ObjectManager;
use Magento\Framework\Locale\OptionInterface;

class Form extends \Magento\Backend\Block\System\Account\Edit\Form
{
    private $yesno;

    private $deployedLocales;

    public function __construct(
        \Magento\Backend\Block\Template\Context $context,
        \Magento\Framework\Registry $registry,
        \Magento\Framework\Data\FormFactory $formFactory,
        \Magento\User\Model\UserFactory $userFactory,
filter:
    dependency_paths: ["lib/*"]
        \Magento\Backend\Model\Auth\Session $authSession,
        \Magento\Framework\Locale\ListsInterface $localeLists,
        array $data = [],
        OptionInterface $deployedLocales = null,
        Yesno $yesno
    ) {
        parent::__construct($context, $registry, $formFactory, $userFactory, $authSession, $localeLists, $data, $deployedLocales);
        $this->yesno = $yesno;
        $this->deployedLocales = $deployedLocales
            ?: ObjectManager::getInstance()->get(OptionInterface::class);;
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
    }

    /**
     * @inheritdoc
     */
    protected function _prepareForm()
    {
        $userId = $this->_authSession->getUser()->getId();
        $user = $this->_userFactory->create()->load($userId);
        $user->unsetData('password');

        /** @var \Magento\Framework\Data\Form $form */
        $form = $this->_formFactory->create();

        $fieldset = $form->addFieldset('base_fieldset', ['legend' => __('Account Information')]);

        $fieldset->addField(
            'username',
            'text',
            ['name' => 'username', 'label' => __('User Name'), 'title' => __('User Name'), 'required' => true]
        );

        $fieldset->addField(
            'firstname',
            'text',
            ['name' => 'firstname', 'label' => __('First Name'), 'title' => __('First Name'), 'required' => true]
        );

        $fieldset->addField(
            'lastname',
            'text',
            ['name' => 'lastname', 'label' => __('Last Name'), 'title' => __('Last Name'), 'required' => true]
        );

        $fieldset->addField('user_id', 'hidden', ['name' => 'user_id']);

        $fieldset->addField(
            'email',
            'text',
            ['name' => 'email', 'label' => __('Email'), 'title' => __('User Email'), 'required' => true]
        );

        $fieldset->addField(
            'password',
            'password',
            [
                'name' => 'password',
                'label' => __('New Password'),
                'title' => __('New Password'),
                'class' => 'validate-admin-password'
            ]
        );

        $fieldset->addField(
            'confirmation',
            'password',
            [
                'name' => 'password_confirmation',
                'label' => __('Password Confirmation'),
                'class' => 'validate-cpassword'
            ]
        );

        $fieldset->addField(
            'interface_locale',
            'select',
            [
                'name' => 'interface_locale',
                'label' => __('Interface Locale'),
                'title' => __('Interface Locale'),
                'values' => $this->deployedLocales->getTranslatedOptionLocales(),
                'class' => 'select'
            ]
        );

        $fieldset->addField(
            'use_devdashboard',
            'select',
            [
                'name' => 'use_devdashboard',
                'label' => __('Use developer dashboard as default'),
                'title' => __('Use developer dashboard'),
                'values' => $this->yesno->toOptionArray(),
                'class' => 'select'
            ]
        );

        $verificationFieldset = $form->addFieldset(
            'current_user_verification_fieldset',
            ['legend' => __('Current User Identity Verification')]
        );
        $verificationFieldset->addField(
            self::IDENTITY_VERIFICATION_PASSWORD_FIELD,
            'password',
            [
                'name' => self::IDENTITY_VERIFICATION_PASSWORD_FIELD,
                'label' => __('Your Password'),
                'id' => self::IDENTITY_VERIFICATION_PASSWORD_FIELD,
                'title' => __('Your Password'),
                'class' => 'validate-current-password required-entry',
                'required' => true
            ]
        );

        $data = $user->getData();
        unset($data[self::IDENTITY_VERIFICATION_PASSWORD_FIELD]);
        $form->setValues($data);
        $form->setAction($this->getUrl('adminhtml/system_account/save'));
        $form->setMethod('post');
        $form->setUseContainer(true);
        $form->setId('edit_form');

        $this->setForm($form);

        return \Magento\Backend\Block\Widget\Form::_prepareForm();
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Firegento\DevDashboard\Block\System\Account\Edit;
5
6			use Magento\Config\Model\Config\Source\Yesno;
7			use Magento\Framework\App\ObjectManager;
8			use Magento\Framework\Locale\OptionInterface;
9
10			class Form extends \Magento\Backend\Block\System\Account\Edit\Form
11			{
12			private $yesno;
13
14			private $deployedLocales;
15
16			public function __construct(
17			\Magento\Backend\Block\Template\Context $context,
18			\Magento\Framework\Registry $registry,
19			\Magento\Framework\Data\FormFactory $formFactory,
20			\Magento\User\Model\UserFactory $userFactory,
			0 ignored issues – show Bug introduced 2021-02-07 11:09 UTC by Report Bug Copy Issue Report The type `Magento\User\Model\UserFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21			\Magento\Backend\Model\Auth\Session $authSession,
22			\Magento\Framework\Locale\ListsInterface $localeLists,
23			array $data = [],
24			OptionInterface $deployedLocales = null,
25			Yesno $yesno
26			) {
27			parent::__construct($context, $registry, $formFactory, $userFactory, $authSession, $localeLists, $data, $deployedLocales);
28			$this->yesno = $yesno;
29			$this->deployedLocales = $deployedLocales
30			?: ObjectManager::getInstance()->get(OptionInterface::class);;
			0 ignored issues – show Coding Style introduced 2021-02-07 11:09 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
31			}
32
33			/**
34			* @inheritdoc
35			*/
36			protected function _prepareForm()
37			{
38			$userId = $this->_authSession->getUser()->getId();
39			$user = $this->_userFactory->create()->load($userId);
40			$user->unsetData('password');
41
42			/** @var \Magento\Framework\Data\Form $form */
43			$form = $this->_formFactory->create();
44
45			$fieldset = $form->addFieldset('base_fieldset', ['legend' => __('Account Information')]);
46
47			$fieldset->addField(
48			'username',
49			'text',
50			['name' => 'username', 'label' => __('User Name'), 'title' => __('User Name'), 'required' => true]
51			);
52
53			$fieldset->addField(
54			'firstname',
55			'text',
56			['name' => 'firstname', 'label' => __('First Name'), 'title' => __('First Name'), 'required' => true]
57			);
58
59			$fieldset->addField(
60			'lastname',
61			'text',
62			['name' => 'lastname', 'label' => __('Last Name'), 'title' => __('Last Name'), 'required' => true]
63			);
64
65			$fieldset->addField('user_id', 'hidden', ['name' => 'user_id']);
66
67			$fieldset->addField(
68			'email',
69			'text',
70			['name' => 'email', 'label' => __('Email'), 'title' => __('User Email'), 'required' => true]
71			);
72
73			$fieldset->addField(
74			'password',
75			'password',
76			[
77			'name' => 'password',
78			'label' => __('New Password'),
79			'title' => __('New Password'),
80			'class' => 'validate-admin-password'
81			]
82			);
83
84			$fieldset->addField(
85			'confirmation',
86			'password',
87			[
88			'name' => 'password_confirmation',
89			'label' => __('Password Confirmation'),
90			'class' => 'validate-cpassword'
91			]
92			);
93
94			$fieldset->addField(
95			'interface_locale',
96			'select',
97			[
98			'name' => 'interface_locale',
99			'label' => __('Interface Locale'),
100			'title' => __('Interface Locale'),
101			'values' => $this->deployedLocales->getTranslatedOptionLocales(),
102			'class' => 'select'
103			]
104			);
105
106			$fieldset->addField(
107			'use_devdashboard',
108			'select',
109			[
110			'name' => 'use_devdashboard',
111			'label' => __('Use developer dashboard as default'),
112			'title' => __('Use developer dashboard'),
113			'values' => $this->yesno->toOptionArray(),
114			'class' => 'select'
115			]
116			);
117
118			$verificationFieldset = $form->addFieldset(
119			'current_user_verification_fieldset',
120			['legend' => __('Current User Identity Verification')]
121			);
122			$verificationFieldset->addField(
123			self::IDENTITY_VERIFICATION_PASSWORD_FIELD,
124			'password',
125			[
126			'name' => self::IDENTITY_VERIFICATION_PASSWORD_FIELD,
127			'label' => __('Your Password'),
128			'id' => self::IDENTITY_VERIFICATION_PASSWORD_FIELD,
129			'title' => __('Your Password'),
130			'class' => 'validate-current-password required-entry',
131			'required' => true
132			]
133			);
134
135			$data = $user->getData();
136			unset($data[self::IDENTITY_VERIFICATION_PASSWORD_FIELD]);
137			$form->setValues($data);
138			$form->setAction($this->getUrl('adminhtml/system_account/save'));
139			$form->setMethod('post');
140			$form->setUseContainer(true);
141			$form->setId('edit_form');
142
143			$this->setForm($form);
144
145			return \Magento\Backend\Block\Widget\Form::_prepareForm();
146			}
147			}
148

magento-hackathon / DevDashboard2

Push — master ( 568d87...b0a8a2 )

Form::_prepareForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like