SaveConfig::afterExecute() - Code Metrics - Inspection of "Add auth.json for repo.magento.com access in Scrut..." - magento-hackathon/DevDashboard2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ca7167...276d5c )

by Fabian

created 2018-03-11 11:47 UTC

SaveConfig::afterExecute() A

↳ Parent: SaveConfig

Complexity

Conditions	2
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	4
nop	1

<?php

namespace Firegento\DevDashboard\Plugin;


class SaveConfig
{

    protected $_whitelist =[
       'user_id',
       'configuration',
       'use_devdashboard'
    ];

    protected $_configRepository;

    protected $_messageManager;

    /**
     * SaveConfig constructor.
     * @param \Firegento\DevDashboard\Model\ConfigFactory $configRepository
filter:
    dependency_paths: ["lib/*"]
     * @param \Magento\Framework\Message\ManagerInterface $messageManager
     */
    public function __construct(
        \Firegento\DevDashboard\Model\ConfigRepository $configRepository,
        \Magento\Framework\Message\ManagerInterface $messageManager
    ) {
        $this->_configRepository = $configRepository;
        $this->_messageManager = $messageManager;
    }


    /**
     * @param \Magento\User\Controller\Adminhtml\User\Save $subject
     * @return array|void
     * @throws \Exception
     */
    public function afterExecute(\Magento\User\Controller\Adminhtml\User\Save $subject)
filter:
    dependency_paths: ["lib/*"]
    {
        $userId = (int)$subject->getRequest()->getParam('user_id');
        $data = $subject->getRequest()->getPostValue();
        $data = $this->_filterData($data);

        try {

            /** @var \Firegento\DevDashboard\Model\Config $model */
            $model = $this->_configRepository->getByUserId($userId);
            $model->setData($data);
            $this->_configRepository->save($model);

        } catch (\Exception $e) {
            $this->_messageManager->addErrorMessage($e->getMessage());
        }
        return [];
    }

    /**
     * @param $data
     * @return array
     */
    protected function _filterData($data)
    {
        $filtered = [];

        foreach($this->_whitelist as $key) {
            $filtered[$key] = $data[$key];
        }
        return $filtered;
    }
}

1			<?php
2
3			namespace Firegento\DevDashboard\Plugin;
4
5
6			class SaveConfig
7			{
8
9			protected $_whitelist =[
10			'user_id',
11			'configuration',
12			'use_devdashboard'
13			];
14
15			protected $_configRepository;
16
17			protected $_messageManager;
18
19			/**
20			* SaveConfig constructor.
21			* @param \Firegento\DevDashboard\Model\ConfigFactory $configRepository
			0 ignored issues – show Bug introduced 2018-03-11 11:53 UTC by Report Bug Copy Issue Report The type `Firegento\DevDashboard\Model\ConfigFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
22			* @param \Magento\Framework\Message\ManagerInterface $messageManager
23			*/
24			public function __construct(
25			\Firegento\DevDashboard\Model\ConfigRepository $configRepository,
26			\Magento\Framework\Message\ManagerInterface $messageManager
27			) {
28			$this->_configRepository = $configRepository;
29			$this->_messageManager = $messageManager;
30			}
31
32
33			/**
34			* @param \Magento\User\Controller\Adminhtml\User\Save $subject
35			* @return array\|void
36			* @throws \Exception
37			*/
38			public function afterExecute(\Magento\User\Controller\Adminhtml\User\Save $subject)
			0 ignored issues – show Bug introduced 2018-03-11 11:53 UTC by Report Bug Copy Issue Report The type `Magento\User\Controller\Adminhtml\User\Save` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
39			{
40			$userId = (int)$subject->getRequest()->getParam('user_id');
41			$data = $subject->getRequest()->getPostValue();
42			$data = $this->_filterData($data);
43
44			try {
45
46			/** @var \Firegento\DevDashboard\Model\Config $model */
47			$model = $this->_configRepository->getByUserId($userId);
48			$model->setData($data);
49			$this->_configRepository->save($model);
50
51			} catch (\Exception $e) {
52			$this->_messageManager->addErrorMessage($e->getMessage());
53			}
54			return [];
55			}
56
57			/**
58			* @param $data
59			* @return array
60			*/
61			protected function _filterData($data)
62			{
63			$filtered = [];
64
65			foreach($this->_whitelist as $key) {
66			$filtered[$key] = $data[$key];
67			}
68			return $filtered;
69			}
70			}

magento-hackathon / DevDashboard2

Push — master ( ca7167...276d5c )

SaveConfig::afterExecute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like