Issues in UserController.php (master) - Issues in master - mafd16/comment - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/User/UserController.php (23 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Mafd16\User;

use \Anax\Configure\ConfigureInterface;
use \Anax\Configure\ConfigureTrait;
use \Anax\DI\InjectionAwareInterface;
use \Anax\Di\InjectionAwareTrait;
use \Anax\User\HTMLForm\UserLoginForm;
use \Anax\User\HTMLForm\CreateUserForm;

/**
 * A controller class.
 */
class UserController implements
    ConfigureInterface,
    InjectionAwareInterface
{
    use ConfigureTrait,
        InjectionAwareTrait;



    /**
     * Protected variables
     */
    protected $view;
    protected $pageRender;
    protected $request;
    protected $response;
    protected $session;


    /**
     * Set services to variables
     *
     */
    public function setUp()
    {
        $this->view       = $this->di->get("view");
        $this->pageRender = $this->di->get("pageRender");
        $this->request    = $this->di->get("request");
        $this->response   = $this->di->get("response");
        $this->session    = $this->di->get("session");
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getIndex()

    {
        $title      = "A index page";
        $data = [
            "content" => "An index page",
        ];
        $this->view->add("default2/article", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getLogin()

    {
        $title      = "A login page";
        $data = [
            "message" => "",
        ];
        $this->view->add("user/crud/login", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getCreateUser($message = null)

    {
        $title      = "A create user page";
        $data = [
            "message" => $message,
        ];
        $this->view->add("user/crud/create", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function postCreatingUser()
    {
        // Get POST-variables
        $acronym = $this->request->getPost("name");
        $email = $this->request->getPost("email");
        $password = $this->request->getPost("password");
        $passwordagain = $this->request->getPost("passwordagain");

        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->getCreateUser($message);
            return;
        }
        $newUser = (object) [
            "acronym" => $acronym,
            "password" => $password,
            "email" => $email,
        ];
        $createdUser = $this->di->get("user")->createUser($newUser);
        if (!$createdUser) {
            $message = "<p>User " . $acronym . " already exists!</p>";
            $this->getCreateUser($message);
            return;
        }
        // Save user to session
        $this->di->get("user")->saveToSession($createdUser);
        // Redirect back to profile
        $this->response->redirect("user/profile");
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getUserProfile()
    {
        $title      = "A profile page";
        // Get user from db
        $id = $this->session->get("my_user_id");
        $user = $this->di->get("user")->getUserFromDatabase("id", $id);

        $data = [
            "user" => $user,
        ];
        $this->view->add("user/crud/profile", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function validateUser()
    {
        // Get POST-variables
        $acronym = $this->request->getPost("name");
        $password = $this->request->getPost("password");
        // Get the user from DB
        $user = $this->di->get("user")->getUserFromDatabase("acronym", $acronym);

        if ($user->deleted) {
            $title = "A login page";
            $data = [
                "message" => $user->acronym . " were deleted " . $user->deleted,
            ];
            $this->view->add("user/crud/login", $data);
            $this->pageRender->renderPage(["title" => $title]);
        }

        // Validate password against database
        $valid = $user->verifyPassword($acronym, $password);
        // if true, save user id to session and goto profile
        if ($valid) {
            // Save user id to session
            $this->di->get("user")->saveToSession($user);
            $this->response->redirect("user/profile");
        } else {
            // if false goto login
            $title = "A login page";
            $data = [
                "acronym" => $acronym,
                "password" => $password,
                "valid" => $valid,
                "message" => "Name or password was incorrect!",
            ];
            $this->view->add("user/crud/login", $data);
            $this->pageRender->renderPage(["title" => $title]);
        }
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function updateGetUserProfile($message = null)

    {
        $title      = "Update user";
        // Get user from db
        $id = $this->session->get("my_user_id");
        $user = $this->di->get("user")->getUserFromDatabase("id", $id);
        $data = [
            "user" => $user,
            "message" => $message,
        ];
        $this->view->add("user/crud/update", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function updatePostUserProfile()
    {
        // Get POST-variables
        $email = $this->request->getPost("email");
        $password = $this->request->getPost("password");
        $passwordagain = $this->request->getPost("passwordagain");

        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->updateGetUserProfile($message);
        }
        // Get user id from session
        $id = $this->session->get("my_user_id");
        // Update user
        $update = (object) [
            "password" => $password,
            "email" => $email,
        ];
        $user = $this->di->get("user")->updateUserInDatabase($id, $update);
        $this->di->get("user")->saveToSession($user);
        // Redirect back to profile
        $this->response->redirect("user/profile");
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getLogout()
    {
        $this->di->get("user")->logoutUser();
        // Redirect back to login
        $this->response->redirect("user/login");
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdmin()
    {
        $title      = "An admin page";
        // Get users from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $data = [
            "users" => $user->findAll(),
        ];
        $this->view->add("user/admin/index", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdminUpdateUser($message = "", $userId = null)

    {
        $title      = "Admin update user";
        // Get user id from GET variable
        $userId = isset($userId) ? $userId : $this->request->getGet("id");

        $user = $this->di->get("user")->getUserFromDatabase("id", $userId);
        $data = [
            "user" => $user,
            "message" => $message,
        ];
        $this->view->add("user/admin/update", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function postAdminUpdateUser()

    {
        // Get POST-variables
        $email = $this->request->getPost("email");
        $password = $this->request->getPost("password");
        $passwordagain = $this->request->getPost("passwordagain");
        $admin = $this->request->getPost("admin");
        $userId = $this->request->getPost("user_id");
        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->getAdminUpdateUser($message, $userId);
        }
        // Update user
        $update = (object) [
            "password" => $password,
            "email" => $email,
            "admin" => $admin,
        ];
        $this->di->get("user")->updateUserInDatabase($userId, $update);
        // Redirect back to admin page
        $this->response->redirect("user/admin");
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdminCreateUser($message = null)

    {
        $title      = "Admin create user page";
        $data = [
            "message" => $message,
        ];
        $this->view->add("user/admin/create", $data);
        $this->pageRender->renderPage(["title" => $title]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function postAdminCreateUser()

    {
        // Get POST-variables
        $acronym = $this->request->getPost("name");
        $email = $this->request->getPost("email");
        $admin = $this->request->getPost("admin");
        $password = $this->request->getPost("password");
        $passwordagain = $this->request->getPost("passwordagain");
        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->getAdminCreateUser($message);
            return;
        }
        // Create new user
        $newUser = (object) [
            "acronym" => $acronym,
            "password" => $password,
            "email" => $email,
            "admin" => $admin,
        ];
        $this->di->get("user")->createUser($newUser);
        // Redirect back to admin
        $this->response->redirect("user/admin");
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdminDeleteUser()
    {
        // Get user to delete from GET variable
        $userToDelete = $this->request->getGet("id");
        // Delete user
        $this->di->get("user")->deleteUser($userToDelete);
        // Redirect back to admin
        $this->response->redirect("user/admin");
    }
}


1			<?php
2
3			namespace Mafd16\User;
4
5			use \Anax\Configure\ConfigureInterface;
6			use \Anax\Configure\ConfigureTrait;
7			use \Anax\DI\InjectionAwareInterface;
8			use \Anax\Di\InjectionAwareTrait;
9			use \Anax\User\HTMLForm\UserLoginForm;
10			use \Anax\User\HTMLForm\CreateUserForm;
11
12			/**
13			* A controller class.
14			*/
15			class UserController implements
16			ConfigureInterface,
17			InjectionAwareInterface
18			{
19			use ConfigureTrait,
20			InjectionAwareTrait;
21
22
23
24			/**
25			* Protected variables
26			*/
27			protected $view;
28			protected $pageRender;
29			protected $request;
30			protected $response;
31			protected $session;
32
33
34			/**
35			* Set services to variables
36			*
37			*/
38			public function setUp()
39			{
40			$this->view = $this->di->get("view");

mafd16 / comment

Issues (37)

Security Analysis not enabled

src/User/UserController.php (23 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like