Issues in CommentController.php (master) - Issues in master - mafd16/comment - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Comment/CommentController.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Mafd16\Comment;

use \Anax\DI\InjectionAwareInterface;
use \Anax\DI\InjectionAwareTrait;

/**
 * A controller for the Comment System.
 *
 * @SuppressWarnings(PHPMD.ExitExpression)
 */
//class CommentController implements AppInjectableInterface
class CommentController implements InjectionAwareInterface
{
    use InjectionAwareTrait;


    /**
     * Get ALL comments from an article.
     *
     * @return void
     */
    public function getComments()

    {
        $key = "comPage";
        // Get comments from model
        $comments = $this->di->get("com")->getComments($key);
        // Add views to a specific region, add comments
        $this->di->get("view")->add("comment/index", ["comments"=>$comments], "main");
        // Render a standard page using layout
        $this->di->get("pageRender")->renderPage(["title" => "Kommentarssystem"]);
    }


    /**
     * Get ONE comment from an article.
     *
     * @param string $key for the article
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param int    $id for the comment id
     *
     * @return void
     */
    public function getComment($id)
    {
        $comment = $this->di->get("com")->getComment($id);
        return $comment;
    }


    /**
     * Get ONE comment for editing.
     *
     * @return void
     */
    public function getCommentToEdit()

    {
        $id = $this->di->get("request")->getGet("id");
        // Get the comment from Model.
        $comment = $this->di->get("com")->getComment($id);
        // Add views to a specific region
        $this->di->get("view")->add("comment/edit", ["comment"=>$comment], "main");
        // Render a standard page using layout
        $this->di->get("pageRender")->renderPage([
            "title" => "Redigera kommentar",
        ]);
    }


    /**
     * Edit a comment.
     *
     * @return void
     */
    public function editComment()
    {
        // Get post-variables
        $post = $this->di->get("request")->getPost();
        // Instruct Model to edit comment:
        // Edited comment:
        $comment = [
            "user_id" => $post["user_id"],
            "name" => $post["name"],
            "email" => $post["email"],
            "comment" => $post["comment"],
            "id" => $post["id"]
        ];
        $this->di->get("com")->updateComment($post["id"], $comment);
        // Send user back to comment page.
        $url = $this->di->get("url")->create("comment");
        $this->di->get("response")->redirect($url);
    }



    /**
     * Post a comment, with name and email.
     *
     * @return void
     */
    public function postComment()

    {
        // Catch post variables
        $post = $this->di->get("request")->getPost();
        // Instruct Model to add comment:
        $this->di->get("com")->addComment($post);
        // Send user back to comment page.
        $url = $this->di->get("url")->create("comment");
        $this->di->get("response")->redirect($url);
    }


    /**
     * Update old comment with new comment
     *
     * @param int       $id         id for comment
     * @param array     $comment    the comment-array (name, email, comment, id)
     *
     * @return void
     */
    public function updateComment($id, $comment)
    {
        $this->di->get("com")->updateComment($id, $comment);
    }


    /**
     * Delete comment with id
     *
     * @return void
     */
    public function deleteComment()

    {
        // Get id-variable from request.
        $id = $this->di->get("request")->getGet("id");
        // Instruct Model to delete comment:
        $this->di->get("com")->deleteComment($id);
        // Send user back to comment page.
        $url = $this->di->get("url")->create("comment");
        $this->di->get("response")->redirect($url);
    }
}


1			<?php
2
3			namespace Mafd16\Comment;
4
5			use \Anax\DI\InjectionAwareInterface;
6			use \Anax\DI\InjectionAwareTrait;
7
8			/**
9			* A controller for the Comment System.
10			*
11			* @SuppressWarnings(PHPMD.ExitExpression)
12			*/
13			//class CommentController implements AppInjectableInterface
14			class CommentController implements InjectionAwareInterface
15			{
16			use InjectionAwareTrait;
17
18
19			/**
20			* Get ALL comments from an article.
21			*
22			* @return void
23			*/
24		View Code Duplication	public function getComments()
			0 ignored issues – show Duplication introduced 2017-10-10 17:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26			$key = "comPage";
27			// Get comments from model
28			$comments = $this->di->get("com")->getComments($key);
29			// Add views to a specific region, add comments
30			$this->di->get("view")->add("comment/index", ["comments"=>$comments], "main");
31			// Render a standard page using layout
32			$this->di->get("pageRender")->renderPage(["title" => "Kommentarssystem"]);
33			}
34
35
36			/**
37			* Get ONE comment from an article.
38			*
39			* @param string $key for the article
			0 ignored issues – show Bug introduced 2017-10-10 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$key`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
40			* @param int $id for the comment id
41			*
42			* @return void
43			*/
44	2		public function getComment($id)
45			{
46	2		$comment = $this->di->get("com")->getComment($id);
47	2		return $comment;
48			}
49
50
51			/**
52			* Get ONE comment for editing.
53			*
54			* @return void
55			*/
56		View Code Duplication	public function getCommentToEdit()
			0 ignored issues – show Duplication introduced 2017-10-10 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57			{
58			$id = $this->di->get("request")->getGet("id");
59			// Get the comment from Model.
60			$comment = $this->di->get("com")->getComment($id);
61			// Add views to a specific region
62			$this->di->get("view")->add("comment/edit", ["comment"=>$comment], "main");
63			// Render a standard page using layout
64			$this->di->get("pageRender")->renderPage([
65			"title" => "Redigera kommentar",
66			]);
67			}
68
69
70			/**
71			* Edit a comment.
72			*
73			* @return void
74			*/
75			public function editComment()
76			{
77			// Get post-variables
78			$post = $this->di->get("request")->getPost();
79			// Instruct Model to edit comment:
80			// Edited comment:
81			$comment = [
82			"user_id" => $post["user_id"],
83			"name" => $post["name"],
84			"email" => $post["email"],
85			"comment" => $post["comment"],
86			"id" => $post["id"]
87			];
88			$this->di->get("com")->updateComment($post["id"], $comment);
89			// Send user back to comment page.
90			$url = $this->di->get("url")->create("comment");
91			$this->di->get("response")->redirect($url);
92			}
93
94
95
96			/**
97			* Post a comment, with name and email.
98			*
99			* @return void
100			*/
101		View Code Duplication	public function postComment()
			0 ignored issues – show Duplication introduced 2017-10-10 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102			{
103			// Catch post variables
104			$post = $this->di->get("request")->getPost();
105			// Instruct Model to add comment:
106			$this->di->get("com")->addComment($post);
107			// Send user back to comment page.
108			$url = $this->di->get("url")->create("comment");
109			$this->di->get("response")->redirect($url);
110			}
111
112
113			/**
114			* Update old comment with new comment
115			*
116			* @param int $id id for comment
117			* @param array $comment the comment-array (name, email, comment, id)
118			*
119			* @return void
120			*/
121	1		public function updateComment($id, $comment)
122			{
123	1		$this->di->get("com")->updateComment($id, $comment);
124	1		}
125
126
127			/**
128			* Delete comment with id
129			*
130			* @return void
131			*/
132		View Code Duplication	public function deleteComment()
			0 ignored issues – show Duplication introduced 2017-10-10 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
133			{
134			// Get id-variable from request.
135			$id = $this->di->get("request")->getGet("id");
136			// Instruct Model to delete comment:
137			$this->di->get("com")->deleteComment($id);
138			// Send user back to comment page.
139			$url = $this->di->get("url")->create("comment");
140			$this->di->get("response")->redirect($url);
141			}
142			}
143

mafd16 / comment

Issues (37)

Security Analysis not enabled

src/Comment/CommentController.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like