UserController::postCreatingUser() - Code Metrics - Inspection of "Rewrite usermodel" - mafd16/comment - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 592d4f...1560d7 )

by Martin

created 2017-10-11 16:22 UTC

UserController::postCreatingUser() A

↳ Parent: UserController

Complexity

Conditions	3
Paths	3

Size

Total Lines	51
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	51
ccs	0
cts	26
cp	0
rs	9.4109
cc	3
eloc	25
nc	3
nop	0
crap	12

How to fix Long Method

<?php

namespace Mafd16\User;

use \Anax\Configure\ConfigureInterface;
use \Anax\Configure\ConfigureTrait;
use \Anax\DI\InjectionAwareInterface;
use \Anax\Di\InjectionAwareTrait;
use \Anax\User\HTMLForm\UserLoginForm;
use \Anax\User\HTMLForm\CreateUserForm;

/**
 * A controller class.
 */
class UserController implements
    ConfigureInterface,
    InjectionAwareInterface
{
    use ConfigureTrait,
        InjectionAwareTrait;



    /**
     * @var $data description
     */
    //private $data;



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getIndex()
    {
        $title      = "A index page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        $data = [
            "content" => "An index page",
        ];

        $view->add("default2/article", $data);

        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getLogin()

    {
        $title      = "A login page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        $data = [
            "message" => "",
        ];

        $view->add("user/crud/login", $data);


        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getCreateUser($message = null)

    {
        $title      = "A create user page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");


        $data = [
            "message" => $message,
        ];

        $view->add("user/crud/create", $data);

        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function postCreatingUser()
    {
        $request    = $this->di->get("request");
        $session    = $this->di->get("session");

        // Get POST-variables
        $acronym = $request->getPost("name");
        $email = $request->getPost("email");
        $password = $request->getPost("password");
        $passwordagain = $request->getPost("passwordagain");

        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->getCreateUser($message);
            return;
        }
        /*
        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        // Update $user:
        $user->email = $email;
        $user->setPassword($password);
        $user->acronym = $acronym;
        $user->admin = 0;
        // Save to database
        $user->save();
        */
        $newUser = [
            "acronym" => $acronym,
            "password" => $password,
            "email" => $email,
        ];

        $isCreated = $this->di->get("user")->createUser($newUser);

        if (!$isCreated) {
            $message = "<p>User " . $acronym . " already exists!</p>";
            $this->getCreateUser($message);
            return;
        }


        // Save user to session
        $session->set("my_user_id", $user->id);

        $session->set("my_user_name", $user->acronym);
        $session->set("my_user_email", $user->email);
        $session->set("my_user_admin", $user->admin);
        // Redirect back to profile
        $this->di->get("response")->redirect("user/profile");
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getUserProfile()
    {
        $title      = "A profile page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $session    = $this->di->get("session");
        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $id = $session->get("my_user_id");
        $user->find("id", $id);

        $data = [
            "user" => $user,
        ];

        $view->add("user/crud/profile", $data);
        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function validateUser()
    {
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $request    = $this->di->get("request");
        $session    = $this->di->get("session");

        // Connect to database
        $user = new User();
        $user->setDb($this->di->get("db"));
        // Get POST-variables
        $acronym = $request->getPost("name");
        $password = $request->getPost("password");
        // Get the user from DB
        $user->find("acronym", $acronym);

        if ($user->deleted) {
            $title = "A login page";
            $data = [
                "message" => $user->acronym . " were deleted " . $user->deleted,
            ];
            $view->add("user/crud/login", $data);
            $pageRender->renderPage(["title" => $title]);
        }

        // Validate password against database
        $valid = $user->verifyPassword($acronym, $password);
        // if true, save user id to session and goto profile
        if ($valid) {
            // Save user id to session
            $session->set("my_user_id", $user->id);
            $session->set("my_user_name", $user->acronym);
            $session->set("my_user_email", $user->email);
            $session->set("my_user_admin", $user->admin);
            $this->di->get("response")->redirect("user/profile");
        } else {
            // if false goto login
            $title = "A login page";
            $data = [
                "acronym" => $acronym,
                "password" => $password,
                "valid" => $valid,
                "message" => "Name or password was incorrect!",
            ];
            $view->add("user/crud/login", $data);
            $pageRender->renderPage(["title" => $title]);
        }
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function updateGetUserProfile($message = null)

    {
        $title      = "Update user";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $id = $this->di->get("session")->get("my_user_id");
        $user->find("id", $id);
        $data = [
            "user" => $user,
            "message" => $message,
        ];

        $view->add("user/crud/update", $data);
        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function updatePostUserProfile()
    {
        $request    = $this->di->get("request");
        $session    = $this->di->get("session");

        // Get POST-variables
        $email = $request->getPost("email");
        $password = $request->getPost("password");
        $passwordagain = $request->getPost("passwordagain");

        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->updateGetUserProfile($message);
        }

        // Get user id from session
        $id = $session->get("my_user_id");
        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("id", $id);
        // Update $user:
        $user->email = $email;
        if (!empty($password)) {
            $user->setPassword($password);
        }
        // Save to database
        $user->save();
        // Save to session
        $session->set("my_user_id", $user->id);
        $session->set("my_user_name", $user->acronym);
        $session->set("my_user_email", $user->email);
        $session->set("my_user_admin", $user->admin);
        // Redirect back to profile
        $this->di->get("response")->redirect("user/profile");
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getLogout()
    {
        // Unset session-key user
        $this->di->get("session")->delete("my_user_id");
        $this->di->get("session")->delete("my_user_name");
        $this->di->get("session")->delete("my_user_email");
        $this->di->get("session")->delete("my_user_admin");
        // Redirect back to login
        $this->di->get("response")->redirect("user/login");
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdmin()
    {
        $title      = "An admin page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        // Get users from db
        $user = new User();
        $user->setDb($this->di->get("db"));

        $data = [
            "users" => $user->findAll(),
        ];

        $view->add("user/admin/index", $data);
        $pageRender->renderPage(["title" => $title]);
    }




    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdminUpdateUser($message = "", $userId = null)

    {
        $title      = "Admin update user";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        // Get user id from GET variable
        $userId = isset($userId) ? $userId : $this->di->get("request")->getGet("id");

        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("id", $userId);

        $data = [
            "user" => $user,
            "message" => $message,
        ];

        $view->add("user/admin/update", $data);
        $pageRender->renderPage(["title" => $title]);
    }




    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function postAdminUpdateUser()
    {
        $request    = $this->di->get("request");

        // Get POST-variables
        $email = $request->getPost("email");
        $password = $request->getPost("password");
        $passwordagain = $request->getPost("passwordagain");
        $admin = $request->getPost("admin");
        $userId = $request->getPost("user_id");

        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->getAdminUpdateUser($message, $userId);
        }

        // Get user id from session
        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("id", $userId);
        // Update $user:
        $user->email = $email;
        $user->admin = $admin;
        if (!empty($password)) {
            $user->setPassword($password);
        }
        // Save to database
        $user->save();

        // Redirect back to admin page
        $this->di->get("response")->redirect("user/admin");
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdminCreateUser($message = null)

    {
        $title      = "Admin create user page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        $data = [
            "message" => $message,
        ];

        $view->add("user/admin/create", $data);

        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function postAdminCreateUser()
    {
        $request    = $this->di->get("request");

        // Get POST-variables
        $acronym = $request->getPost("name");
        $email = $request->getPost("email");
        $admin = $request->getPost("admin");
        $password = $request->getPost("password");
        $passwordagain = $request->getPost("passwordagain");

        if ($password !== $passwordagain) {
            $message = "<p>Passwords did not match!</p>";
            $this->getAdminCreateUser($message);
            return;
        }

        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        // Update $user:
        $user->email = $email;
        $user->setPassword($password);
        $user->acronym = $acronym;
        $user->admin = $admin;
        // Save to database
        $user->save();
        // Redirect back to admin
        $this->di->get("response")->redirect("user/admin");
    }




    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getAdminDeleteUser()
    {
        // Get user to delete from GET variable
        $userToDelete = $this->di->get("request")->getGet("id");

        // Get user from db
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("id", $userToDelete);
        // Delete user (Set Deleted to timestamp)
        $user->deleted = date("Y-m-d H:i:s");
        $user->save();
        //$this->di->get("user")->deleteUser($id);

        // Redirect back to admin
        $this->di->get("response")->redirect("user/admin");
    }
}


1			<?php
2
3			namespace Mafd16\User;
4
5			use \Anax\Configure\ConfigureInterface;
6			use \Anax\Configure\ConfigureTrait;
7			use \Anax\DI\InjectionAwareInterface;
8			use \Anax\Di\InjectionAwareTrait;
9			use \Anax\User\HTMLForm\UserLoginForm;
10			use \Anax\User\HTMLForm\CreateUserForm;
11
12			/**
13			* A controller class.
14			*/
15			class UserController implements
16			ConfigureInterface,
17			InjectionAwareInterface
18			{
19			use ConfigureTrait,
20			InjectionAwareTrait;
21
22
23
24			/**
25			* @var $data description
26			*/
27			//private $data;
28
29
30
31			/**
32			* Description.
33			*
34			* @param datatype $variable Description
			0 ignored issues – show Bug introduced 2017-10-10 17:03 UTC by Report Bug Copy Issue Report There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
35			*
36			* @throws Exception
37			*
38			* @return void
39			*/

mafd16 / comment

Push — master ( 592d4f...1560d7 )

UserController::postCreatingUser() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like