Maestriam\Samurai\Tests\Unit\Entities\Theme\UseThemeTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testUseExistingTheme()	0	11	1
A	testUseInexistingTheme()	0	9	1
A	getEnvKey()	0	5	1
A	currentTheme()	0	7	1

<?php

namespace Maestriam\Samurai\Tests\Unit\Entities\Theme;

use Maestriam\Samurai\Entities\Theme;
use Maestriam\Samurai\Exceptions\ThemeNotFoundException;
use Maestriam\Samurai\Foundation\ConfigKeeper;
use Maestriam\Samurai\Foundation\EnvHandler;

class UseThemeTest extends ThemeTestCase
{
    public function testUseExistingTheme()
    {
        $name  = 'bands/accept';
        $theme = new Theme($name);

        $ret = $theme->make()->use();

        $current = $this->currentTheme();

        $this->assertValidTheme($ret);
        $this->assertEquals($current, $name);
    }

    public function testUseInexistingTheme()
    {
        $name = 'bands/accept';
        
        $theme = new Theme($name);

        $this->expectException(ThemeNotFoundException::class);

        $theme->use();
    }
    
    private function currentTheme() : string
    {
        $key = $this->getEnvKey();

        $env = new EnvHandler();

        return $env->get($key);

The expression return $env->get($key) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
        
    private function getEnvKey() : string
    {
        $config = new ConfigKeeper();
        
        return $config->env();
    }
}