Client::getStatus() - Code Metrics - Inspection of "Add test to check failed status return failed" - maen-bn/gitlab-ci-build-status - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7ff67...1bd8ce )

by Ben

created 2016-04-04 13:15 UTC

Client::getStatus() A

↳ Parent: Client

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2.004

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	19
ccs	9
cts	10
cp	0.9
rs	9.4285
cc	2
eloc	10
nc	2
nop	1
crap	2.004

<?php

namespace Maenbn\GitlabCiBuildStatus;

use Curl\Curl;

class Client
{

    protected $projectUrl;

    protected $projectId;

    protected $privateKey;

    protected $status;

    /**
     * @param $projectUrl
     * @param $projectId
     * @param $privateKey
     */
    public function __construct($projectUrl, $projectId, $privateKey)
    {
        $this->projectUrl = $projectUrl;
        $this->projectId = $projectId;
        $this->privateKey = $privateKey;
    }

    /**
     * @param string $branch
     *
     * @return mixed
     * @throws \Exception
     */
    public function getStatus($branch = 'master')
    {

        $sha = $this->getLatestCommitSha($branch);

        $curl = new Curl();
        $curl->get($this->projectUrl . '/projects/' . $this->projectId . '/' .
            'repository/commits/' . $sha . '/statuses?private_token='. $this->privateKey);

        if ($curl->error) {
            throw new \Exception('Error: ' . $curl->errorCode . ': ' . $curl->errorMessage);
        }

        $response = $curl->response;

        $this->setStatus($response);

        return $this->status;
    }

    /**
     * @param $response
     *
     * @return array|null
     */
    protected function setStatus($response)
    {
        $this->status = 'success';

        foreach($response as $buildStatus) {
            if($buildStatus->allow_failure === false && $buildStatus->status == 'failed') {
                $this->status = 'failed';
            }
        }
    }

    /**
     * @param $branch
     * @return mixed
     * @throws \Exception
     */
    protected function getLatestCommitSha($branch)
    {
        $curl = new Curl();
        $curl->get($this->projectUrl . '/projects/' . $this->projectId . '/' .
            'repository/commits?private_token='. $this->privateKey . '&ref_name=' . $branch);

        if ($curl->error) {
            throw new \Exception('Error: ' . $curl->errorCode . ': ' . $curl->errorMessage);
        }

        $response = $curl->response;

        return $response[0]->id;
    }

}


1		<?php
2
3		namespace Maenbn\GitlabCiBuildStatus;
4
5		use Curl\Curl;
6
7		class Client
8		{
9
10		protected $projectUrl;
11
12		protected $projectId;
13
14		protected $privateKey;
15
16		protected $status;
17
18		/**
19		* @param $projectUrl
20		* @param $projectId
21		* @param $privateKey
22		*/
23	3	public function __construct($projectUrl, $projectId, $privateKey)
24		{
25	3	$this->projectUrl = $projectUrl;
26	3	$this->projectId = $projectId;
27	3	$this->privateKey = $privateKey;
28	3	}
29
30		/**
31		* @param string $branch
32		*
33		* @return mixed
34		* @throws \Exception
35		*/
36	3	public function getStatus($branch = 'master')
37		{
38
39	3	$sha = $this->getLatestCommitSha($branch);
40
41	2	$curl = new Curl();
42	2	$curl->get($this->projectUrl . '/projects/' . $this->projectId . '/' .
43	2	'repository/commits/' . $sha . '/statuses?private_token='. $this->privateKey);
44
45	2	if ($curl->error) {
46		throw new \Exception('Error: ' . $curl->errorCode . ': ' . $curl->errorMessage);
47		}
48
49	2	$response = $curl->response;
50
51	2	$this->setStatus($response);
52
53	2	return $this->status;
54		}
55
56		/**
57		* @param $response
58		*
59		* @return array\|null
60		*/
61	2	protected function setStatus($response)
62		{
63	2	$this->status = 'success';
64
65	2	foreach($response as $buildStatus) {
66	2	if($buildStatus->allow_failure === false && $buildStatus->status == 'failed') {
67	1	$this->status = 'failed';
68	1	}
69	2	}
70	2	}
71
72		/**
73		* @param $branch
74		* @return mixed
75		* @throws \Exception
76		*/
77	3	protected function getLatestCommitSha($branch)
78		{
79	3	$curl = new Curl();
80	3	$curl->get($this->projectUrl . '/projects/' . $this->projectId . '/' .
81	3	'repository/commits?private_token='. $this->privateKey . '&ref_name=' . $branch);
82
83	3	if ($curl->error) {
84	1	throw new \Exception('Error: ' . $curl->errorCode . ': ' . $curl->errorMessage);
85		}
86
87	2	$response = $curl->response;
88
89	2	return $response[0]->id;
90		}
91
92		}
93

maen-bn / gitlab-ci-build-status

Push — master ( c7ff67...1bd8ce )

Client::getStatus() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like