FidoAaguidExtension::checkAaguidExtension() - Code Metrics - Inspection of "Type fix" - madwizard-org/webauthn-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (8d86ce)

by Thomas

created 2020-07-19 15:15 UTC

FidoAaguidExtension::checkAaguidExtension() A

↳ Parent: FidoAaguidExtension

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	3
eloc	5
c	1
b	1
f	0
nc	3
nop	2
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	3
rs	10

<?php

namespace MadWizard\WebAuthn\Attestation\Fido;

use Exception;
use MadWizard\WebAuthn\Attestation\Identifier\Aaguid;
use MadWizard\WebAuthn\Exception\ParseException;
use MadWizard\WebAuthn\Exception\VerificationException;
use MadWizard\WebAuthn\Format\ByteBuffer;
use MadWizard\WebAuthn\Pki\CertificateDetailsInterface;
use Sop\ASN1\Type\UnspecifiedType;

final class FidoAaguidExtension
{
    private const OID_FIDO_GEN_CE_AAGUID = '1.3.6.1.4.1.45724.1.1.4';

    public static function checkAaguidExtension(CertificateDetailsInterface $cert, Aaguid $validAaguid): void
    {
        $aaguid = self::getFidoAaguidExtensionValue($cert);

        if ($aaguid === null) {
            return;
        }

        if (!$validAaguid->equals($aaguid)) {
            throw new VerificationException('AAGUID in certificate extension does not match the AAGUID in the authenticator data.');
        }
    }

    private static function getFidoAaguidExtensionValue(CertificateDetailsInterface $cert): ?Aaguid
    {
        $extension = $cert->getExtensionData(self::OID_FIDO_GEN_CE_AAGUID);
        if ($extension === null) {
            return null;
        }

        if ($extension->isCritical()) {
            throw new VerificationException('FIDO AAGUID extension must not be critical.');
        }

        try {
            $rawAaguid = UnspecifiedType::fromDER($extension->getValue()->getBinaryString())->asOctetString()->string();
            return new Aaguid(new ByteBuffer($rawAaguid));
        } catch (Exception $e) {
            throw new ParseException('Failed to parse AAGUID extension', 0, $e);
        }
    }
}


1		<?php
2
3		namespace MadWizard\WebAuthn\Attestation\Fido;
4
5		use Exception;
6		use MadWizard\WebAuthn\Attestation\Identifier\Aaguid;
7		use MadWizard\WebAuthn\Exception\ParseException;
8		use MadWizard\WebAuthn\Exception\VerificationException;
9		use MadWizard\WebAuthn\Format\ByteBuffer;
10		use MadWizard\WebAuthn\Pki\CertificateDetailsInterface;
11		use Sop\ASN1\Type\UnspecifiedType;
12
13		final class FidoAaguidExtension
14		{
15		private const OID_FIDO_GEN_CE_AAGUID = '1.3.6.1.4.1.45724.1.1.4';
16
17	7	public static function checkAaguidExtension(CertificateDetailsInterface $cert, Aaguid $validAaguid): void
18		{
19	7	$aaguid = self::getFidoAaguidExtensionValue($cert);
20
21	5	if ($aaguid === null) {
22	2	return;
23		}
24
25	3	if (!$validAaguid->equals($aaguid)) {
26	1	throw new VerificationException('AAGUID in certificate extension does not match the AAGUID in the authenticator data.');
27		}
28	2	}
29
30	7	private static function getFidoAaguidExtensionValue(CertificateDetailsInterface $cert): ?Aaguid
31		{
32	7	$extension = $cert->getExtensionData(self::OID_FIDO_GEN_CE_AAGUID);
33	7	if ($extension === null) {
34	2	return null;
35		}
36
37	5	if ($extension->isCritical()) {
38	1	throw new VerificationException('FIDO AAGUID extension must not be critical.');
39		}
40
41		try {
42	4	$rawAaguid = UnspecifiedType::fromDER($extension->getValue()->getBinaryString())->asOctetString()->string();
43	3	return new Aaguid(new ByteBuffer($rawAaguid));
44	1	} catch (Exception $e) {
45	1	throw new ParseException('Failed to parse AAGUID extension', 0, $e);
46		}
47		}
48		}
49

madwizard-org / webauthn-server

Branch — master (8d86ce)

FidoAaguidExtension::checkAaguidExtension() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like