CacheItemPool::save() - Code Metrics - Inspection of "Improve code quality and add a test for untested c..." - madewithlove/illuminate-psr-cache-bridge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7ecb2...08728b )

by Hannes

created 2016-07-03 20:27 UTC

CacheItemPool::save() B

↳ Parent: CacheItemPool

Complexity

Conditions	5
Paths	5

Size

Total Lines	33
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	5.0406

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
c	4
b	1
f	1
dl	0
loc	33
ccs	15
cts	17
cp	0.8824
rs	8.439
cc	5
eloc	19
nc	5
nop	1
crap	5.0406

<?php
namespace Madewithlove\IlluminatePsrCacheBridge\Laravel;

use DateTimeImmutable;
use Exception;
use Illuminate\Contracts\Cache\Repository;
use Madewithlove\IlluminatePsrCacheBridge\Exceptions\InvalidArgumentException;
use Psr\Cache\CacheItemInterface;
use Psr\Cache\CacheItemPoolInterface;

class CacheItemPool implements CacheItemPoolInterface
{
    /**
     * @var \Illuminate\Contracts\Cache\Repository
     */
    private $repository;

    /**
     * @var \Psr\Cache\CacheItemInterface[]
     */
    private $deferred = [];

    /**
     * @param \Illuminate\Contracts\Cache\Repository $repository
     */
    public function __construct(Repository $repository)
    {
        $this->repository = $repository;
    }

    /**
     * Destructor.
     */
    public function __destruct()
    {
        $this->commit();
    }

    /**
     * {@inheritdoc}
     */
    public function getItem($key)
    {
        $this->validateKey($key);

        if (isset($this->deferred[$key])) {
            return clone($this->deferred[$key]);
        } elseif ($this->repository->has($key)) {
            return new CacheItem($key, unserialize($this->repository->get($key)), true);
        } else {
            return new CacheItem($key);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getItems(array $keys = array())
    {
        return array_combine($keys, array_map(function ($key) {
            return $this->getItem($key);
        }, $keys));
    }

    /**
     * {@inheritdoc}
     */
    public function hasItem($key)
    {
        $this->validateKey($key);

        if (isset($this->deferred[$key])) {
            $item = $this->deferred[$key];
            $expiresAt = $this->getExpiresAt($item);


            if (! $expiresAt) {
                return true;
            }

            return $expiresAt > new DateTimeImmutable();
        }

        return $this->repository->has($key);
    }

    /**
     * {@inheritdoc}
     */
    public function clear()
    {
        try {
            $this->deferred = [];
            $store = $this->repository;
            /* @var \Illuminate\Contracts\Cache\Store $store */
            $store->flush();
        } catch (Exception $exception) {
            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function deleteItem($key)
    {
        $this->validateKey($key);

        unset($this->deferred[$key]);

        if (! $this->hasItem($key)) {
            return true;
        }

        return $this->repository->forget($key);
    }

    /**
     * {@inheritdoc}
     */
    public function deleteItems(array $keys)
    {
        // Validating all keys first.
        foreach ($keys as $key) {
            $this->validateKey($key);
        }

        $success = true;

        foreach ($keys as $key) {
            $success = $success && $this->deleteItem($key);
        }

        return $success;
    }

    /**
     * {@inheritdoc}
     */
    public function save(CacheItemInterface $item)
    {
        $expiresAt = $this->getExpiresAt($item);


        if (! $expiresAt) {
            try {
                $this->repository->forever($item->getKey(), serialize($item->get()));
            } catch (Exception $exception) {
                return false;
            }

            return true;
        }

        $now = new DateTimeImmutable('now', $expiresAt->getTimezone());

        $seconds = $expiresAt->getTimestamp() - $now->getTimestamp();
        $minutes = (int) floor($seconds / 60.0);

        if ($minutes <= 0) {
            $this->repository->forget($item->getKey());

            return false;
        }

        try {
            $this->repository->put($item->getKey(), serialize($item->get()), $minutes);
        } catch (Exception $exception) {
            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function saveDeferred(CacheItemInterface $item)
    {
        $expiresAt = $this->getExpiresAt($item);


        if ($expiresAt && ($expiresAt < new DateTimeImmutable())) {
            return false;
        }

        $item = (new CacheItem($item->getKey(), $item->get(), true))->expiresAt($expiresAt);

        $this->deferred[$item->getKey()] = $item;

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function commit()
    {
        $success = true;

        foreach ($this->deferred as $key => $item) {
            $success = $success && $this->save($item);
        }

        $this->deferred = [];

        return $success;
    }

    /**
     * @param string $key
     *
     * @throws \Psr\Cache\InvalidArgumentException
     */
    private function validateKey($key)
    {
        if (!is_string($key) || preg_match('#[{}\(\)/\\\\@:]#', $key)) {
            throw new InvalidArgumentException();
        }
    }

    /**
     * @param \Madewithlove\IlluminatePsrCacheBridge\Laravel\CacheItem $item
     *
     * @return \DateTimeInterface
     */
    private function getExpiresAt(CacheItem $item)
    {
        return $item->getExpiresAt();
    }
}


1		<?php
2		namespace Madewithlove\IlluminatePsrCacheBridge\Laravel;
3
4		use DateTimeImmutable;
5		use Exception;
6		use Illuminate\Contracts\Cache\Repository;
7		use Madewithlove\IlluminatePsrCacheBridge\Exceptions\InvalidArgumentException;
8		use Psr\Cache\CacheItemInterface;
9		use Psr\Cache\CacheItemPoolInterface;
10
11		class CacheItemPool implements CacheItemPoolInterface
12		{
13		/**
14		* @var \Illuminate\Contracts\Cache\Repository
15		*/
16		private $repository;
17
18		/**
19		* @var \Psr\Cache\CacheItemInterface[]
20		*/
21		private $deferred = [];
22
23		/**
24		* @param \Illuminate\Contracts\Cache\Repository $repository
25		*/
26	141	public function __construct(Repository $repository)
27		{
28	141	$this->repository = $repository;
29	141	}
30
31		/**
32		* Destructor.
33		*/
34	23	public function __destruct()
35		{
36	23	$this->commit();
37	23	}
38
39		/**
40		* {@inheritdoc}
41		*/
42	76	public function getItem($key)
43		{
44	76	$this->validateKey($key);
45
46	59	if (isset($this->deferred[$key])) {
47	5	return clone($this->deferred[$key]);
48	59	} elseif ($this->repository->has($key)) {
49	26	return new CacheItem($key, unserialize($this->repository->get($key)), true);
50		} else {
51	57	return new CacheItem($key);
52		}
53		}
54
55		/**
56		* {@inheritdoc}
57		*/
58		public function getItems(array $keys = array())
59		{
60	22	return array_combine($keys, array_map(function ($key) {
61	20	return $this->getItem($key);
62	22	}, $keys));
63		}
64
65		/**
66		* {@inheritdoc}
67		*/
68	34	public function hasItem($key)
69		{
70	34	$this->validateKey($key);
71
72	16	if (isset($this->deferred[$key])) {
73	2	$item = $this->deferred[$key];
74	2	$expiresAt = $this->getExpiresAt($item);
		0 ignored issues – show Compatibility introduced 2016-07-03 20:29 UTC by Report Bug Copy Issue Report `$item` of type `object<Psr\Cache\CacheItemInterface>` is not a sub-type of `object<Madewithlove\Illu...idge\Laravel\CacheItem>`. It seems like you assume a concrete implementation of the interface `Psr\Cache\CacheItemInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
75
76	2	if (! $expiresAt) {
77	1	return true;
78		}
79
80	1	return $expiresAt > new DateTimeImmutable();
81		}
82
83	14	return $this->repository->has($key);
84		}
85
86		/**
87		* {@inheritdoc}
88		*/
89	121	public function clear()
90		{
91		try {
92	121	$this->deferred = [];
93	121	$store = $this->repository;
94		/* @var \Illuminate\Contracts\Cache\Store $store */
95	121	$store->flush();
96	1	} catch (Exception $exception) {
97	1	return false;
98		}
99
100	120	return true;
101		}
102
103		/**
104		* {@inheritdoc}
105		*/
106	26	public function deleteItem($key)
107		{
108	26	$this->validateKey($key);
109
110	8	unset($this->deferred[$key]);
111
112	8	if (! $this->hasItem($key)) {
113	5	return true;
114		}
115
116	5	return $this->repository->forget($key);
117		}
118
119		/**
120		* {@inheritdoc}
121		*/
122	22	public function deleteItems(array $keys)
123		{
124		// Validating all keys first.
125	22	foreach ($keys as $key) {
126	21	$this->validateKey($key);
127		}
128
129	4	$success = true;
130
131	4	foreach ($keys as $key) {
132	3	$success = $success && $this->deleteItem($key);
133		}
134
135	4	return $success;
136		}
137
138		/**
139		* {@inheritdoc}
140		*/
141	35	public function save(CacheItemInterface $item)
142		{
143	35	$expiresAt = $this->getExpiresAt($item);
		0 ignored issues – show Compatibility introduced 2016-07-03 20:29 UTC by Report Bug Copy Issue Report `$item` of type `object<Psr\Cache\CacheItemInterface>` is not a sub-type of `object<Madewithlove\Illu...idge\Laravel\CacheItem>`. It seems like you assume a concrete implementation of the interface `Psr\Cache\CacheItemInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
144
145	35	if (! $expiresAt) {
146		try {
147	30	$this->repository->forever($item->getKey(), serialize($item->get()));
148	1	} catch (Exception $exception) {
149	1	return false;
150		}
151
152	29	return true;
153		}
154
155	5	$now = new DateTimeImmutable('now', $expiresAt->getTimezone());
156
157	5	$seconds = $expiresAt->getTimestamp() - $now->getTimestamp();
158	5	$minutes = (int) floor($seconds / 60.0);
159
160	5	if ($minutes <= 0) {
161	3	$this->repository->forget($item->getKey());
162
163	3	return false;
164		}
165
166		try {
167	2	$this->repository->put($item->getKey(), serialize($item->get()), $minutes);
168		} catch (Exception $exception) {
169		return false;
170		}
171
172	2	return true;
173		}
174
175		/**
176		* {@inheritdoc}
177		*/
178	12	public function saveDeferred(CacheItemInterface $item)
179		{
180	12	$expiresAt = $this->getExpiresAt($item);
		0 ignored issues – show Compatibility introduced 2016-07-03 20:29 UTC by Report Bug Copy Issue Report `$item` of type `object<Psr\Cache\CacheItemInterface>` is not a sub-type of `object<Madewithlove\Illu...idge\Laravel\CacheItem>`. It seems like you assume a concrete implementation of the interface `Psr\Cache\CacheItemInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
181
182	12	if ($expiresAt && ($expiresAt < new DateTimeImmutable())) {
183	1	return false;
184		}
185
186	11	$item = (new CacheItem($item->getKey(), $item->get(), true))->expiresAt($expiresAt);
187
188	11	$this->deferred[$item->getKey()] = $item;
189
190	11	return true;
191		}
192
193		/**
194		* {@inheritdoc}
195		*/
196	31	public function commit()
197		{
198	31	$success = true;
199
200	31	foreach ($this->deferred as $key => $item) {
201	9	$success = $success && $this->save($item);
202		}
203
204	31	$this->deferred = [];
205
206	31	return $success;
207		}
208
209		/**
210		* @param string $key
211		*
212		* @throws \Psr\Cache\InvalidArgumentException
213		*/
214	135	private function validateKey($key)
215		{
216	135	if (!is_string($key) \|\| preg_match('#[{}\(\)/\\\\@:]#', $key)) {
217	88	throw new InvalidArgumentException();
218		}
219	82	}
220
221		/**
222		* @param \Madewithlove\IlluminatePsrCacheBridge\Laravel\CacheItem $item
223		*
224		* @return \DateTimeInterface
225		*/
226	38	private function getExpiresAt(CacheItem $item)
227		{
228	38	return $item->getExpiresAt();
229		}
230		}
231

madewithlove / illuminate-psr-cache-bridge

Push — master ( b7ecb2...08728b )

CacheItemPool::save() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like