Meta::addLanguage() - Code Metrics - Inspection of "Merge branch 'develop'" - mad-web/laravel-seoable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f5f7c...7faed5 )

by Basenko

created 2017-08-17 16:26 UTC

Meta::addLanguage() A

↳ Parent: Meta

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	7
nc	1
nop	2

<?php

namespace MadWeb\Seoable\Protocols;

use MadWeb\Seoable\Fields\Meta\Next;
use MadWeb\Seoable\Fields\Meta\Prev;
use MadWeb\Seoable\Fields\Meta\Title;
use MadWeb\Seoable\Fields\Meta\MetaTag;
use MadWeb\Seoable\Fields\Meta\Keywords;
use MadWeb\Seoable\Fields\Meta\Canonical;
use MadWeb\Seoable\Fields\Meta\Languages;
use MadWeb\Seoable\Fields\Meta\Description;
use MadWeb\Seoable\Fields\Meta\TitleSeparator;

/**
 * @method Meta setMetaRaw(array $value)
 * @method Meta addMetaRaw(string $meta, string $value, string $name = 'name')
 * @method Meta setTitleRaw(string $value)
 * @method Meta setTitleSeparatorRaw(string $value)
 * @method Meta setDescriptionRaw(string $value)
 * @method Meta setCanonicalRaw(string $value)
 * @method Meta setPrevRaw(string $value)
 * @method Meta setNextRaw(string $value)
 * @method Meta setKeywordsRaw(array|string $value)
 * @method Meta setLanguagesRaw(array $value)
 * @method Meta addLanguageRaw(string $lang, string $url)
 */
class Meta extends Protocol
{
    public function setMeta(array $tags): self
    {
        foreach ($this->parseValue($tags, MetaTag::class) as $item) {
            $this->metaService->addMeta(...array_values($item));
        }

        return $this;
    }

    public function addMeta(string $meta, string $value, string $name = 'name'): self
    {
        $this->metaService->addMeta(...array_values(
            $this->parseValue(
                [compact('meta', 'value', 'name')],
                MetaTag::class
            )[0]
        ));

        return $this;
    }

    /** @param array|string $value */
    public function setTitle($value, string $templateKey = ''): self
    {
        $this->seoTools->setTitle($this->parseValue(
            $value,
            $templateKey ? new Title($value, $this->model, $templateKey) : Title::class
        ));

        return $this;
    }

    /** @param string $value */
    public function setTitleSeparator(string $value): self
    {
        $this->metaService->setTitleSeparator($this->parseValue($value, TitleSeparator::class));

        return $this;
    }

    /** @param array|string $value */
    public function setDescription($value, string $templateKey = ''): self
    {
        $this->seoTools->setDescription($this->parseValue(
            $value,
            $templateKey ? new Description($value, $this->model, $templateKey) : Description::class
        ));

        return $this;
    }

    public function setCanonical(string $value): self
    {
        $this->seoTools->setCanonical($this->parseValue($value, Canonical::class));

        return $this;
    }

    public function setPrev(string $value): self
    {
        $this->metaService->setPrev($this->parseValue($value, Prev::class));

        return $this;
    }

    public function setNext(string $value): self
    {
        $this->metaService->setNext($this->parseValue($value, Next::class));

        return $this;
    }

    /** @param array|string $value */
    public function setKeywords($value): self
    {
        $this->metaService->setKeywords($this->parseValue($value, Keywords::class));

        return $this;
    }

    public function setLanguages(array $value): self
    {
        $this->metaService->addAlternateLanguages($this->parseValue($value, Languages::class));

        return $this;
    }

    public function addLanguage(string $lang, string $url): self
    {
        $this->metaService->addAlternateLanguage(...array_values(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->parseValue(
                [compact('lang', 'url')],
                Languages::class
            )[0]
        ));

        return $this;
    }

    protected function getRawFields(): array
    {
        return $this->modelSeoData;
    }
}


1			<?php
2
3			namespace MadWeb\Seoable\Protocols;
4
5			use MadWeb\Seoable\Fields\Meta\Next;
6			use MadWeb\Seoable\Fields\Meta\Prev;
7			use MadWeb\Seoable\Fields\Meta\Title;
8			use MadWeb\Seoable\Fields\Meta\MetaTag;
9			use MadWeb\Seoable\Fields\Meta\Keywords;
10			use MadWeb\Seoable\Fields\Meta\Canonical;
11			use MadWeb\Seoable\Fields\Meta\Languages;
12			use MadWeb\Seoable\Fields\Meta\Description;
13			use MadWeb\Seoable\Fields\Meta\TitleSeparator;
14
15			/**
16			* @method Meta setMetaRaw(array $value)
17			* @method Meta addMetaRaw(string $meta, string $value, string $name = 'name')
18			* @method Meta setTitleRaw(string $value)
19			* @method Meta setTitleSeparatorRaw(string $value)
20			* @method Meta setDescriptionRaw(string $value)
21			* @method Meta setCanonicalRaw(string $value)
22			* @method Meta setPrevRaw(string $value)
23			* @method Meta setNextRaw(string $value)
24			* @method Meta setKeywordsRaw(array\|string $value)
25			* @method Meta setLanguagesRaw(array $value)
26			* @method Meta addLanguageRaw(string $lang, string $url)
27			*/
28			class Meta extends Protocol
29			{
30			public function setMeta(array $tags): self
31			{
32			foreach ($this->parseValue($tags, MetaTag::class) as $item) {
33			$this->metaService->addMeta(...array_values($item));
34			}
35
36			return $this;
37			}
38
39			public function addMeta(string $meta, string $value, string $name = 'name'): self
40			{
41			$this->metaService->addMeta(...array_values(
42			$this->parseValue(
43			[compact('meta', 'value', 'name')],
44			MetaTag::class
45			)[0]
46			));
47
48			return $this;
49			}
50
51			/** @param array\|string $value */
52			public function setTitle($value, string $templateKey = ''): self
53			{
54			$this->seoTools->setTitle($this->parseValue(
55			$value,
56			$templateKey ? new Title($value, $this->model, $templateKey) : Title::class
57			));
58
59			return $this;
60			}
61
62			/** @param string $value */
63			public function setTitleSeparator(string $value): self
64			{
65			$this->metaService->setTitleSeparator($this->parseValue($value, TitleSeparator::class));
66
67			return $this;
68			}
69
70			/** @param array\|string $value */
71			public function setDescription($value, string $templateKey = ''): self
72			{
73			$this->seoTools->setDescription($this->parseValue(
74			$value,
75			$templateKey ? new Description($value, $this->model, $templateKey) : Description::class
76			));
77
78			return $this;
79			}
80
81			public function setCanonical(string $value): self
82			{
83			$this->seoTools->setCanonical($this->parseValue($value, Canonical::class));
84
85			return $this;
86			}
87
88			public function setPrev(string $value): self
89			{
90			$this->metaService->setPrev($this->parseValue($value, Prev::class));
91
92			return $this;
93			}
94
95			public function setNext(string $value): self
96			{
97			$this->metaService->setNext($this->parseValue($value, Next::class));
98
99			return $this;
100			}
101
102			/** @param array\|string $value */
103			public function setKeywords($value): self
104			{
105			$this->metaService->setKeywords($this->parseValue($value, Keywords::class));
106
107			return $this;
108			}
109
110			public function setLanguages(array $value): self
111			{
112			$this->metaService->addAlternateLanguages($this->parseValue($value, Languages::class));
113
114			return $this;
115			}
116
117			public function addLanguage(string $lang, string $url): self
118			{
119			$this->metaService->addAlternateLanguage(...array_values(
			0 ignored issues – show Bug introduced 2017-08-17 14:20 UTC by Report Bug Copy Issue Report The call to `addAlternateLanguage()` misses a required argument `$url`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2017-08-17 16:30 UTC by Report Bug Copy Issue Report `array_values($this->pars...a\Languages::class)[0])` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
120			$this->parseValue(
121			[compact('lang', 'url')],
122			Languages::class
123			)[0]
124			));
125
126			return $this;
127			}
128
129			protected function getRawFields(): array
130			{
131			return $this->modelSeoData;
132			}
133			}
134

mad-web / laravel-seoable

Push — master ( 8f5f7c...7faed5 )

Meta::addLanguage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like