Dispatch::run() - Code Metrics - Inspection of "Added custom options." - mad-web/laravel-initializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

unknown

created 2020-01-23 12:44 UTC

Dispatch::run() A

↳ Parent: Dispatch

Complexity

Conditions	4
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	0
cts	15
cp	0
rs	9.6333
c	0
b	0
f	0
cc	4
nc	8
nop	0
crap	20

<?php

namespace MadWeb\Initializer\Actions;

use Illuminate\Console\Command;
use Illuminate\Container\Container;
use Illuminate\Contracts\Bus\Dispatcher;

class Dispatch extends Action
{
    protected const LOADING_TEXT = 'dispatching...';

    private $job;

    private $runNow;

    public function __construct(Command $artisanCommand, $job, bool $runNow = false)
    {
        parent::__construct($artisanCommand);

        $this->job = $job;
        $this->runNow = $runNow;
    }

    public function title(): string
    {
        return '<comment>Dispatch job:</comment> '.get_class($this->job);
    }

    public function run(): bool
    {
        $result = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($this->runNow) {
            $result = Container::getInstance()->make(Dispatcher::class)->dispatchNow($this->job);
        } else {
            $result = Container::getInstance()->make(Dispatcher::class)->dispatch($this->job);
        }

        $artisanCommand = $this->getArtisanCommnad();

        if ($artisanCommand->getOutput()->isVerbose()) {
            $artisanCommand->getOutput()->newLine();
            $artisanCommand->info($result);
        }

        return ! (is_int($result) and $result > 0);
    }
}


1			<?php
2
3			namespace MadWeb\Initializer\Actions;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Container\Container;
7			use Illuminate\Contracts\Bus\Dispatcher;
8
9			class Dispatch extends Action
10			{
11			protected const LOADING_TEXT = 'dispatching...';
12
13			private $job;
14
15			private $runNow;
16
17			public function __construct(Command $artisanCommand, $job, bool $runNow = false)
18			{
19			parent::__construct($artisanCommand);
20
21			$this->job = $job;
22			$this->runNow = $runNow;
23			}
24
25			public function title(): string
26			{
27			return '<comment>Dispatch job:</comment> '.get_class($this->job);
28			}
29
30			public function run(): bool
31			{
32			$result = null;
			0 ignored issues – show Unused Code introduced 2019-10-02 16:22 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
33
34			if ($this->runNow) {
35			$result = Container::getInstance()->make(Dispatcher::class)->dispatchNow($this->job);
36			} else {
37			$result = Container::getInstance()->make(Dispatcher::class)->dispatch($this->job);
38			}
39
40			$artisanCommand = $this->getArtisanCommnad();
41
42			if ($artisanCommand->getOutput()->isVerbose()) {
43			$artisanCommand->getOutput()->newLine();
44			$artisanCommand->info($result);
45			}
46
47			return ! (is_int($result) and $result > 0);
48			}
49			}
50

mad-web / laravel-initializer

Pull Request — master (#11)

Dispatch::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like