Publish::__construct() - Code Metrics - Inspection of "Removed unnecessary execturion layer" - mad-web/laravel-initializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b5da6...9a1463 )

by Basenko

created 2019-09-17 12:32 UTC

Publish::__construct() A

↳ Parent: Publish

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php

namespace MadWeb\Initializer\ExecutorActions;

use InvalidArgumentException;
use Illuminate\Console\Command;

class Publish
{
    private const COMMAND = 'vendor:publish';

    private $artisanCommand;

    /** @var string|array */
    private $providers;

    /** @var bool */
    private $force;

    /** @var array */
    private $arguments = [];

    public function __construct(Command $artisanCommand, $providers, bool $force = false)
    {
        $this->artisanCommand = $artisanCommand;
        $this->providers = $providers;
        $this->force = $force;
    }

    public function __invoke()
    {
        if (is_string($this->providers)) {
            $this->addProvider($this->providers);
        } elseif (is_array($this->providers)) {
            $this->handleArray();
        } else {
            throw new InvalidArgumentException('Invalid publishable argument.');
        }

        foreach ($this->arguments as $argument) {
            new Artisan($this->artisanCommand, self::COMMAND, $argument);
            value(new Artisan($this->artisanCommand, self::COMMAND, $argument))();
        }
    }

    private function addProvider(string $provider, $tag = null)
    {
        $arguments['--provider'] = $provider;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        if ($tag !== null) {
            $arguments['--tag'] = $tag;
        }

        if ($this->force) {
            $arguments['--force'] = true;
        }

        $this->arguments[] = $arguments;
    }

    private function handleArray(): void
    {
        foreach ($this->providers as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (is_numeric($key)) {
                $this->addProvider($value);
            } else {
                $this->addProvider($key, $value);
            }
        }
    }
}


1		<?php
2
3		namespace MadWeb\Initializer\ExecutorActions;
4
5		use InvalidArgumentException;
6		use Illuminate\Console\Command;
7
8		class Publish
9		{
10		private const COMMAND = 'vendor:publish';
11
12		private $artisanCommand;
13
14		/** @var string\|array */
15		private $providers;
16
17		/** @var bool */
18		private $force;
19
20		/** @var array */
21		private $arguments = [];
22
23	66	public function __construct(Command $artisanCommand, $providers, bool $force = false)
24		{
25	66	$this->artisanCommand = $artisanCommand;
26	66	$this->providers = $providers;
27	66	$this->force = $force;
28	66	}
29
30	66	public function __invoke()
31		{
32	66	if (is_string($this->providers)) {
33	12	$this->addProvider($this->providers);
34	54	} elseif (is_array($this->providers)) {
35	48	$this->handleArray();
36		} else {
37	6	throw new InvalidArgumentException('Invalid publishable argument.');
38		}
39
40	60	foreach ($this->arguments as $argument) {
41	60	new Artisan($this->artisanCommand, self::COMMAND, $argument);
42	60	value(new Artisan($this->artisanCommand, self::COMMAND, $argument))();
43		}
44	60	}
45
46	60	private function addProvider(string $provider, $tag = null)
47		{
48	60	$arguments['--provider'] = $provider;
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-03 20:40 UTC by Report Bug Copy Issue Report `$arguments` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$arguments = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
49
50	60	if ($tag !== null) {
51	30	$arguments['--tag'] = $tag;
52		}
53
54	60	if ($this->force) {
55	12	$arguments['--force'] = true;
56		}
57
58	60	$this->arguments[] = $arguments;
59	60	}
60
61	48	private function handleArray(): void
62		{
63	48	foreach ($this->providers as $key => $value) {
		0 ignored issues – show Bug introduced 2019-09-17 12:36 UTC by Report Bug Copy Issue Report The expression `$this->providers` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
64	48	if (is_numeric($key)) {
65	18	$this->addProvider($value);
66		} else {
67	30	$this->addProvider($key, $value);
68		}
69		}
70	48	}
71		}
72

mad-web / laravel-initializer

Push — master ( 6b5da6...9a1463 )

Publish::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like