Artisan::__invoke() - Code Metrics - Inspection of "Removed unnecessary execturion layer" - mad-web/laravel-initializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b5da6...9a1463 )

by Basenko

created 2019-09-17 12:32 UTC

Artisan::__invoke() A

↳ Parent: Artisan

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.1481

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	4
cts	6
cp	0.6667
rs	9.8666
c	0
b	0
f	0
cc	2
nc	1
nop	0
crap	2.1481

<?php

namespace MadWeb\Initializer\ExecutorActions;

use Illuminate\Console\Command;

class Artisan
{
    private $artisanCommand;

    private $command;

    private $arguments;

    public function __construct(Command $artisanCommand, string $command, array $arguments = [])
    {
        $this->artisanCommand = $artisanCommand;
        $this->command = $command;
        $this->arguments = $arguments;
    }

    private function title()
    {
        $title = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($this->command === 'vendor:publish') {
            $title = '<comment>Publishing resource:</comment> ';

            if (isset($this->arguments['--provider'])) {
                $title .= "Provider [<fg=cyan>{$this->arguments['--provider']}</>]";
            }

            $tagStringCallback = function (string $tag) {
                return " Tag[<fg=cyan>$tag</>]";
            };

            if (isset($this->arguments['--tag'])) {
                if (is_string($this->arguments['--tag'])) {
                    $title .= $tagStringCallback($this->arguments['--tag']);
                } else {
                    foreach ($this->arguments['--tag'] as $tag) {
                        $title .= $tagStringCallback($tag);
                    }
                }
            }
        } else {
            $title = "<comment>Running artisan command:</comment> $this->command (".
                $this->artisanCommand
                    ->getApplication()
                    ->find($this->command)
                    ->getDescription().
                ')';
        }

        return $title;
    }

    public function __invoke(): bool
    {
        return $this->artisanCommand->task($this->title(), function () {
            if ($this->artisanCommand->getOutput()->isVerbose()) {
                $this->artisanCommand->getOutput()->newLine();

                return ! $this->artisanCommand->call($this->command, $this->arguments);
            }

            return ! $this->artisanCommand->callSilent($this->command, $this->arguments);
        });
    }
}


1		<?php
2
3		namespace MadWeb\Initializer\ExecutorActions;
4
5		use Illuminate\Console\Command;
6
7		class Artisan
8		{
9		private $artisanCommand;
10
11		private $command;
12
13		private $arguments;
14
15	66	public function __construct(Command $artisanCommand, string $command, array $arguments = [])
16		{
17	66	$this->artisanCommand = $artisanCommand;
18	66	$this->command = $command;
19	66	$this->arguments = $arguments;
20	66	}
21
22	66	private function title()
23		{
24	66	$title = '';
		0 ignored issues – show Unused Code introduced 2019-09-17 12:36 UTC by Report Bug Copy Issue Report `$title` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
25
26	66	if ($this->command === 'vendor:publish') {
27	60	$title = '<comment>Publishing resource:</comment> ';
28
29	60	if (isset($this->arguments['--provider'])) {
30	60	$title .= "Provider [<fg=cyan>{$this->arguments['--provider']}</>]";
31		}
32
33		$tagStringCallback = function (string $tag) {
34	30	return " Tag[<fg=cyan>$tag</>]";
35	60	};
36
37	60	if (isset($this->arguments['--tag'])) {
38	30	if (is_string($this->arguments['--tag'])) {
39	24	$title .= $tagStringCallback($this->arguments['--tag']);
40		} else {
41	60	foreach ($this->arguments['--tag'] as $tag) {
42	6	$title .= $tagStringCallback($tag);
43		}
44		}
45		}
46		} else {
47	6	$title = "<comment>Running artisan command:</comment> $this->command (".
48	6	$this->artisanCommand
49	6	->getApplication()
50	6	->find($this->command)
51	6	->getDescription().
52	6	')';
53		}
54
55	66	return $title;
56		}
57
58	66	public function __invoke(): bool
59		{
60		return $this->artisanCommand->task($this->title(), function () {
61	66	if ($this->artisanCommand->getOutput()->isVerbose()) {
62		$this->artisanCommand->getOutput()->newLine();
63
64		return ! $this->artisanCommand->call($this->command, $this->arguments);
65		}
66
67	66	return ! $this->artisanCommand->callSilent($this->command, $this->arguments);
68	66	});
69		}
70		}
71

mad-web / laravel-initializer

Push — master ( 6b5da6...9a1463 )

Artisan::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like