for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace MadWeb\Initializer\ExecutorActions;
use Illuminate\Console\Command;
class Artisan
{
private $artisanCommand;
private $command;
private $arguments;
public function __construct(Command $artisanCommand, string $command, array $arguments = [])
$this->artisanCommand = $artisanCommand;
$this->command = $command;
$this->arguments = $arguments;
}
private function title()
$title = '';
$title
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
if ($this->command === 'vendor:publish') {
$title = '<comment>Publishing resource:</comment> ';
if (isset($this->arguments['--provider'])) {
$title .= "Provider [<fg=cyan>{$this->arguments['--provider']}</>]";
$tagStringCallback = function (string $tag) {
return " Tag[<fg=cyan>$tag</>]";
};
if (isset($this->arguments['--tag'])) {
if (is_string($this->arguments['--tag'])) {
$title .= $tagStringCallback($this->arguments['--tag']);
} else {
foreach ($this->arguments['--tag'] as $tag) {
$title .= $tagStringCallback($tag);
$title = "<comment>Running artisan command:</comment> $this->command (".
$this->artisanCommand
->getApplication()
->find($this->command)
->getDescription().
')';
return $title;
public function __invoke(): bool
return $this->artisanCommand->task($this->title(), function () {
if ($this->artisanCommand->getOutput()->isVerbose()) {
$this->artisanCommand->getOutput()->newLine();
return ! $this->artisanCommand->call($this->command, $this->arguments);
return ! $this->artisanCommand->callSilent($this->command, $this->arguments);
});
mad-web /
laravel-initializer
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.