External::run() - Code Metrics - Inspection of "Publishing output colors removed" - mad-web/laravel-initializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9a1463...3718bd )

by Basenko

created 2019-10-02 16:18 UTC

External::run() B

↳ Parent: External

Complexity

Conditions	9
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	13.4798

Importance

Changes

Metric	Value
dl	0
loc	35
ccs	13
cts	21
cp	0.619
rs	8.0555
c	0
b	0
f	0
cc	9
nc	8
nop	0
crap	13.4798

<?php

namespace MadWeb\Initializer\Actions;

use Illuminate\Console\Command;
use RuntimeException;
use Symfony\Component\Process\Process;

class External extends Action
{
    private $command;

    private $arguments;

    public function __construct(Command $artisanCommand, string $command, array $arguments = [])
    {
        parent::__construct($artisanCommand);

        $this->artisanCommand = $artisanCommand;

        $this->command = $command;
        $this->arguments = $arguments;
    }

    public function title(): string
    {
        $argString = implode(' ', $this->arguments);

        return "<comment>Running external command:</comment> $this->command $argString";
    }

    public function run(): bool
    {
        $Process = new Process(empty($this->arguments)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            ? $this->command
            : array_merge([$this->command], $this->arguments));
        $Process->setTimeout(null);

        $isVerbose = $this->artisanCommand->getOutput()->isVerbose();


        if ($isVerbose) {
            $this->artisanCommand->getOutput()->newLine();

            if (Process::isTtySupported()) {
                $Process->setTty(true);
            } elseif (Process::isPtySupported()) {
                $Process->setPty(true);
            }
        }

        $Process->run($isVerbose ? function ($type, $buffer) {
            if (Process::ERR === $type) {
                $this->artisanCommand->error($buffer);

            } else {
                $this->artisanCommand->line($buffer);

            }
        } : null);

        $error = $Process->getErrorOutput();
        $exitCode = $Process->getExitCode();

        if ($error and $exitCode > 0) {
            throw new RuntimeException(trim($error));
        }

        return ! $exitCode;
    }
}


1		<?php
2
3		namespace MadWeb\Initializer\Actions;
4
5		use Illuminate\Console\Command;
6		use RuntimeException;
7		use Symfony\Component\Process\Process;
8
9		class External extends Action
10		{
11		private $command;
12
13		private $arguments;
14
15	18	public function __construct(Command $artisanCommand, string $command, array $arguments = [])
16		{
17	18	parent::__construct($artisanCommand);
18
19	18	$this->artisanCommand = $artisanCommand;
		0 ignored issues – show Bug introduced 2019-10-02 16:22 UTC by Report Bug Copy Issue Report The property `artisanCommand` does not seem to exist. Did you mean `command`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
20	18	$this->command = $command;
21	18	$this->arguments = $arguments;
22	18	}
23
24	18	public function title(): string
25		{
26	18	$argString = implode(' ', $this->arguments);
27
28	18	return "<comment>Running external command:</comment> $this->command $argString";
29		}
30
31	18	public function run(): bool
32		{
33	18	$Process = new Process(empty($this->arguments)
		0 ignored issues – show Bug introduced 2019-09-17 12:36 UTC by Report Bug Copy Issue Report It seems like `empty($this->arguments) ...and), $this->arguments)` can also be of type `string`; however, `Symfony\Component\Process\Process::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34	12	? $this->command
35	18	: array_merge([$this->command], $this->arguments));
36	18	$Process->setTimeout(null);
37
38	18	$isVerbose = $this->artisanCommand->getOutput()->isVerbose();
		0 ignored issues – show Bug introduced 2019-10-02 16:22 UTC by Report Bug Copy Issue Report The property `artisanCommand` does not seem to exist. Did you mean `command`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
39
40	18	if ($isVerbose) {
41		$this->artisanCommand->getOutput()->newLine();
		0 ignored issues – show Bug introduced 2019-10-02 16:22 UTC by Report Bug Copy Issue Report The property `artisanCommand` does not seem to exist. Did you mean `command`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
42		if (Process::isTtySupported()) {
43		$Process->setTty(true);
44		} elseif (Process::isPtySupported()) {
45		$Process->setPty(true);
46		}
47		}
48
49		$Process->run($isVerbose ? function ($type, $buffer) {
50		if (Process::ERR === $type) {
51		$this->artisanCommand->error($buffer);
		0 ignored issues – show Bug introduced 2019-10-02 16:22 UTC by Report Bug Copy Issue Report The property `artisanCommand` does not seem to exist. Did you mean `command`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
52		} else {
53		$this->artisanCommand->line($buffer);
		0 ignored issues – show Bug introduced 2019-10-02 16:22 UTC by Report Bug Copy Issue Report The property `artisanCommand` does not seem to exist. Did you mean `command`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
54		}
55	18	} : null);
56
57	18	$error = $Process->getErrorOutput();
58	18	$exitCode = $Process->getExitCode();
59
60	18	if ($error and $exitCode > 0) {
61	6	throw new RuntimeException(trim($error));
62		}
63
64	12	return ! $exitCode;
65		}
66		}
67

mad-web / laravel-initializer

Push — master ( 9a1463...3718bd )

External::run() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like