MadWeb\Initializer\Actions\External

Complexity

Total Complexity

11

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

73.32%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	title()	0	6	1
B	run()	0	35	9

<?php

namespace MadWeb\Initializer\Actions;

use Illuminate\Console\Command;
use RuntimeException;
use Symfony\Component\Process\Process;

class External extends Action
{
    private $command;

    private $arguments;

    public function __construct(Command $artisanCommand, string $command, array $arguments = [])
    {
        parent::__construct($artisanCommand);

        $this->artisanCommand = $artisanCommand;

The property artisanCommand does not seem to exist. Did you mean command?

        $this->command = $command;
        $this->arguments = $arguments;
    }

    public function title(): string
    {
        $argString = implode(' ', $this->arguments);

        return "<comment>Running external command:</comment> $this->command $argString";
    }

    public function run(): bool
    {
        $Process = new Process(empty($this->arguments)

It seems like empty($this->arguments) ? $this->command : array_merge(array($this->command), $this->arguments) can also be of type string; however, Symfony\Component\Process\Process::__construct() does only seem to accept array, maybe add an additional type check?

            ? $this->command
            : array_merge([$this->command], $this->arguments));
        $Process->setTimeout(null);

        $isVerbose = $this->artisanCommand->getOutput()->isVerbose();

The property artisanCommand does not seem to exist. Did you mean command?

        if ($isVerbose) {
            $this->artisanCommand->getOutput()->newLine();

The property artisanCommand does not seem to exist. Did you mean command?

            if (Process::isTtySupported()) {
                $Process->setTty(true);
            } elseif (Process::isPtySupported()) {
                $Process->setPty(true);
            }
        }

        $Process->run($isVerbose ? function ($type, $buffer) {
            if (Process::ERR === $type) {
                $this->artisanCommand->error($buffer);

The property artisanCommand does not seem to exist. Did you mean command?

            } else {
                $this->artisanCommand->line($buffer);

The property artisanCommand does not seem to exist. Did you mean command?

            }
        } : null);

        $error = $Process->getErrorOutput();
        $exitCode = $Process->getExitCode();

        if ($error and $exitCode > 0) {
            throw new RuntimeException(trim($error));
        }

        return ! $exitCode;
    }
}