EnumCastable::set() - Code Metrics - Inspection of "- Laravel 7.x support" - mad-web/laravel-enum - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 04bc93...ff2bef )

by Basenko

created 2020-03-04 13:50 UTC

EnumCastable::set() A

↳ Parent: EnumCastable

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	1
cts	1
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	4
crap	2

<?php

namespace MadWeb\Enum;

/**
 * @mixin \MadWeb\Enum\Enum
 * @internal Uses for custom casting implementation
 */
trait EnumCastable
{
    public function get($model, string $key, $value, array $attributes)

    {
        return new static($value);

    }

    public function set($model, string $key, $value, array $attributes)

    {
        if ($value instanceof static) {
            return $value->getValue();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return (new static($value))->getValue();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace MadWeb\Enum;
4
5		/**
6		* @mixin \MadWeb\Enum\Enum
7	12	* @internal Uses for custom casting implementation
8		*/
9	12	trait EnumCastable
10		{
11	12	public function get($model, string $key, $value, array $attributes)
		0 ignored issues – show Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The parameter `$attributes` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
12	9	{
13		return new static($value);
		0 ignored issues – show Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The call to `EnumCastable::__construct()` has too many arguments starting with `$value`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
14	9	}
15	9
16		public function set($model, string $key, $value, array $attributes)
		0 ignored issues – show Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The parameter `$attributes` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
17		{
18		if ($value instanceof static) {
19	12	return $value->getValue();
		0 ignored issues – show Bug introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20		}
21
22		return (new static($value))->getValue();
		0 ignored issues – show Unused Code introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report The call to `EnumCastable::__construct()` has too many arguments starting with `$value`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Bug introduced 2020-03-04 14:01 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23		}
24		}
25

mad-web / laravel-enum

Push — master ( 04bc93...ff2bef )

EnumCastable::set() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like