ModelsScrappedValidatorTest   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 24
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 9
dl 0
loc 24
rs 10
c 0
b 0
f 0
wmc 2

2 Methods

Rating   Name   Duplication   Size   Complexity  
A testValidatorThrowsExceptionWhenArrayIsEmpty() 0 8 1
A testValidatorDoesntThrowExceptionWhenArrayIsValid() 0 9 1
1
<?php
2
/**
3
 * File: ModelsScrappedValidatorTest.php
4
 *
5
 * @author      Maciej Sławik <[email protected]>
6
 * Github:      https://github.com/maciejslawik
7
 */
8
9
namespace MSlwk\Otomoto\App\Test\Unit\Model\Validator;
10
11
use MSlwk\Otomoto\App\Exception\ModelsNotFoundException;
12
use MSlwk\Otomoto\App\Model\Data\ModelDTO;
13
use MSlwk\Otomoto\App\Model\Data\ModelDTOArray;
14
use MSlwk\Otomoto\App\Model\Validator\ModelsScrappedValidator;
15
use PHPUnit\Framework\TestCase;
16
17
/**
18
 * Class ModelsScrappedValidatorTest
19
 * @package MSlwk\Otomoto\App\Test\Unit\Model\Validator
20
 */
21
class ModelsScrappedValidatorTest extends TestCase
22
{
23
    /**
24
     * @test
25
     */
26
    public function testValidatorDoesntThrowExceptionWhenArrayIsValid()
27
    {
28
        $modelDTOArray = new ModelDTOArray(
29
            new ModelDTO('Alfa Romeo')
30
        );
31
32
        $validator = new ModelsScrappedValidator();
33
34
        $this->assertEquals(null, $validator->validate($modelDTOArray));
0 ignored issues
show
Bug introduced by
Are you sure the usage of $validator->validate($modelDTOArray) targeting MSlwk\Otomoto\App\Model\...edValidator::validate() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
35
    }
36
37
    public function testValidatorThrowsExceptionWhenArrayIsEmpty()
38
    {
39
        $modelDTOArray = new ModelDTOArray();
40
41
        $validator = new ModelsScrappedValidator();
42
43
        $this->expectException(ModelsNotFoundException::class);
44
        $validator->validate($modelDTOArray);
45
    }
46
47
}
48