CampaignCreateHandler::createCampaign() - Code Metrics - Inspection of "Merge pull request #4 from snapshotpl/php8" - maciejslawik/freshmail - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5e9e3d...710625 )

by Maciej

created 2021-07-02 06:09 UTC

CampaignCreateHandler::createCampaign() B

↳ Parent: CampaignCreateHandler

Complexity

Conditions	10
Paths	1

Size

Total Lines	31
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	22.5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	16
c	1
b	0
f	0
nc	1
nop	10
dl	0
loc	31
ccs	9
cts	18
cp	0.5
crap	22.5
rs	7.6666

How to fix Complexity Many Parameters

<?php
/**
 * File: CampaignCreateHandler.php
 *
 * @author      Maciej Sławik <[email protected]>
 * Github:      https://github.com/maciejslawik
 */

namespace MSlwk\FreshMail\Handler\Campaign;

use MSlwk\FreshMail\Handler\AbstractHandler;

/**
 * Class CampaignCreateHandler
 *
 * @package MSlwk\FreshMail\Handler\Campaign
 */
class CampaignCreateHandler extends AbstractHandler
{
    const API_ENDPOINT = '/rest/campaigns/create';

    /**
     * @param string $name
     * @param string $urlToDownloadContent
     * @param string $content
     * @param string $subject
     * @param string $fromAddress
     * @param string $fromName
     * @param string $replyTo
     * @param string $listHash
     * @param string $groupHash
     * @param string $resignLink
     * @return string
     */
    public function createCampaign(
        string $name,
        string $urlToDownloadContent = '',
        string $content = '',
        string $subject = '',
        string $fromAddress = '',
        string $fromName = '',
        string $replyTo = '',
        string $listHash = '',
        string $groupHash = '',
        string $resignLink = ''
    ) {
        $getParameters = [];
        $postParameters = [
            'name' => $name,
            'url' => $urlToDownloadContent ?: null,
            'html' => $content ?: null,
            'subject' => $subject ?: null,
            'from_address' => $fromAddress ?: null,
            'from_name' => $fromName ?: null,
            'reply_to' => $replyTo ?: null,
            'list' => $listHash ?: null,
            'group' => $groupHash ?: null,
            'resignlink' => $resignLink ?: null
        ];

        $postParameters = array_filter($postParameters, function ($value) {
            return $value !== null;
        });
        $response = $this->processRequest($getParameters, $postParameters);
        return $response->data->hash;
    }

    /**
     * @return string
     */
    protected function getApiEndpoint(): string
    {
        return self::API_ENDPOINT;
    }
}


1		<?php
2		/**
3		* File: CampaignCreateHandler.php
4		*
5		* @author Maciej Sławik <[email protected]>
6		* Github: https://github.com/maciejslawik
7		*/
8
9		namespace MSlwk\FreshMail\Handler\Campaign;
10
11		use MSlwk\FreshMail\Handler\AbstractHandler;
12
13		/**
14		* Class CampaignCreateHandler
15		*
16		* @package MSlwk\FreshMail\Handler\Campaign
17		*/
18		class CampaignCreateHandler extends AbstractHandler
19		{
20		const API_ENDPOINT = '/rest/campaigns/create';
21
22		/**
23		* @param string $name
24		* @param string $urlToDownloadContent
25		* @param string $content
26		* @param string $subject
27		* @param string $fromAddress
28		* @param string $fromName
29		* @param string $replyTo
30		* @param string $listHash
31		* @param string $groupHash
32		* @param string $resignLink
33		* @return string
34		*/
35	98	public function createCampaign(
36		string $name,
37		string $urlToDownloadContent = '',
38		string $content = '',
39		string $subject = '',
40		string $fromAddress = '',
41		string $fromName = '',
42		string $replyTo = '',
43		string $listHash = '',
44		string $groupHash = '',
45		string $resignLink = ''
46		) {
47	98	$getParameters = [];
48	28	$postParameters = [
49	98	'name' => $name,
50		'url' => $urlToDownloadContent ?: null,
51		'html' => $content ?: null,
52		'subject' => $subject ?: null,
53		'from_address' => $fromAddress ?: null,
54		'from_name' => $fromName ?: null,
55		'reply_to' => $replyTo ?: null,
56		'list' => $listHash ?: null,
57		'group' => $groupHash ?: null,
58		'resignlink' => $resignLink ?: null
59		];
60
61	70	$postParameters = array_filter($postParameters, function ($value) {
62	98	return $value !== null;
63	98	});
64	98	$response = $this->processRequest($getParameters, $postParameters);
65	7	return $response->data->hash;
66		}
67
68		/**
69		* @return string
70		*/
71	7	protected function getApiEndpoint(): string
72		{
73	7	return self::API_ENDPOINT;
74		}
75		}
76

maciejslawik / freshmail

Push — master ( 5e9e3d...710625 )

CampaignCreateHandler::createCampaign() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like