Issues in wfv-validate.php - All Issues - Inspection of "Merge pull request #139 from macder/feature/struct..." - macder/wfv-validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dd277f...aad1d1 )

by Maciej

created 2017-05-25 04:57 UTC

wfv-validate.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

defined( 'ABSPATH' ) || die();
/*
Plugin Name: WFV - Form Validation
Plugin URI:  https://macder.github.io/wfv/
Description: A simple fluid and concise API to manage user input, validation, feedback, and safe output.
Version:     0.11.0
Author:      Maciej Derulski
Author URI:  https://github.com/macder
License:     BSD 3-Clause
License URI: https://github.com/macder/wp-form-validation/blob/master/LICENSE
*/

define( 'WFV_VALIDATE_VERSION', '0.11.0' );
define( 'WFV_VALIDATE__MINIMUM_WP_VERSION', '3.7' );
define( 'WFV_VALIDATE__PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
define( 'WFV_VALIDATE__ACTION_POST', 'validate_form' );

require_once WFV_VALIDATE__PLUGIN_DIR . '/vendor/autoload.php';

use WFV\Client;
use WFV\Agent\InspectionAgent;
use WFV\Artisan\Director;
use WFV\Artisan\FormArtisan;
use WFV\Contract\FormInterface;
use WFV\Factory\ValidatorFactory;

/**
 *
 *
 * @since 0.10.0
 *
 * @param string $action
 * @param array $form Form arguments
 * @param bool $trim Trim whitespace from beginning and end of string
 */
function wfv_create( $action, array &$form, $trim = true ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	$inspect = new InspectionAgent( $action );
	$input = ( true === $inspect->safe_submit() ) ? $_POST : array();

	$builder = new FormArtisan( $form );
	$form = new Client( ( new Director( $action ) )
		->with( 'input', [ $input, $trim ] )
		->with( 'rules' )
		->with( 'errors' )
		->with( 'validator' )
		->compose( $builder )
	);

	if( $input ) {
		wfv_validate( $form );
	}
}

/**
 *
 *
 * @since 0.11.0
 *
 * @param FormComposite $form
 * @return bool
 */
function wfv_validate( FormInterface $form ) {
	$factory = ( new ValidatorFactory() )
		->add( $form->rules()->unique() );
	return $form->is_valid( $factory );
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-19 16:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 14 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			defined( 'ABSPATH' ) \|\| die();
3			/*
4			Plugin Name: WFV - Form Validation
5			Plugin URI: https://macder.github.io/wfv/
6			Description: A simple fluid and concise API to manage user input, validation, feedback, and safe output.
7			Version: 0.11.0
8			Author: Maciej Derulski
9			Author URI: https://github.com/macder
10			License: BSD 3-Clause
11			License URI: https://github.com/macder/wp-form-validation/blob/master/LICENSE
12			*/
13
14			define( 'WFV_VALIDATE_VERSION', '0.11.0' );
15			define( 'WFV_VALIDATE__MINIMUM_WP_VERSION', '3.7' );
16			define( 'WFV_VALIDATE__PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
17			define( 'WFV_VALIDATE__ACTION_POST', 'validate_form' );
18
19			require_once WFV_VALIDATE__PLUGIN_DIR . '/vendor/autoload.php';
20
21			use WFV\Client;
22			use WFV\Agent\InspectionAgent;
23			use WFV\Artisan\Director;
24			use WFV\Artisan\FormArtisan;
25			use WFV\Contract\FormInterface;
26			use WFV\Factory\ValidatorFactory;
27
28			/**
29			*
30			*
31			* @since 0.10.0
32			*
33			* @param string $action
34			* @param array $form Form arguments
35			* @param bool $trim Trim whitespace from beginning and end of string
36			*/
37			function wfv_create( $action, array &$form, $trim = true ) {
			0 ignored issues – show Coding Style introduced 2017-05-19 16:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `wfv_create` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
38			$inspect = new InspectionAgent( $action );
39			$input = ( true === $inspect->safe_submit() ) ? $_POST : array();
40
41			$builder = new FormArtisan( $form );
42			$form = new Client( ( new Director( $action ) )
43			->with( 'input', [ $input, $trim ] )
44			->with( 'rules' )
45			->with( 'errors' )
46			->with( 'validator' )
47			->compose( $builder )
48			);
49
50			if( $input ) {
51			wfv_validate( $form );
52			}
53			}
54
55			/**
56			*
57			*
58			* @since 0.11.0
59			*
60			* @param FormComposite $form
61			* @return bool
62			*/
63			function wfv_validate( FormInterface $form ) {
64			$factory = ( new ValidatorFactory() )
65			->add( $form->rules()->unique() );
66			return $form->is_valid( $factory );
67			}
68

macder / wfv-validation

Push — master ( dd277f...aad1d1 )

wfv-validate.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like