SendJobFactoryTest::setUp() - Code Metrics - ma-si/mailer-component-queue - Measure and Improve Code Quality continuously with Scrutinizer

SendJobFactoryTest::setUp() A
last analyzed 2017-07-25 19:26 UTC

↳ Parent: SendJobFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php

/**
 * Mailer Queue Component (http://mateuszsitek.com/projects/mailer-component-queue)
 *
 * @copyright Copyright (c) 2017 DIGITAL WOLVES LTD (http://digitalwolves.ltd) All rights reserved.
 * @license   http://opensource.org/licenses/BSD-3-Clause BSD-3-Clause
 */

namespace Test\Aist\Mailer\Component\Queue\Job;

use Aist\Mailer\Component\Queue\Job\SendJob;
use Aist\Mailer\Component\Queue\Job\SendJobFactory;
use Interop\Container\ContainerInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ProphecyInterface;
use Psr\Log\LoggerInterface;
use Zend\Mail\Transport\TransportInterface;

class SendJobFactoryTest extends TestCase
{
    /**
     * @var ContainerInterface|ProphecyInterface
     */
    private $container;

    /** @inheritdoc */
    public function setUp()
    {
        $this->container = $this->prophesize(ContainerInterface::class);

        $mailer = $this->prophesize(TransportInterface::class);
        $this->container->get('mailer')->willReturn($mailer);

        $logger = $this->prophesize(LoggerInterface::class);
        $this->container->get(LoggerInterface::class)->willReturn($logger);
    }

    public function testCallingFactoryReturnsJobInstance()
    {
        $factory = new SendJobFactory();
        $this->assertInstanceOf(SendJobFactory::class, $factory);

        $class = $factory($this->container->reveal());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->assertInstanceOf(SendJob::class, $class);
    }
}


1			<?php
2
3			/**
4			* Mailer Queue Component (http://mateuszsitek.com/projects/mailer-component-queue)
5			*
6			* @copyright Copyright (c) 2017 DIGITAL WOLVES LTD (http://digitalwolves.ltd) All rights reserved.
7			* @license http://opensource.org/licenses/BSD-3-Clause BSD-3-Clause
8			*/
9
10			namespace Test\Aist\Mailer\Component\Queue\Job;
11
12			use Aist\Mailer\Component\Queue\Job\SendJob;
13			use Aist\Mailer\Component\Queue\Job\SendJobFactory;
14			use Interop\Container\ContainerInterface;
15			use PHPUnit\Framework\TestCase;
16			use Prophecy\Prophecy\ProphecyInterface;
17			use Psr\Log\LoggerInterface;
18			use Zend\Mail\Transport\TransportInterface;
19
20			class SendJobFactoryTest extends TestCase
21			{
22			/**
23			* @var ContainerInterface\|ProphecyInterface
24			*/
25			private $container;
26
27			/** @inheritdoc */
28			public function setUp()
29			{
30			$this->container = $this->prophesize(ContainerInterface::class);
31
32			$mailer = $this->prophesize(TransportInterface::class);
33			$this->container->get('mailer')->willReturn($mailer);
34
35			$logger = $this->prophesize(LoggerInterface::class);
36			$this->container->get(LoggerInterface::class)->willReturn($logger);
37			}
38
39			public function testCallingFactoryReturnsJobInstance()
40			{
41			$factory = new SendJobFactory();
42			$this->assertInstanceOf(SendJobFactory::class, $factory);
43
44			$class = $factory($this->container->reveal());
			0 ignored issues – show Bug introduced 2017-07-18 13:21 UTC by Report Bug Copy Issue Report The method `reveal` does only exist in `Prophecy\Prophecy\ProphecyInterface`, but not in `Interop\Container\ContainerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45
46			$this->assertInstanceOf(SendJob::class, $class);
47			}
48			}
49

ma-si / mailer-component-queue

SendJobFactoryTest::setUp() A last analyzed 2017-07-25 19:26 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

SendJobFactoryTest::setUp() A
last analyzed 2017-07-25 19:26 UTC