Issues in export.php (master) - Issues in master - mAAdhaTTah/wordpress-github-sync - Measure and Improve Code Quality continuously with Scrutinizer

Issues (64)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/export.php (21 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * GitHub Export Manager.
 *
 * @package WordPress_GitHub_Sync
 */

/**
 * Class WordPress_GitHub_Sync_Export
 */
class WordPress_GitHub_Sync_Export {

	/**
	 * Option key for export user.
	 */
	const EXPORT_USER_OPTION = '_wpghs_export_user_id';

	/**
	 * Application container.
	 *
	 * @var WordPress_GitHub_Sync
	 */
	protected $app;

	/**
	 * Initializes a new export manager.
	 *
	 * @param WordPress_GitHub_Sync $app Application container.
	 */
	public function __construct( WordPress_GitHub_Sync $app ) {
		$this->app = $app;
	}

	/**
	 * Updates all of the current posts in the database on master.
	 *
	 * @return string|WP_Error
	 */
	public function full() {

		$posts = $this->app->database()->fetch_all_supported();

		if ( is_wp_error( $posts ) ) {
			return $posts;
		}

		$master = $this->app->api()->fetch()->master();

		if ( is_wp_error( $master ) ) {
			return $master;
		}

		foreach ( $posts as $post ) {
			$master->tree()->add_post_to_tree( $post );
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		}

		$master->set_message(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			apply_filters(
				'wpghs_commit_msg_full',
				sprintf(
					'Full export from WordPress at %s (%s)',
					site_url(),
					get_bloginfo( 'name' )
				)
			) . $this->get_commit_msg_tag()
		);

		$result = $this->app->api()->persist()->commit( $master );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		if ( is_wp_error( $result ) ) {
			return $result;
		}

		return $this->update_shas( $posts );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}

	/**
	 * Updates the provided post ID in master.
	 *
	 * @param int $post_id Post ID to update.
	 *
	 * @return string|WP_Error
	 */
	public function update( $post_id ) {
		$post = $this->app->database()->fetch_by_id( $post_id );

		if ( is_wp_error( $post ) ) {
			return $post;
		}

		if ( 'trash' === $post->status() ) {
			return $this->delete( $post_id );
		}

		$master = $this->app->api()->fetch()->master();

		if ( is_wp_error( $master ) ) {
			return $master;
		}

		$master->tree()->add_post_to_tree( $post );
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		$master->set_message(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			apply_filters(
				'wpghs_commit_msg_single',
				sprintf(
					'Syncing %s from WordPress at %s (%s)',
					$post->github_path(),
					site_url(),
					get_bloginfo( 'name' )
				),
				$post
			) . $this->get_commit_msg_tag()
		);

		$result = $this->app->api()->persist()->commit( $master );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		if ( is_wp_error( $result ) ) {
			return $result;
		}

		return $this->update_shas( array( $post ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	/**
	 * Updates GitHub-created posts with latest WordPress data.
	 *
	 * @param array<WordPress_GitHub_Sync_Post> $posts Array of Posts to create.
	 *
	 * @return string|WP_Error
	 */
	public function new_posts( array $posts ) {
		$master = $this->app->api()->fetch()->master();

		if ( is_wp_error( $master ) ) {
			return $master;
		}

		foreach ( $posts as $post ) {
			$master->tree()->add_post_to_tree( $post );
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		}

		$master->set_message(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			apply_filters(
				'wpghs_commit_msg_new_posts',
				sprintf(
					'Updating new posts from WordPress at %s (%s)',
					site_url(),
					get_bloginfo( 'name' )
				)
			) . $this->get_commit_msg_tag()
		);

		$result = $this->app->api()->persist()->commit( $master );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		if ( is_wp_error( $result ) ) {
			return $result;
		}

		return $this->update_shas( $posts );
	}

	/**
	 * Deletes a provided post ID from master.
	 *
	 * @param int $post_id Post ID to delete.
	 *
	 * @return string|WP_Error
	 */
	public function delete( $post_id ) {

		$post = $this->app->database()->fetch_by_id( $post_id );


		if ( is_wp_error( $post ) ) {
			return $post;
		}

		$master = $this->app->api()->fetch()->master();

		if ( is_wp_error( $master ) ) {
			return $master;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		$master->tree()->remove_post_from_tree( $post );
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		$master->set_message(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			apply_filters(
				'wpghs_commit_msg_delete',
				sprintf(
					'Deleting %s via WordPress at %s (%s)',
					$post->github_path(),
					site_url(),
					get_bloginfo( 'name' )
				),
				$post
			) . $this->get_commit_msg_tag()
		);

		$result = $this->app->api()->persist()->commit( $master );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		if ( is_wp_error( $result ) ) {
			return $result;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		return __( 'Export to GitHub completed successfully.', 'wp-github-sync' );
	}

	/**
	 * Use the new tree to save sha data
	 * for all the updated posts.
	 *
	 * @param WordPress_GitHub_Sync_Post[] $posts Posts to fetch updated shas for.
	 *
	 * @return string|WP_Error
	 */
	protected function update_shas( array $posts ) {
		$master   = $this->app->api()->fetch()->master();
		$attempts = 1;

		while ( is_wp_error( $master ) && $attempts < 5 ) {
			$master = $this->app->api()->fetch()->master();
			$attempts ++;
		}

		if ( is_wp_error( $master ) ) {
			// @todo throw a big warning! not having the latest shas is BAD
			// Solution: Show error message and link to kick off sha importing.
			return $master;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		foreach ( $posts as $post ) {
			$blob = $master->tree()->get_blob_by_path( $post->github_path() );
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

			if ( $blob ) {
				$this->app->database()->set_post_sha( $post, $blob->sha() );
			}
		}

		return __( 'Export to GitHub completed successfully.', 'wp-github-sync' );
	}

	/**
	 * Saves the export user to the database.
	 *
	 * @param int $user_id User ID to export with.
	 *
	 * @return bool
	 */
	public function set_user( $user_id ) {
		return update_option( self::EXPORT_USER_OPTION, (int) $user_id );
	}

	/**
	 * Gets the commit message tag.
	 *
	 * @return string
	 */
	protected function get_commit_msg_tag() {
		$tag = apply_filters( 'wpghs_commit_msg_tag', 'wpghs' );

		if ( ! $tag ) {
			throw new Exception( __( 'Commit message tag not set. Filter `wpghs_commit_msg_tag` misconfigured.', 'wp-github-sync' ) );
		}

		return ' - ' . $tag;
	}
}


Issues (64)

Security Analysis not enabled

lib/export.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

mAAdhaTTah / wordpress-github-sync

Issues (64)

Security Analysis not enabled

lib/export.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like