FileResource - Code Metrics - Inspection of "Add support for .env and getenv(). Resolve #2" - m1/Vars - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 79e180...3094b9 )

by Miles

created 2015-12-15 23:37 UTC

FileResource B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	326
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

99.17%

Importance

Changes	8
Bugs	1	Features	2

Metric	Value
wmc	45
c	8
b	1
f	2
lcom	1
cbo	5
dl	0
loc	326
ccs	120
cts	121
cp	0.9917
rs	8.3673

14 Methods

Rating	Name	Size	Complexity
A	__construct()	15	2
A	makePaths()	15	1
A	searchForResources()	10	2
B	parseContent()	17	6
A	parseText()	18	4
B	useImports()	14	5
B	processImport()	17	5
A	import2Resource()	10	2
A	createResource()	19	4
A	importResource()	15	3
A	isAssoc()	4	1
B	isRelative()	20	8
A	getFilename()	4	1
A	getRawContent()	4	1

How to fix Complexity

<?php

/**
 * This file is part of the m1\vars library
 *
 * Copyright (c) Miles Croxford <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @package     m1/vars
 * @version     0.2.0
 * @author      Miles Croxford <[email protected]>
 * @copyright   Copyright (c) Miles Croxford <[email protected]>
 * @license     http://github.com/m1/vars/blob/master/LICENSE
 * @link        http://github.com/m1/vars/blob/master/README.MD Documentation
 */

namespace M1\Vars\Resource;

use M1\Vars\Traits\FileTrait;
use Symfony\Component\Filesystem\Filesystem;

/**
 * File Resource enables interaction with files as resources
 *
 * @since 0.1.0
 */
class FileResource extends AbstractResource
{
    /**
     * Basic file interaction logic
     */
    use FileTrait;

    /**
     * The env separator for environment replacements
     *
     * @var string
     */
    private static $env_separator = '_ENV::';

    /**
     * The filename of the loaded file
     *
     * @var string
     */
    private $filename;

    /**
     * The parent ResourceProvider
     *
     * @var \M1\Vars\Resource\ResourceProvider
     */
    private $provider;

    /**
     * The raw content from the passed file
     *
     * @var mixed
     */
    private $raw_content = array();

    /**
     * The file resource constructor to get and parse the content from files
     *
     * @param \M1\Vars\Resource\ResourceProvider $provider The parent ResourceProvider
     * @param string                             $file     The passed file
     */
    public function __construct(ResourceProvider $provider, $file)
    {
        $this->provider = $provider;
        $this->vars = $provider->vars;

        $this->makePaths($file);
        $this->validate();

        $content = $this->loadContent($this->file);
        $this->raw_content = $content;

        if ($content) {
            $this->content = $this->searchForResources($content);
        }
    }

    /**
     * Make the paths used for the filename variable
     *
     * @param string $file The passed file
     */
    private function makePaths($file)
    {
        $file = realpath($file);

        $base_path = $this->provider->vars->getBasePath();

        $filesystem = new Filesystem();
        $abs_path = $filesystem->makePathRelative(
            $file,
            $base_path
        );

        $this->file = $file;
        $this->filename = rtrim($abs_path, "/");
    }

    /**
     * Search for imports in the files and does the replacement variables
     *
     * @param mixed $content The file content received from the loader
     *
     * @return array Returns the parsed content
     */
    private function searchForResources($content = array())
    {
        $returned_content = array();

        foreach ($content as $ck => $cv) {
            $returned_content = $this->parseContent($ck, $cv, $returned_content);
        }

        return $returned_content;
    }

    /**
     * Parses the contents inside the content array
     *
     * @param mixed $key              The key of the content array
     * @param mixed $value            The value of the key
     * @param array $returned_content The modified content array to return
     *
     * @return array Returns the modified content array
     */
    private function parseContent($key, $value, $returned_content)
    {
        if ($key === 'imports' && !is_null($value) && !empty($value)) {
            $imported_resource = $this->useImports($value);

            if ($imported_resource) {

                $returned_content = array_replace_recursive($returned_content, $imported_resource);
            }

        } elseif (is_array($value)) {
            $returned_content[$key] = $this->searchForResources($value);
        } else {
            $returned_content[$key] = $this->parseText($value);
        }

        return $returned_content;
    }
    /**
     * Parses the text for option and environment replacements and replaces the text
     *
     * @param string $text The text to be parsed
     *
     * @return string|null The parsed string
     */
    private function parseText($text)
    {
        if (substr($text, 0, 6) === self::$env_separator) {
            $variable = trim(substr($text, strlen(self::$env_separator)));

            if ($variable) {
                $value = getenv($variable);

                if ($value) {
                    return $value;
                }
            }
        } else {
            return strtr($text, $this->vars->getVariables());
        }

        return null;
    }

    /**
     * Use the import arrays to import resources
     *
     * @param mixed $imports The resources wanting to be imported
     *
     * @return array The parsed imported resources
     */
    private function useImports($imports)
    {
        $imported_resources = array();

        if ((is_array($imports) && $this->isAssoc($imports)) || is_string($imports)) {
            $imports = array($imports);
        }

        foreach ($imports as $import) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $imported_resources = $this->processImport($import, $imported_resources);
        }

        return $imported_resources;
    }

    /**
     * Processes the import and gets individual import if set and passes them off to import2Resources()
     *
     * @param mixed $import The import to be processed
     * @param array $imported_resources The array of imported resources
     *
     * @return array The parsed imported resources
     */
    private function processImport($import, array $imported_resources)
    {
        if (is_array($import) && array_key_exists('resource', $import) && is_array($import['resource'])) {
            foreach ($import['resource'] as $resource) {
                $temp = array(
                    'resource' => $resource,
                    'relative' => $this->isRelative($import)
                );

                $imported_resources = $this->import2Resource($temp, $imported_resources);
            }
        } else {
            $imported_resources = $this->import2Resource($import, $imported_resources);
        }

        return $imported_resources;
    }

    /**
     * Creates the resource from the import then imports it
     *
     * @param array|string $import The string|array to be converted to a resource
     * @param array $imported_resources The array of imported resources
     *
     * @return array The imported resources
     */
    private function import2Resource($import, array $imported_resources)
    {
        $resource = $this->createResource($import);

        if ($resource) {
            $imported_resources = $this->importResource($resource, $imported_resources);
        }

        return $imported_resources;
    }

    /**
     * Creates resource from the import
     *
     * @param array|string $import The import to create a resource from
     *
     * @return array|\M1\Vars\Resource\ResourceProvider The resource of the import
     */
    private function createResource($import)
    {
        if (is_array($import) && array_key_exists('resource', $import)) {
            $import_resource = $import;
            $import_resource['relative'] = $this->isRelative($import_resource);
        } elseif (is_string($import)) {
            $import_resource = array('resource' => $import, 'relative' => true);
        } else {
            return false;
        }

        $import_resource = new ResourceProvider(
            $this->provider->vars,
            sprintf('%s/%s', dirname($this->file), $import_resource['resource']),
            $import_resource['relative']
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        );

        return $import_resource;
    }

    /**
     * Import resource into the imported resources and merge contents
     *
     * @param ResourceProvider $provider The new imported resource
     * @param array            $imported_resources The imported resources
     *
     * @return array The modified imported resources
     */
    private function importResource(ResourceProvider $provider, $imported_resources)
    {
        $content = $provider->getContent();
        $parent_content = $provider->getParentContent();

        if (!empty($content)) {
            $imported_resources = array_replace_recursive($imported_resources, $content);
        }

        if (!empty($parent_content)) {
            $this->provider->addParentContent($parent_content);
        }

        return $imported_resources;
    }

    /**
     * Returns whether the passed array is associative
     *
     * @param array $array The passed array
     *
     * @return bool Is the passed array associative
     */
    private function isAssoc(array $array)
    {
        return array_keys($array) !== range(0, count($array) - 1);
    }

    /**
     * Checks if the passed import is wanting to be merged into the parent content or relative content
     *
     * @param mixed $import The passed import
     *
     * @return bool Returns whether wanting to be a relative import
     */
    public function isRelative($import)
    {
        $relative = (isset($import['relative'])) ? $import['relative'] : true;

        switch (strtolower($relative)) {
            case false:

            case 'false':
            case 'no':
                $value = false;
                break;
            case true:

            case 'yes':
            case 'true':
            default:
                $value = true;
                break;
        }

        return $value;
    }

    /**
     * Returns the filename of the resource
     *
     * @return mixed The filename
     */
    public function getFilename()
    {
        return $this->filename;
    }

    /**
     * Returns the raw content of the resource
     *
     * @return array|mixed The raw content
     */
    public function getRawContent()
    {
        return $this->raw_content;
    }
}


GitHub Access Token became invalid

Push — master ( 79e180...3094b9 )

FileResource B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

14 Methods

How to fix Complexity

Complex Class

1		<?php
2
3		/**
4		* This file is part of the m1\vars library
5		*
6		* Copyright (c) Miles Croxford <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*
11		* @package m1/vars
12		* @version 0.2.0
13		* @author Miles Croxford <[email protected]>
14		* @copyright Copyright (c) Miles Croxford <[email protected]>
15		* @license http://github.com/m1/vars/blob/master/LICENSE
16		* @link http://github.com/m1/vars/blob/master/README.MD Documentation
17		*/
18
19		namespace M1\Vars\Resource;
20
21		use M1\Vars\Traits\FileTrait;
22		use Symfony\Component\Filesystem\Filesystem;
23
24		/**
25		* File Resource enables interaction with files as resources
26		*
27		* @since 0.1.0
28		*/
29		class FileResource extends AbstractResource
30		{
31		/**
32		* Basic file interaction logic
33		*/
34		use FileTrait;
35
36		/**
37		* The env separator for environment replacements
38		*
39		* @var string
40		*/
41		private static $env_separator = '_ENV::';
42
43		/**
44		* The filename of the loaded file
45		*
46		* @var string
47		*/
48		private $filename;
49
50		/**
51		* The parent ResourceProvider
52		*
53		* @var \M1\Vars\Resource\ResourceProvider
54		*/
55		private $provider;
56
57		/**
58		* The raw content from the passed file
59		*
60		* @var mixed
61		*/
62		private $raw_content = array();
63
64		/**
65		* The file resource constructor to get and parse the content from files
66		*
67		* @param \M1\Vars\Resource\ResourceProvider $provider The parent ResourceProvider
68		* @param string $file The passed file
69		*/
70	60	public function __construct(ResourceProvider $provider, $file)
71		{
72	60	$this->provider = $provider;
73	60	$this->vars = $provider->vars;
74
75	60	$this->makePaths($file);
76	60	$this->validate();
77
78	60	$content = $this->loadContent($this->file);
79	53	$this->raw_content = $content;
80
81	53	if ($content) {
82	49	$this->content = $this->searchForResources($content);
83	48	}
84	52	}
85
86		/**
87		* Make the paths used for the filename variable
88		*
89		* @param string $file The passed file
90		*/
91	60	private function makePaths($file)
92		{
93	60	$file = realpath($file);
94
95	60	$base_path = $this->provider->vars->getBasePath();
96
97	60	$filesystem = new Filesystem();
98	60	$abs_path = $filesystem->makePathRelative(
99	60	$file,
100		$base_path
101	60	);
102
103	60	$this->file = $file;
104	60	$this->filename = rtrim($abs_path, "/");
105	60	}
106
107		/**
108		* Search for imports in the files and does the replacement variables
109		*
110		* @param mixed $content The file content received from the loader
111		*
112		* @return array Returns the parsed content
113		*/
114	49	private function searchForResources($content = array())
115		{
116	49	$returned_content = array();
117
118	49	foreach ($content as $ck => $cv) {
119	49	$returned_content = $this->parseContent($ck, $cv, $returned_content);
120	48	}
121
122	48	return $returned_content;
123		}
124
125		/**
126		* Parses the contents inside the content array
127		*
128		* @param mixed $key The key of the content array
129		* @param mixed $value The value of the key
130		* @param array $returned_content The modified content array to return
131		*
132		* @return array Returns the modified content array
133		*/
134	49	private function parseContent($key, $value, $returned_content)
135		{
136	49	if ($key === 'imports' && !is_null($value) && !empty($value)) {
137	40	$imported_resource = $this->useImports($value);
138
139	39	if ($imported_resource) {
		0 ignored issues – show Bug Best Practice introduced 2015-12-07 14:50 UTC by Report Bug Copy Issue Report The expression `$imported_resource` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
140	37	$returned_content = array_replace_recursive($returned_content, $imported_resource);
141	37	}
142
143	48	} elseif (is_array($value)) {
144	11	$returned_content[$key] = $this->searchForResources($value);
145	11	} else {
146	47	$returned_content[$key] = $this->parseText($value);
147		}
148
149	48	return $returned_content;
150		}
151		/**
152		* Parses the text for option and environment replacements and replaces the text
153		*
154		* @param string $text The text to be parsed
155		*
156		* @return string\|null The parsed string
157		*/
158	47	private function parseText($text)
159		{
160	47	if (substr($text, 0, 6) === self::$env_separator) {
161	1	$variable = trim(substr($text, strlen(self::$env_separator)));
162
163	1	if ($variable) {
164	1	$value = getenv($variable);
165
166	1	if ($value) {
167	1	return $value;
168		}
169	1	}
170	1	} else {
171	46	return strtr($text, $this->vars->getVariables());
172		}
173
174	1	return null;
175		}
176
177		/**
178		* Use the import arrays to import resources
179		*
180		* @param mixed $imports The resources wanting to be imported
181		*
182		* @return array The parsed imported resources
183		*/
184	40	private function useImports($imports)
185		{
186	40	$imported_resources = array();
187
188	40	if ((is_array($imports) && $this->isAssoc($imports)) \|\| is_string($imports)) {
189	34	$imports = array($imports);
190	34	}
191
192	40	foreach ($imports as $import) {
		0 ignored issues – show Bug introduced 2015-12-07 14:50 UTC by Report Bug Copy Issue Report The expression `$imports` of type `object\|integer\|double\|null\|array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
193	40	$imported_resources = $this->processImport($import, $imported_resources);
194	39	}
195
196	39	return $imported_resources;
197		}
198
199		/**
200		* Processes the import and gets individual import if set and passes them off to import2Resources()
201		*
202		* @param mixed $import The import to be processed
203		* @param array $imported_resources The array of imported resources
204		*
205		* @return array The parsed imported resources
206		*/
207	40	private function processImport($import, array $imported_resources)
208		{
209	40	if (is_array($import) && array_key_exists('resource', $import) && is_array($import['resource'])) {
210	1	foreach ($import['resource'] as $resource) {
211		$temp = array(
212	1	'resource' => $resource,
213	1	'relative' => $this->isRelative($import)
214	1	);
215
216	1	$imported_resources = $this->import2Resource($temp, $imported_resources);
217	1	}
218	1	} else {
219	40	$imported_resources = $this->import2Resource($import, $imported_resources);
220		}
221
222	39	return $imported_resources;
223		}
224
225		/**
226		* Creates the resource from the import then imports it
227		*
228		* @param array\|string $import The string\|array to be converted to a resource
229		* @param array $imported_resources The array of imported resources
230		*
231		* @return array The imported resources
232		*/
233	40	private function import2Resource($import, array $imported_resources)
234		{
235	40	$resource = $this->createResource($import);
236
237	39	if ($resource) {
238	39	$imported_resources = $this->importResource($resource, $imported_resources);
239	39	}
240
241	39	return $imported_resources;
242		}
243
244		/**
245		* Creates resource from the import
246		*
247		* @param array\|string $import The import to create a resource from
248		*
249		* @return array\|\M1\Vars\Resource\ResourceProvider The resource of the import
250		*/
251	40	private function createResource($import)
252		{
253	40	if (is_array($import) && array_key_exists('resource', $import)) {
254	8	$import_resource = $import;
255	8	$import_resource['relative'] = $this->isRelative($import_resource);
256	40	} elseif (is_string($import)) {
257	33	$import_resource = array('resource' => $import, 'relative' => true);
258	33	} else {
259		return false;
260		}
261
262	40	$import_resource = new ResourceProvider(
263	40	$this->provider->vars,
264	40	sprintf('%s/%s', dirname($this->file), $import_resource['resource']),
265	40	$import_resource['relative']
		0 ignored issues – show Bug introduced 2015-12-07 14:50 UTC by Report Bug Copy Issue Report It seems like `$import_resource['relative']` can also be of type `string`; however, `M1\Vars\Resource\ResourceProvider::__construct()` does only seem to accept `boolean`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
266	40	);
267
268	39	return $import_resource;
269		}
270
271		/**
272		* Import resource into the imported resources and merge contents
273		*
274		* @param ResourceProvider $provider The new imported resource
275		* @param array $imported_resources The imported resources
276		*
277		* @return array The modified imported resources
278		*/
279	39	private function importResource(ResourceProvider $provider, $imported_resources)
280		{
281	39	$content = $provider->getContent();
282	39	$parent_content = $provider->getParentContent();
283
284	39	if (!empty($content)) {
285	37	$imported_resources = array_replace_recursive($imported_resources, $content);
286	37	}
287
288	39	if (!empty($parent_content)) {
289	7	$this->provider->addParentContent($parent_content);
290	7	}
291
292	39	return $imported_resources;
293		}
294
295		/**
296		* Returns whether the passed array is associative
297		*
298		* @param array $array The passed array
299		*
300		* @return bool Is the passed array associative
301		*/
302	9	private function isAssoc(array $array)
303		{
304	9	return array_keys($array) !== range(0, count($array) - 1);
305		}
306
307		/**
308		* Checks if the passed import is wanting to be merged into the parent content or relative content
309		*
310		* @param mixed $import The passed import
311		*
312		* @return bool Returns whether wanting to be a relative import
313		*/
314	8	public function isRelative($import)
315		{
316	8	$relative = (isset($import['relative'])) ? $import['relative'] : true;
317
318	8	switch (strtolower($relative)) {
319	8	case false:
		0 ignored issues – show Bug Best Practice introduced 2015-12-09 14:10 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `strtolower($relative)` of type `string` to the boolean `false`. If you are specifically checking for an empty string, consider using the more explicit `=== ''` instead. Loading history...
320	8	case 'false':
321	8	case 'no':
322	7	$value = false;
323	7	break;
324	7	case true:
		0 ignored issues – show Bug Best Practice introduced 2015-12-09 14:10 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `strtolower($relative)` of type `string` to the boolean `true`. If you are specifically checking for a non-empty string, consider using the more explicit `!== ''` instead. Loading history...
325	7	case 'yes':
326	7	case 'true':
327	7	default:
328	7	$value = true;
329	7	break;
330	8	}
331
332	8	return $value;
333		}
334
335		/**
336		* Returns the filename of the resource
337		*
338		* @return mixed The filename
339		*/
340	3	public function getFilename()
341		{
342	3	return $this->filename;
343		}
344
345		/**
346		* Returns the raw content of the resource
347		*
348		* @return array\|mixed The raw content
349		*/
350	1	public function getRawContent()
351		{
352	1	return $this->raw_content;
353		}
354		}
355

m1 / Vars

GitHub Access Token became invalid

Push — master ( 79e180...3094b9 )

FileResource B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

14 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like