Lyal\Checkr\Traits\Deleteable

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	5	1
A	getDeletePath()	0	3	1
A	setDeletePath()	0	3	1

<?php
namespace Lyal\Checkr\Traits;

trait Deleteable
{
    private $deletePath;

    /**
     * Deletes the given resource, returns a client instance
     *
     * @param null $id

Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?

     * @return \Lyal\Checkr\Client $client
     */

    public function delete($id = null) : \Lyal\Checkr\Client
    {
        $this->setAttribute('id', $id ?? $this->getAttribute('id'));

It seems like getAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->getClient()->request('delete', $this->getDeletePath());

It seems like getClient() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->getClient();
    }

    public function getDeletePath()
    {
        return $this->deletePath ?? $this->getResourceName() . '/' . $this->getAttribute('id');

It seems like getResourceName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function setDeletePath($path) : void
    {
        $this->deletePath = $path;
    }

}