Completed
Push — master ( 14b9d3...19a0e6 )
by Basil
06:41
created
core/helpers/ExportHelper.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      * @param array|ActiveQueryInterface $input
40 40
      * @param array $keys Defines which keys should be packed into the generated xlsx. The defined keys does not change the sort behavior of the generated xls.
41 41
      * @param bool $header
42
-     * @return mixed
42
+     * @return string
43 43
      * @throws Exception
44 44
      * @since 1.0.4
45 45
      */
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
     /**
134 134
      * @param array $input
135
-     * @param $delimiter
135
+     * @param string $delimiter
136 136
      * @return null|string
137 137
      * @since 1.0.4
138 138
      */
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     {
140 140
         $output = null;
141 141
         foreach ($input as $row) {
142
-            $output.= self::generateRow($row, $delimiter, '"');
142
+            $output .= self::generateRow($row, $delimiter, '"');
143 143
         }
144 144
 
145 145
         return $output;
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      */
157 157
     protected static function generateRow(array $row, $delimiter, $enclose)
158 158
     {
159
-        array_walk($row, function (&$item) use ($enclose) {
159
+        array_walk($row, function(&$item) use ($enclose) {
160 160
             if (is_bool($item)) {
161 161
                 $item = (int) $item;
162 162
             } elseif (is_null($item)) {
@@ -167,6 +167,6 @@  discard block
 block discarded – undo
167 167
             $item = $enclose.Html::encode($item).$enclose;
168 168
         });
169 169
 
170
-        return implode($delimiter, $row) . PHP_EOL;
170
+        return implode($delimiter, $row).PHP_EOL;
171 171
     }
172 172
 }
Please login to merge, or discard this patch.
core/base/ModuleReflection.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
         
225 225
         return [
226 226
             'module' => $this->module->id,
227
-            'route' => $this->module->id . '/' . $request['route'],
227
+            'route' => $this->module->id.'/'.$request['route'],
228 228
             'params' => $request['args'],
229 229
         ];
230 230
     }
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
             throw new NotFoundHttpException(sprintf("Unable to create controller '%s' for module '%s'.", $requestRoute['route'], $this->module->id));
246 246
         }
247 247
         
248
-        Yii::info('LUYA module run module "'.$this->module->id.'" route ' . $requestRoute['route'], __METHOD__);
248
+        Yii::info('LUYA module run module "'.$this->module->id.'" route '.$requestRoute['route'], __METHOD__);
249 249
         
250 250
         $this->controller = $controller[0];
251 251
         $originalController = Yii::$app->controller;
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
          *
257 257
          * @see https://github.com/luyadev/luya/issues/1730
258 258
          */
259
-        $this->controller->on(Controller::EVENT_BEFORE_ACTION, function ($event) {
259
+        $this->controller->on(Controller::EVENT_BEFORE_ACTION, function($event) {
260 260
             Yii::$app->controller = $this->controller;
261 261
         });
262 262
         /**
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
          *
265 265
          * @see https://github.com/luyadev/luya/issues/1768
266 266
          */
267
-        $this->controller->on(Controller::EVENT_AFTER_ACTION, function ($event) use ($originalController) {
267
+        $this->controller->on(Controller::EVENT_AFTER_ACTION, function($event) use ($originalController) {
268 268
             Yii::$app->controller = $originalController;
269 269
         });
270 270
         
Please login to merge, or discard this patch.
core/web/Composition.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -417,7 +417,7 @@
 block discarded – undo
417 417
      *
418 418
      * @see \ArrayAccess::offsetGet()
419 419
      * @param string $offset The key to get from the array.
420
-     * @return mixed The value for the offset key from the array.
420
+     * @return string|boolean The value for the offset key from the array.
421 421
      */
422 422
     public function offsetGet($offset)
423 423
     {
Please login to merge, or discard this patch.
core/helpers/Url.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public static function trailing($url, $slash = '/')
36 36
     {
37
-        return rtrim($url, $slash) . $slash;
37
+        return rtrim($url, $slash).$slash;
38 38
     }
39 39
 
40 40
     /**
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     public static function ensureHttp($url, $https = false)
88 88
     {
89 89
         if (!preg_match("~^(?:f|ht)tps?://~i", $url)) {
90
-            $url = ($https ? "https://" : "http://") . $url;
90
+            $url = ($https ? "https://" : "http://").$url;
91 91
         }
92 92
         
93 93
         return $url;
Please login to merge, or discard this patch.
core/web/CompositionResolver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
      * Get a value for a given resolved pattern key.
93 93
      *
94 94
      * @param string $key
95
-     * @return boolean|mixed
95
+     * @return string
96 96
      */
97 97
     public function getResolvedKeyValue($key)
98 98
     {
Please login to merge, or discard this patch.
core/traits/ApplicationTrait.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         
125 125
         // generate from `de` the locale `de_DE` or from `en` `en_EN` only if $lang is 2 chars.
126 126
         if (strlen($lang) == 2) {
127
-            return strtolower($lang) . '_' . strtoupper($lang);
127
+            return strtolower($lang).'_'.strtoupper($lang);
128 128
         }
129 129
         
130 130
         return $lang;
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     public function getWebroot()
187 187
     {
188 188
         if ($this->_webroot === null) {
189
-            $this->_webroot = realpath(realpath($this->basePath) . DIRECTORY_SEPARATOR . $this->webrootDirectory);
189
+            $this->_webroot = realpath(realpath($this->basePath).DIRECTORY_SEPARATOR.$this->webrootDirectory);
190 190
         }
191 191
         
192 192
         return $this->_webroot;
Please login to merge, or discard this patch.
core/web/filters/JsonCruftFilter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      */
59 59
     public function prependCruft($content)
60 60
     {
61
-        return $this->cruft . trim($content);
61
+        return $this->cruft.trim($content);
62 62
     }
63 63
     
64 64
     /**
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     {
69 69
         if (Yii::$app->response->format == Response::FORMAT_JSON) {
70 70
             Yii::$app->response->headers->set(self::CRUFT_HEADER_NAME, $this->getCruftLength());
71
-            Yii::$app->response->on(Response::EVENT_AFTER_PREPARE, function ($event) {
71
+            Yii::$app->response->on(Response::EVENT_AFTER_PREPARE, function($event) {
72 72
                 $event->sender->content = $this->prependCruft($event->sender->content);
73 73
             });
74 74
         }
Please login to merge, or discard this patch.
core/console/commands/ImportController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 
176 176
         foreach ($queue as $pos => $object) {
177 177
             $this->verbosePrint("Run importer object '{$object->className()}' on position '{$pos}'.", __METHOD__);
178
-            $this->verbosePrint('Module context id: ' . $object->module->id);
178
+            $this->verbosePrint('Module context id: '.$object->module->id);
179 179
             $object->run();
180 180
         }
181 181
 
@@ -185,10 +185,10 @@  discard block
 block discarded – undo
185 185
             Yii::$app->db->createCommand()->update('admin_user', ['force_reload' => 1])->execute();
186 186
         }
187 187
         
188
-        $this->output('LUYA import command (based on LUYA ' . Boot::VERSION . ')');
188
+        $this->output('LUYA import command (based on LUYA '.Boot::VERSION.')');
189 189
         
190 190
         foreach ($this->getLog() as $section => $value) {
191
-            $this->outputInfo(PHP_EOL . $section . ":");
191
+            $this->outputInfo(PHP_EOL.$section.":");
192 192
             $this->logValueToTable($value);
193 193
         }
194 194
         
Please login to merge, or discard this patch.
core/web/TelephoneLink.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
         if (!empty($this->getTelephone())) {
79 79
             // Remove all chars expect digits and "+"
80 80
             $number = preg_replace('#[^\d+]#', '', $this->getTelephone());
81
-            $href = 'tel:' . $number;
81
+            $href = 'tel:'.$number;
82 82
         }
83 83
 
84 84
         return $href;
Please login to merge, or discard this patch.