Completed
Pull Request — master (#904)
by Martin
03:02
created
core/console/commands/CrudController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     /**
17 17
      * Create a new frontend/admin module.
18 18
      * 
19
-     * @return number
19
+     * @return integer
20 20
      */
21 21
     public function actionCreate()
22 22
     {
Please login to merge, or discard this patch.
core/web/UrlManager.php 1 patch
Doc Comments   +11 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,6 +35,7 @@  discard block
 block discarded – undo
35 35
      * 
36 36
      * {@inheritDoc}
37 37
      * @see \yii\web\UrlManager::parseRequest()
38
+     * @param Request $request
38 39
      */
39 40
     public function parseRequest($request)
40 41
     {
@@ -139,7 +140,7 @@  discard block
 block discarded – undo
139 140
      * Remove the base url from a route
140 141
      * 
141 142
      * @param string $route The route where the baseUrl should be removed from.
142
-     * @return mixed
143
+     * @return string
143 144
      */
144 145
     public function removeBaseUrl($route)
145 146
     {
@@ -187,7 +188,7 @@  discard block
 block discarded – undo
187 188
      * Yii2 createUrl base implementation extends the prepand of the comosition
188 189
      * 
189 190
      * @param string|array $params An array with params or not (e.g. `['module/controller/action', 'param1' => 'value1']`)
190
-     * @param null|object $composition Composition instance to change the route behavior
191
+     * @param Composition $composition Composition instance to change the route behavior
191 192
      * @return string
192 193
      */
193 194
     public function internalCreateUrl($params, $composition = null)
@@ -234,6 +235,11 @@  discard block
 block discarded – undo
234 235
         return $url;
235 236
     }
236 237
     
238
+    /**
239
+     * @param string $route
240
+     *
241
+     * @return string
242
+     */
237 243
     private function findModuleInRoute($route)
238 244
     {
239 245
         $parts = array_values(array_filter(explode('/', $route)));
@@ -247,6 +253,9 @@  discard block
 block discarded – undo
247 253
         return false;
248 254
     }
249 255
     
256
+    /**
257
+     * @param string $url
258
+     */
250 259
     private function urlReplaceModule($url, $navItemId, \luya\web\Composition $composition)
251 260
     {
252 261
         $route = $this->removeBaseUrl($url);
Please login to merge, or discard this patch.
core/traits/CacheableTrait.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -73,6 +73,7 @@
 block discarded – undo
73 73
      * @param string $key The identifier key
74 74
      * @param mixed $value The value to store in the cache component.
75 75
      * @param \yii\caching\Dependency $dependency Dependency of the cached item. If the dependency changes, the corresponding value in the cache will be invalidated when it is fetched via get(). This parameter is ignored if $serializer is false.
76
+     * @param integer $cacheExpiration
76 77
      * @return void
77 78
      */
78 79
     public function setHasCache($key, $value, $dependency = null, $cacheExpiration = null)
Please login to merge, or discard this patch.