BaseDevCommand::saveConfig() - Code Metrics - Inspection of "add luya dev command #1737" - luyadev/luya - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 492e98...69b246 )

by Basil

created 2018-01-01 11:37 UTC

BaseDevCommand::saveConfig() A

↳ Parent: BaseDevCommand

Complexity

Conditions	3
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	4
nop	2

<?php

namespace luya\dev;

use luya\console\Command;
use luya\helpers\FileHelper;
use yii\helpers\Json;

/**
 * BaseDevCommand Controller.
 * 
 * Provides the IO for the configuration storage.
 * 
 * @author Basil Suter <[email protected]>
 */
class BaseDevCommand extends Command
{
    public $configFile = '@devenvroot/cachestorage.json';
    
    public function readConfig()
    {
        $data = FileHelper::getFileContent($this->configFile);
        
        if ($data) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return Json::decode($data);
        }
        
        return false;
    }
    
    public function getConfig($key)
    {
        $config = $this->readConfig();
        
        return isset($config[$key]) ? $config[$key] : false;
    }
    
    public function saveConfig($key, $value)
    {
        $content = $this->readConfig();
     
        if (!$content) {
            $content = [];
        }
        
        $content[$key] = $value;
        
        $save = FileHelper::writeFile($this->configFile, Json::encode($content));
        
        if (!$save) {
            return $this->outputError("Unable to find config file " . $this->configFile. ". Please create and provide Permissions.");
        }
        
        return $value;
    }
}

1			<?php
2
3			namespace luya\dev;
4
5			use luya\console\Command;
6			use luya\helpers\FileHelper;
7			use yii\helpers\Json;
8
9			/**
10			* BaseDevCommand Controller.
11			*
12			* Provides the IO for the configuration storage.
13			*
14			* @author Basil Suter <[email protected]>
15			*/
16			class BaseDevCommand extends Command
17			{
18			public $configFile = '@devenvroot/cachestorage.json';
19
20			public function readConfig()
21			{
22			$data = FileHelper::getFileContent($this->configFile);
23
24			if ($data) {
			0 ignored issues – show Bug Best Practice introduced 2018-01-01 11:40 UTC by Report Bug Copy Issue Report The expression `$data` of type `string\|false` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
25			return Json::decode($data);
26			}
27
28			return false;
29			}
30
31			public function getConfig($key)
32			{
33			$config = $this->readConfig();
34
35			return isset($config[$key]) ? $config[$key] : false;
36			}
37
38			public function saveConfig($key, $value)
39			{
40			$content = $this->readConfig();
41
42			if (!$content) {
43			$content = [];
44			}
45
46			$content[$key] = $value;
47
48			$save = FileHelper::writeFile($this->configFile, Json::encode($content));
49
50			if (!$save) {
51			return $this->outputError("Unable to find config file " . $this->configFile. ". Please create and provide Permissions.");
52			}
53
54			return $value;
55			}
56			}

luyadev / luya

Push — master ( 492e98...69b246 )

BaseDevCommand::saveConfig() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like