luyadev / luya

core/base/Boot.php

Doc Comments +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
     /**
      * Run the application based on the Sapi Name.
      *
-     * @return luya\web\Application|luya\cli\Application Application objected based on the sapi name.
+     * @return null|integer Application objected based on the sapi name.
      */
     public function run()
     {
@@ -133,7 +133,7 @@ 
     /**
      * Run Web-Application based on the provided config file.
      * 
-     * @return string|void Returns the Yii Application run() method if mock is disabled. Otherwise returns void
+     * @return integer|null Returns the Yii Application run() method if mock is disabled. Otherwise returns void
      */
     public function applicationWeb()
     {

core/console/commands/BlockController.php

Doc Comments +16 added lines, -2 removed lines

@@ -56,6 +56,11 @@ 
         ];
     }
     
+    /**
+     * @param string $type
+     * @param string $varName
+     * @param string $func
+     */
     private function getExtraVarDef($type, $varName, $func)
     {
         $info = [
@@ -72,6 +77,9 @@ 
         return false;
     }
 
+    /**
+     * @param string $type
+     */
     private function getVariableTypeOption($type)
     {
         $types = $this->getVariableTypesOptions();
@@ -79,6 +87,9 @@ 
         return $types[$type];
     }
 
+    /**
+     * @param string $type
+     */
     private function hasVariableTypeOption($type)
     {
         return array_key_exists($type, $this->getVariableTypesOptions());
@@ -292,6 +303,9 @@ 
         return $this->outputError("Error while creating file '$file'");
     }
 
+    /**
+     * @param string $prefix
+     */
     private function placeholderCreator($prefix)
     {
         $this->output(PHP_EOL.'-> Create new '.$prefix, Console::FG_YELLOW);
@@ -310,8 +324,8 @@ 
 
     /**
      * 
-     * @param unknown $prefix
-     * @param string $type 'var', 'cfg'
+     * @param string $prefix
+     * @param string $typeCast
      * @return multitype:string Ambigous <string, array>
      */
     private function varCreator($prefix, $typeCast)

Spacing +8 added lines, -8 removed lines

@@ -64,11 +64,11 @@ 
     private function getExtraVarDef($type, $varName, $func)
     {
         $info = [
-            'image-upload' => function ($varName) use ($func) { return '$this->zaaImageUpload($this->'.$func.'(\''.$varName.'\'), false, true),'; },
-            'image-array-upload' => function ($varName) use ($func) { return '$this->zaaImageArrayUpload($this->'.$func.'(\''.$varName.'\'), false, true),'; },
-            'file-upload' => function ($varName) use ($func) { return '$this->zaaFileUpload($this->'.$func.'(\''.$varName.'\'), true),'; },
-            'file-array-upload' => function ($varName) use ($func) { return '$this->zaaFileArrayUpload($this->'.$func.'(\''.$varName.'\'), true),'; },
-            'cms-page' => function ($varName) use ($func) { return 'Yii::$app->menu->findOne([\'nav_id\' => $this->'.$func.'(\''.$varName.'\', 0)]),'; },
+            'image-upload' => function($varName) use ($func) { return '$this->zaaImageUpload($this->'.$func.'(\''.$varName.'\'), false, true),'; },
+            'image-array-upload' => function($varName) use ($func) { return '$this->zaaImageArrayUpload($this->'.$func.'(\''.$varName.'\'), false, true),'; },
+            'file-upload' => function($varName) use ($func) { return '$this->zaaFileUpload($this->'.$func.'(\''.$varName.'\'), true),'; },
+            'file-array-upload' => function($varName) use ($func) { return '$this->zaaFileArrayUpload($this->'.$func.'(\''.$varName.'\'), true),'; },
+            'cms-page' => function($varName) use ($func) { return 'Yii::$app->menu->findOne([\'nav_id\' => $this->'.$func.'(\''.$varName.'\', 0)]),'; },
         ];
         
         if (array_key_exists($type, $info)) {
@@ -186,15 +186,15 @@ 
         $content .= '     * @var bool Choose whether block is a layout/container/segmnet/section block or not, Container elements will be optically displayed'.PHP_EOL;
         $content .= '     * in a different way for a better user experience. Container block will not display isDirty colorizing.'.PHP_EOL;
         $content .= '     */'.PHP_EOL;
-        $content .= '    public $isContainer = false;'.PHP_EOL . PHP_EOL;
+        $content .= '    public $isContainer = false;'.PHP_EOL.PHP_EOL;
         $content .= '    /**'.PHP_EOL;
         $content .= '     * @var bool Choose whether a block can be cached trough the caching component. Be carefull with caching container blocks.'.PHP_EOL;
         $content .= '     */'.PHP_EOL;
-        $content .= '    public $cacheEnabled = false;'.PHP_EOL . PHP_EOL;
+        $content .= '    public $cacheEnabled = false;'.PHP_EOL.PHP_EOL;
         $content .= '    /**'.PHP_EOL;
         $content .= '     * @var int The cache lifetime for this block in seconds (3600 = 1 hour), only affects when cacheEnabled is true'.PHP_EOL;
         $content .= '     */'.PHP_EOL;
-        $content .= '    public $cacheExpiration = 3600;'.PHP_EOL . PHP_EOL;
+        $content .= '    public $cacheExpiration = 3600;'.PHP_EOL.PHP_EOL;
         
         // method name
         $content .= '    public function name()'.PHP_EOL;

core/console/commands/MigrateController.php

Doc Comments +5 added lines

@@ -42,6 +42,11 @@
         }
     }
 
+    /**
+     * @param string|boolean $module
+     *
+     * @return string
+     */
     private function getModuleMigrationDirectorie($module)
     {
         if (!array_key_exists($module, $this->moduleMigrationDirectories)) {

Spacing +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
 
     protected function createMigration($class)
     {
-        $orig = $this->migrationPath . DIRECTORY_SEPARATOR . $class . '.php';
+        $orig = $this->migrationPath.DIRECTORY_SEPARATOR.$class.'.php';
         
         if (file_exists($orig)) {
             require_once $file;
@@ -71,7 +71,7 @@ 
         
         $module = $this->prompt("Could not find migration class. Please enter the module name who belongs to '$class.':");
         $dir = $this->getModuleMigrationDirectorie($module);
-        $file = $dir . DIRECTORY_SEPARATOR . $class . '.php';
+        $file = $dir.DIRECTORY_SEPARATOR.$class.'.php';
         if (file_exists($file)) {
             require_once $file;
             return new $class();

core/helpers/Url.php

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      *
      * @param string $route
      * @param array  $params
-     * @param boolean $sheme Whether to return static url or not
+     * @param boolean $scheme Whether to return static url or not
      * @todo we have to remove this method as it provides no additinal functions to the yii\helpers\url to method
      */
     public static function toManager($route, array $params = [], $scheme = false)

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
     public static function ensureHttp($url, $https = false)
     {
         if (!preg_match("~^(?:f|ht)tps?://~i", $url)) {
-            $url = ($https ? "https://" : "http://") . $url;
+            $url = ($https ? "https://" : "http://").$url;
         }
         
         return $url;

core/web/UrlManager.php

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
         if ($route === $composition) {
             $parsedRequest[0] = false;
         // now see if the composition (+1 as we add add trailing slash at the end) matches the cutted route request part, if so its composition prefix, remove it.
-        } elseif (substr($route, 0, $length+1) == $composition.'/') {
+        } elseif (substr($route, 0, $length + 1) == $composition.'/') {
             $parsedRequest[0] = substr($parsedRequest[0], $length);
         }
         // fix broken request urls
@@ -211,10 +211,10 @@ 
         $params = (array) $params;
         $url = $this->internalCreateUrl($params);
         if (strpos($url, '://') === false) {
-            $url = $this->getHostInfo() . $url;
+            $url = $this->getHostInfo().$url;
         }
         if (is_string($scheme) && ($pos = strpos($url, '://')) !== false) {
-            $url = $scheme . substr($url, $pos);
+            $url = $scheme.substr($url, $pos);
         }
         return $url;
     }

Doc Comments +11 added lines, -2 removed lines

@@ -35,6 +35,7 @@ 
      * 
      * {@inheritDoc}
      * @see \yii\web\UrlManager::parseRequest()
+     * @param Request $request
      */
     public function parseRequest($request)
     {
@@ -139,7 +140,7 @@ 
      * Remove the base url from a route
      * 
      * @param string $route The route where the baseUrl should be removed from.
-     * @return mixed
+     * @return string
      */
     public function removeBaseUrl($route)
     {
@@ -187,7 +188,7 @@ 
      * Yii2 createUrl base implementation extends the prepand of the comosition
      * 
      * @param string|array $params An array with params or not (e.g. `['module/controller/action', 'param1' => 'value1']`)
-     * @param null|object $composition Composition instance to change the route behavior
+     * @param Composition $composition Composition instance to change the route behavior
      * @return string
      */
     public function internalCreateUrl($params, $composition = null)
@@ -234,6 +235,11 @@ 
         return $url;
     }
     
+    /**
+     * @param string $route
+     *
+     * @return string
+     */
     private function findModuleInRoute($route)
     {
         $parts = array_values(array_filter(explode('/', $route)));
@@ -247,6 +253,9 @@ 
         return false;
     }
     
+    /**
+     * @param string $url
+     */
     private function urlReplaceModule($url, $navItemId, \luya\web\Composition $composition)
     {
         $route = $this->removeBaseUrl($url);

core/web/Twig.php

Spacing +11 added lines, -11 removed lines

@@ -30,38 +30,38 @@ 
     public function getFunctions()
     {
         return [
-            'menuFindAll' => function ($container, $parentNavId) {
+            'menuFindAll' => function($container, $parentNavId) {
                 return Yii::$app->menu->findAll(['container' => $container, 'parent_nav_id' => $parentNavId]);
             },
-            'menuFindOne' => function ($id) {
+            'menuFindOne' => function($id) {
                 return Yii::$app->menu->findOne(['id' => $id]);
             },
-            'menuCurrent' => function () {
+            'menuCurrent' => function() {
                 return Yii::$app->menu->current;
             },
-            'menuCurrentLevel' => function ($level) {
+            'menuCurrentLevel' => function($level) {
                 return Yii::$app->menu->getLevelCurrent($level);
             },
-            'menuLevelContainer' => function ($level) {
+            'menuLevelContainer' => function($level) {
                 return Yii::$app->menu->getLevelContainer($level);
             },
-            'asset' => function ($name) {
+            'asset' => function($name) {
                 return Yii::$app->getAssetManager()->getBundle($name);
             },
-            'filterApply' => function ($imageId, $filterIdentifier) {
+            'filterApply' => function($imageId, $filterIdentifier) {
                 return Yii::$app->storage->getImage($imageId)->applyFilter($filterIdentifier);
             },
-            'image' => function ($imageId) {
+            'image' => function($imageId) {
                 return Yii::$app->storage->getImage($imageId);
             },
-            'element' => function () {
+            'element' => function() {
                 $args = func_get_args();
                 $method = $args[0];
                 unset($args[0]);
 
                 return Yii::$app->element->run($method, $args);
             },
-            't' => function () {
+            't' => function() {
                 $args = func_get_args();
 
                 return call_user_func_array(['Yii', 't'], $args);
@@ -79,7 +79,7 @@ 
             $twig->addFunction(new Twig_SimpleFunction($name, $lambda));
         }
         
-        $twig->addFilter(new Twig_SimpleFilter('strftime', function ($timestamp, $format) {
+        $twig->addFilter(new Twig_SimpleFilter('strftime', function($timestamp, $format) {
             if (is_numeric($timestamp)) {
                 return strftime($format, $timestamp);
             }

core/console/commands/HealthController.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
         
         @chdir(Yii::getAlias('@app'));
 
-        $this->output('The directory the health commands is applying to: ' . Yii::getAlias('@app'));
+        $this->output('The directory the health commands is applying to: '.Yii::getAlias('@app'));
         
         foreach ($this->folders as $folder => $writable) {
             if (!file_exists($folder)) {

core/console/commands/ActiveWindowController.php

Spacing +3 added lines, -3 removed lines

@@ -31,13 +31,13 @@
         
         $module = Yii::$app->getModule($moduleId);
         
-        $folder = $module->basePath . DIRECTORY_SEPARATOR . 'aws';
+        $folder = $module->basePath.DIRECTORY_SEPARATOR.'aws';
         
-        $file = $folder . DIRECTORY_SEPARATOR . $className . '.php';
+        $file = $folder.DIRECTORY_SEPARATOR.$className.'.php';
         
         $content = $this->view->render('@luya/console/commands/views/aw/create.php', [
             'className' => $className,
-            'namespace' => $module->getNamespace() . '\\aws',
+            'namespace' => $module->getNamespace().'\\aws',
             'luya' => $this->getLuyaVersion(),
             'moduleId' => $moduleId,
             'alias' => Inflector::humanize(Inflector::camel2words($className)),

core/components/Mail.php

Spacing +1 added lines, -1 removed lines

@@ -168,7 +168,7 @@
                         return true;
                     } else {
                         $data = [$this->host, $this->port, $this->smtpSecure, $this->username];
-                        throw new Exception('Authentication failed ('.implode(',', $data).'): '.$smtp->getLastReply() . PHP_EOL . print_r($smtp->getError(), true));
+                        throw new Exception('Authentication failed ('.implode(',', $data).'): '.$smtp->getLastReply().PHP_EOL.print_r($smtp->getError(), true));
                     }
                 } else {
                     throw new Exception('HELO failed: '.$smtp->getLastReply());