luyadev / luya

core/console/commands/ThemeController.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use luya\theme\ThemeConfig;
 use Yii;
 use yii\helpers\Console;
-use yii\helpers\Inflector;
 
 /**
  * Command to create a new LUYA theme.

Doc Comments +2 added lines, -2 removed lines

@@ -144,7 +144,7 @@ 
     }
     
     /**
-     * @param $themeName
+     * @param string $themeName
      *
      * @return string
      */
@@ -165,7 +165,7 @@ 
     }
     
     /**
-     * @param $themeName
+     * @param string $themeName
      *
      * @return string
      */

Spacing +13 added lines, -13 removed lines

@@ -47,7 +47,7 @@ 
         
         $availableModules = implode(', ', array_column(Yii::$app->getFrontendModules(), 'id'));
         $themeLocation = $this->prompt("Enter the theme location where to generate (as path alias e.g. app, $availableModules):", ['default' => 'app']);
-        $themeLocation = '@' . ltrim($themeLocation, '@');
+        $themeLocation = '@'.ltrim($themeLocation, '@');
         
         preg_match("#^@[A-z]+#", $themeLocation, $newThemeLocation);
         
@@ -59,15 +59,15 @@ 
             }
         }
         
-        $basePath = $themeLocation . '/themes/' . $themeName;
+        $basePath = $themeLocation.'/themes/'.$themeName;
         $themeFolder = Yii::getAlias($basePath);
         
         if (file_exists($themeFolder)) {
-            return $this->outputError("The folder " . $themeFolder . " exists already.");
+            return $this->outputError("The folder ".$themeFolder." exists already.");
         }
         
-        $this->outputInfo("Theme path alias: " . $basePath);
-        $this->outputInfo("Theme real path: " . $themeFolder);
+        $this->outputInfo("Theme path alias: ".$basePath);
+        $this->outputInfo("Theme real path: ".$themeFolder);
         if (!$this->confirm("Do you want continue?")) {
             return $this->outputError('Abort by user.');
         }
@@ -81,15 +81,15 @@ 
         ];
         
         foreach ($folders as $folder) {
-            FileHelper::createDirectory($themeFolder . DIRECTORY_SEPARATOR . $folder);
+            FileHelper::createDirectory($themeFolder.DIRECTORY_SEPARATOR.$folder);
         }
         
         $contents = [
-            $themeFolder. DIRECTORY_SEPARATOR . 'theme.json' => $this->renderJson($basePath, $themeName),
-            $themeFolder. DIRECTORY_SEPARATOR . ucfirst($themeName) . 'Asset.php' => $this->renderAssetClass($themeName),
-            $themeFolder. DIRECTORY_SEPARATOR . 'resources/'. $themeName .'.css' => '',
-            $themeFolder. DIRECTORY_SEPARATOR . 'views/layouts/theme.php' => $this->renderLayout($themeName),
-            $themeFolder. DIRECTORY_SEPARATOR . 'views/cmslayouts/theme.php' => $this->renderCmsLayout($themeName),
+            $themeFolder.DIRECTORY_SEPARATOR.'theme.json' => $this->renderJson($basePath, $themeName),
+            $themeFolder.DIRECTORY_SEPARATOR.ucfirst($themeName).'Asset.php' => $this->renderAssetClass($themeName),
+            $themeFolder.DIRECTORY_SEPARATOR.'resources/'.$themeName.'.css' => '',
+            $themeFolder.DIRECTORY_SEPARATOR.'views/layouts/theme.php' => $this->renderLayout($themeName),
+            $themeFolder.DIRECTORY_SEPARATOR.'views/cmslayouts/theme.php' => $this->renderCmsLayout($themeName),
         ];
         
         foreach ($contents as $fileName => $content) {
@@ -150,7 +150,7 @@ 
      */
     private function renderAssetClass($themeName)
     {
-        $className = ucfirst($themeName) . 'Asset';
+        $className = ucfirst($themeName).'Asset';
         return "<?php
 namespace app\\themes\\{$themeName};
 
@@ -171,7 +171,7 @@ 
      */
     private function renderLayout($themeName)
     {
-        $className = ucfirst($themeName) . 'Asset';
+        $className = ucfirst($themeName).'Asset';
     
         return '<?php
 /**

core/traits/ErrorHandlerTrait.php

Doc Comments +2 added lines, -1 removed lines

@@ -67,7 +67,7 @@ 
      *
      * @param string $message The message you want to send to the error api server.
      * @param string $file The you are currently send the message (use __FILE__)
-     * @param string $line The line you want to submit (use __LINE__)
+     * @param integer $line The line you want to submit (use __LINE__)
      * @return bool|null
      */
     public function transferMessage($message, $file = __FILE__, $line = __LINE__)
@@ -105,6 +105,7 @@ 
     
     /**
      * @inheritdoc
+     * @param \Exception $exception
      */
     public function renderException($exception)
     {

Spacing +4 added lines, -4 removed lines

@@ -176,9 +176,9 @@ 
             $_file = $exception->getFile();
             $_line = $exception->getLine();
         } elseif (is_string($exception)) {
-            $_message = 'exception string: ' . $exception;
+            $_message = 'exception string: '.$exception;
         } elseif (is_array($exception)) {
-            $_message = isset($exception['message']) ? $exception['message'] : 'exception array dump: ' . print_r($exception, true);
+            $_message = isset($exception['message']) ? $exception['message'] : 'exception array dump: '.print_r($exception, true);
             $_file = isset($exception['file']) ? $exception['file'] : __FILE__;
             $_line = isset($exception['line']) ? $exception['line'] : __LINE__;
         }
@@ -249,7 +249,7 @@ 
 
         if (!empty($file)) {
             try {
-                $lineInArray = $line -1;
+                $lineInArray = $line - 1;
                 // load file from path
                 $fileInfo = file($file, FILE_IGNORE_NEW_LINES);
                 // load file if false from real path
@@ -289,7 +289,7 @@ 
             'class' => isset($item['class']) ? $item['class'] : null,
             // currently arguments wont be transmited due to large amount of informations based on base object
             //'args' => isset($item['args']) ? ArrayHelper::coverSensitiveValues($item['args'], $this->sensitiveKeys) : [],
-        ], function ($value) {
+        ], function($value) {
             return !empty($value);
         });
     }

core/helpers/ExportHelper.php

Spacing +3 added lines, -3 removed lines

@@ -139,7 +139,7 @@ 
     {
         $output = null;
         foreach ($input as $row) {
-            $output.= self::generateRow($row, $delimiter, '"');
+            $output .= self::generateRow($row, $delimiter, '"');
         }
 
         return $output;
@@ -156,7 +156,7 @@ 
      */
     protected static function generateRow(array $row, $delimiter, $enclose)
     {
-        array_walk($row, function (&$item) use ($enclose) {
+        array_walk($row, function(&$item) use ($enclose) {
             if (is_bool($item)) {
                 $item = (int) $item;
             } elseif (is_null($item)) {
@@ -171,6 +171,6 @@ 
             ], $item).$enclose;
         });
 
-        return implode($delimiter, $row) . PHP_EOL;
+        return implode($delimiter, $row).PHP_EOL;
     }
 }

Doc Comments +1 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
      * @param array|QueryInterface $input
      * @param array $keys Defines which keys should be packed into the generated xlsx. The defined keys does not change the sort behavior of the generated xls.
      * @param bool $header
-     * @return mixed
+     * @return string
      * @throws Exception
      * @since 1.0.4
      */
@@ -73,7 +73,6 @@ 
      * Generate content by rows.
      *
      * @param array $contentRows
-     * @param string $delimiter
      * @param array $keys
      * @param bool $generateHeader
      * @return array

core/theme/Theme.php

Spacing +2 added lines, -2 removed lines

@@ -74,7 +74,7 @@ 
         }
     
         $pos = strpos($viewPath, '/');
-        $rootPath = $pos === false ? $viewPath : (substr($viewPath, 0, $pos) . '/views');
+        $rootPath = $pos === false ? $viewPath : (substr($viewPath, 0, $pos).'/views');
         $this->pathMap[$rootPath] = $pathMap;
     
         $this->pathMap['@app/views'] = $pathMap;
@@ -109,7 +109,7 @@ 
      */
     public function getLayoutPath()
     {
-        return $this->viewPath . '/' . self::LAYOUTS_PATH;
+        return $this->viewPath.'/'.self::LAYOUTS_PATH;
     }
     
     /**

core/web/filters/RobotsFilter.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     {
         if (Yii::$app->request->isPost) {
             if ($this->getElapsedProcessTime() < $this->delay) {
-                throw new WhitelistedException("Robots Filter has detected an invalid Request: " . VarDumper::export(ArrayHelper::coverSensitiveValues(Yii::$app->request->post())));
+                throw new WhitelistedException("Robots Filter has detected an invalid Request: ".VarDumper::export(ArrayHelper::coverSensitiveValues(Yii::$app->request->post())));
             }
         }
         

core/theme/ThemeConfig.php

Spacing +1 added lines, -1 removed lines

@@ -140,6 +140,6 @@
      */
     public function getViewPath()
     {
-        return $this->getBasePath() . '/views';
+        return $this->getBasePath().'/views';
     }
 }

core/helpers/ObjectHelper.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         }
         
         if ($throwException) {
-            throw new Exception("The given object must be an instance of: " . implode(",", $haystack));
+            throw new Exception("The given object must be an instance of: ".implode(",", $haystack));
         }
         
         return false;
@@ -227,7 +227,7 @@ 
         } catch (InvalidParamException $e) {
         };
 
-        $staticPath = $module::staticBasePath() . DIRECTORY_SEPARATOR . 'controllers';
+        $staticPath = $module::staticBasePath().DIRECTORY_SEPARATOR.'controllers';
         if (is_dir($staticPath)) {
             foreach (FileHelper::findFiles($staticPath) as $file) {
                 $files[self::fileToName($staticPath, $file)] = $file;

core/tag/tags/LinkTag.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
     {
         if (StringHelper::startsWith($value, '//')) {
             // its an absolute url
-            $value = StringHelper::replaceFirst('//', Url::base(true) . '/', $value);
+            $value = StringHelper::replaceFirst('//', Url::base(true).'/', $value);
             $external = false;
         } elseif (StringHelper::startsWith($value, '/')) {
             // its a relative url, keep it like this

core/console/Command.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
     {
         if ($this->verbose) {
             $message = $this->printableMessage($message);
-            $this->output(!empty($section) ? $section . ': ' . $message : $message);
+            $this->output(!empty($section) ? $section.': '.$message : $message);
         }
     }
     
@@ -118,7 +118,7 @@ 
             $name = substr($name, 0, -(strlen($suffix)));
         }
     
-        return $name . $suffix;
+        return $name.$suffix;
     }
     
     /**