luya\web\jsonld\BaseThing

Complexity

Total Complexity

10

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	resolveGetterMethods()	0	19	4
A	toArray()	0	4	1
A	fields()	0	4	1
A	removeNullValues()	0	14	4

<?php

namespace luya\web\jsonld;

use yii\base\Object;
use yii\base\Arrayable;
use yii\base\ArrayableTrait;
use luya\helpers\StringHelper;

/**
 * Base Thing.
 * 
 * Every JsonLD object must implement BaseThing. Therfore BaseThing auto resolves the fields, in
 * order to provide the Arrayable::fields() methods.
 * 
 * @author Basil Suter <basil@nadar.io>
 */
abstract class BaseThing extends Object implements Arrayable, ThingInterface

The class yii\base\Object has been deprecated with message: since 2.0.13, the class name `Object` is invalid since PHP 7.2, use [[BaseObject]] instead.

{
    use ThingTrait;
    use ArrayableTrait { toArray as protected internalToArray; }
    
    /**
     * Find all getter methods.
     * 
     * @return array
     */
    public function resolveGetterMethods()
    {
    	$resolved = [];
    	$methods = get_class_methods($this);
    	
    	if (!$methods) {

The expression $methods of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

    		return [];
    	}
    	
    	foreach ($methods as $method) {
    		if (StringHelper::startsWith($method, 'get', true)) {
    			$resolved[] = lcfirst(StringHelper::replaceFirst('get', '', $method));
    		}
    	}
    	
    	asort($resolved);
    	
    	return $resolved;
    }
    
    /**
     * @inheritdoc
     */
    public function toArray(array $fields = [], array $expand = [], $recursive = true)
    {
        return $this->removeNullValues($this->internalToArray($fields, $expand, $recursive));
    }
    
    /**
     * @inheritdoc 
     */
    public function fields()
    {
    	return $this->resolveGetterMethods();
    }
    
    /**
     * Cleanup array from null values.
     * 
     * @param array $haystack
     * @return array
     */
    private function removeNullValues(array $haystack)
    {
        foreach ($haystack as $key => $value) {
            if (is_array($value)) {
                $haystack[$key] = $this->removeNullValues($value);
            }
            
            if ($value === null) {
                unset($haystack[$key]);
            }
        }
        
        return $haystack;
    }
}