TelephoneLink::setTelephone() - Code Metrics - Inspection of "TelephoneLink support for LinkButtonBlock" - luyadev/luya - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1815)

unknown

created 2018-05-31 09:26 UTC

TelephoneLink::setTelephone() A

↳ Parent: TelephoneLink

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	2
eloc	6
nc	2
nop	1

<?php

namespace luya\web;

use yii\base\BaseObject;
use yii\validators\RegularExpressionValidator;

/**
 * Telephone Link.
 *
 * Represent a {{luya\web\LinkInterface}} of an telephone link.
 *
 * @author Bennet Klarhölter <[email protected]>
 * @since 1.0.9
 */
class TelephoneLink extends BaseObject implements LinkInterface
{
    use LinkTrait;

    private $_telephone;

    /**
     * Setter method for telephone number.
     *
     * If no valid telephone is provided, not value is set.
     *
     * @param string $telephone The telephone number which should be used for the tel link.
     */
    public function setTelephone($telephone)
    {
        /**
         * Hack to support leading + sign
         * @see \luya\cms\models\NavItemPageBlockItem::rules()
         * @link https://github.com/luyadev/luya/pull/1815
         */
        $telephone = ltrim($telephone, '\\');

        $validator = new RegularExpressionValidator([
            'pattern' => '#^(?:0|\+[0-9]{2})[\d- ]+$#'
        ]);
        if ($validator->validate($telephone, $error)) {
            $this->_telephone = $telephone;
        }
    }

    /**
     * Getter method for the telephone.
     *
     * @return string Returns the telephone from the setter method, if telephone is not valid null is returned.
     */
    public function getTelephone()
    {
        return $this->_telephone;
    }

    /**
     * @inheritdoc
     */
    public function getHref()
    {
        return empty($this->getTelephone()) ?: 'tel:' . $this->getTelephone();

    }

    /**
     * @inheritdoc
     */
    public function getTarget()
    {
        return '_self';
    }
}


1			<?php
2
3			namespace luya\web;
4
5			use yii\base\BaseObject;
6			use yii\validators\RegularExpressionValidator;
7
8			/**
9			* Telephone Link.
10			*
11			* Represent a {{luya\web\LinkInterface}} of an telephone link.
12			*
13			* @author Bennet Klarhölter <[email protected]>
14			* @since 1.0.9
15			*/
16			class TelephoneLink extends BaseObject implements LinkInterface
17			{
18			use LinkTrait;
19
20			private $_telephone;
21
22			/**
23			* Setter method for telephone number.
24			*
25			* If no valid telephone is provided, not value is set.
26			*
27			* @param string $telephone The telephone number which should be used for the tel link.
28			*/
29			public function setTelephone($telephone)
30			{
31			/**
32			* Hack to support leading + sign
33			* @see \luya\cms\models\NavItemPageBlockItem::rules()
34			* @link https://github.com/luyadev/luya/pull/1815
35			*/
36			$telephone = ltrim($telephone, '\\');
37
38			$validator = new RegularExpressionValidator([
39			'pattern' => '#^(?:0\|\+[0-9]{2})[\d- ]+$#'
40			]);
41			if ($validator->validate($telephone, $error)) {
42			$this->_telephone = $telephone;
43			}
44			}
45
46			/**
47			* Getter method for the telephone.
48			*
49			* @return string Returns the telephone from the setter method, if telephone is not valid null is returned.
50			*/
51			public function getTelephone()
52			{
53			return $this->_telephone;
54			}
55
56			/**
57			* @inheritdoc
58			*/
59			public function getHref()
60			{
61			return empty($this->getTelephone()) ?: 'tel:' . $this->getTelephone();
			0 ignored issues – show Bug Compatibility introduced 2018-05-30 20:48 UTC by Report Bug Copy Issue Report The expression `empty($this->getTelephon... $this->getTelephone();` of type `boolean\|string` adds the type `boolean` to the return on line 61 which is incompatible with the return type declared by the interface `luya\web\LinkInterface::getHref` of type `string`. Loading history...
62			}
63
64			/**
65			* @inheritdoc
66			*/
67			public function getTarget()
68			{
69			return '_self';
70			}
71			}
72

luyadev / luya

Pull Request — master (#1815)

TelephoneLink::setTelephone() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like