Completed
Pull Request — master (#1727)
by Martin
02:39
created
core/web/EmailLink.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function getHref()
51 51
     {
52
-        return empty($this->getEmail()) ?: 'mailto:' . $this->getEmail();
52
+        return empty($this->getEmail()) ?: 'mailto:'.$this->getEmail();
53 53
     }
54 54
 
55 55
     /**
Please login to merge, or discard this patch.
core/web/JsonLd.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -138,8 +138,8 @@
 block discarded – undo
138 138
     protected static function registerView()
139 139
     {
140 140
         if (self::$_view === null) {
141
-            Yii::$app->view->on(View::EVENT_BEGIN_BODY, function ($event) {
142
-                echo '<script type="application/ld+json">' . Json::encode($event->sender->params) . '</script>';
141
+            Yii::$app->view->on(View::EVENT_BEGIN_BODY, function($event) {
142
+                echo '<script type="application/ld+json">'.Json::encode($event->sender->params).'</script>';
143 143
             });
144 144
                     
145 145
             self::$_view = true;
Please login to merge, or discard this patch.
core/web/jsonld/ThingTrait.php 1 patch
Doc Comments   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
     /**
30 30
      * @param string $additionalType
31
-     * @return Thing
31
+     * @return ThingTrait
32 32
      */
33 33
     public function setAdditionalType($additionalType)
34 34
     {
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
     /**
55 55
      * @param string $alternateName
56
-     * @return Thing
56
+     * @return ThingTrait
57 57
      */
58 58
     public function setAlternateName($alternateName)
59 59
     {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
     /**
80 80
      * @param string $description
81
-     * @return Thing
81
+     * @return ThingTrait
82 82
      */
83 83
     public function setDescription($description)
84 84
     {
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
     /**
106 106
      * @param string $disambiguatingDescription
107
-     * @return Thing
107
+     * @return ThingTrait
108 108
      */
109 109
     public function setDisambiguatingDescription($disambiguatingDescription)
110 110
     {
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
     /**
131 131
      * @param PropertyValue|URL|string $identifier
132
-     * @return Thing
132
+     * @return ThingTrait
133 133
      */
134 134
     public function setIdentifier($identifier)
135 135
     {
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 
156 156
     /**
157 157
      * @param ImageObject|URL $image
158
-     * @return Thing
158
+     * @return ThingTrait
159 159
      */
160 160
     public function setImage($image)
161 161
     {
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 
182 182
     /**
183 183
      * @param CreativeWork|URL $mainEntityOfPage
184
-     * @return Thing
184
+     * @return ThingTrait
185 185
      */
186 186
     public function setMainEntityOfPage($mainEntityOfPage)
187 187
     {
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
     /**
208 208
      * @param string $name
209
-     * @return Thing
209
+     * @return ThingTrait
210 210
      */
211 211
     public function setName($name)
212 212
     {
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 
232 232
     /**
233 233
      * @param Action $potentialAction
234
-     * @return Thing
234
+     * @return ThingTrait
235 235
      */
236 236
     public function setPotentialAction($potentialAction)
237 237
     {
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
     /**
259 259
      * @param URL $sameAs
260
-     * @return Thing
260
+     * @return ThingTrait
261 261
      */
262 262
     public function setSameAs($sameAs)
263 263
     {
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 
284 284
     /**
285 285
      * @param CreativeWork|Event $subjectOf
286
-     * @return Thing
286
+     * @return ThingTrait
287 287
      */
288 288
     public function setSubjectOf($subjectOf)
289 289
     {
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 
309 309
     /**
310 310
      * @param URL $url
311
-     * @return Thing
311
+     * @return ThingTrait
312 312
      */
313 313
     public function setUrl($url)
314 314
     {
Please login to merge, or discard this patch.
core/web/jsonld/BaseThing.php 1 patch
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -27,22 +27,22 @@  discard block
 block discarded – undo
27 27
      */
28 28
     public function resolveGetterMethods()
29 29
     {
30
-    	$resolved = [];
31
-    	$methods = get_class_methods($this);
30
+        $resolved = [];
31
+        $methods = get_class_methods($this);
32 32
     	
33
-    	if (!$methods) {
34
-    		return [];
35
-    	}
33
+        if (!$methods) {
34
+            return [];
35
+        }
36 36
     	
37
-    	foreach ($methods as $method) {
38
-    		if (StringHelper::startsWith($method, 'get', true)) {
39
-    			$resolved[] = lcfirst(StringHelper::replaceFirst('get', '', $method));
40
-    		}
41
-    	}
37
+        foreach ($methods as $method) {
38
+            if (StringHelper::startsWith($method, 'get', true)) {
39
+                $resolved[] = lcfirst(StringHelper::replaceFirst('get', '', $method));
40
+            }
41
+        }
42 42
     	
43
-    	asort($resolved);
43
+        asort($resolved);
44 44
     	
45
-    	return $resolved;
45
+        return $resolved;
46 46
     }
47 47
     
48 48
     /**
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      */
59 59
     public function fields()
60 60
     {
61
-    	return $this->resolveGetterMethods();
61
+        return $this->resolveGetterMethods();
62 62
     }
63 63
     
64 64
     /**
Please login to merge, or discard this patch.
core/web/jsonld/EventInterface.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -193,6 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
     /**
195 195
      * @param int $maximumAttendeeCapacity
196
+     * @return void
196 197
      */
197 198
     public function setMaximumAttendeeCapacity($maximumAttendeeCapacity);
198 199
 
@@ -302,6 +303,7 @@  discard block
 block discarded – undo
302 303
 
303 304
     /**
304 305
      * @param Event $subEvent
306
+     * @return void
305 307
      */
306 308
     public function setSubEvent($subEvent);
307 309
 
Please login to merge, or discard this patch.
core/web/Svg.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -73,27 +73,27 @@
 block discarded – undo
73 73
     public function run()
74 74
     {
75 75
         // Cache generated code
76
-        return $this->getOrSetHasCache(['svg', $this->folder, $this->file, $this->cssClass], function () {
76
+        return $this->getOrSetHasCache(['svg', $this->folder, $this->file, $this->cssClass], function() {
77 77
 
78 78
             // Check if file ends with .svg, if not add the extension
79
-            $svgFile = StringHelper::endsWith($this->file, '.svg') ? $this->file : $this->file . '.svg';
79
+            $svgFile = StringHelper::endsWith($this->file, '.svg') ? $this->file : $this->file.'.svg';
80 80
 
81 81
             // Build the full svg file path
82
-            $svgPath = $this->folder . DIRECTORY_SEPARATOR . $svgFile;
82
+            $svgPath = $this->folder.DIRECTORY_SEPARATOR.$svgFile;
83 83
 
84 84
             // Get the svg contents
85 85
             $content = FileHelper::getFileContent($svgPath);
86 86
 
87 87
             // If a cssClass string is given, add it to the <svg> tag
88 88
             if ($this->cssClass && is_string($this->cssClass)) {
89
-                $content = preg_replace('/<svg/', '<svg class="' . $this->cssClass . '"', $content);
89
+                $content = preg_replace('/<svg/', '<svg class="'.$this->cssClass.'"', $content);
90 90
             }
91 91
 
92 92
             if ($content) {
93 93
                 return $content;
94 94
             }
95 95
 
96
-            throw new Exception('Unable to access SVG File: ' . $svgPath);
96
+            throw new Exception('Unable to access SVG File: '.$svgPath);
97 97
         });
98 98
     }
99 99
 }
Please login to merge, or discard this patch.
core/helpers/ExportHelper.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
85 85
 
86 86
         $output = null;
87 87
         if ($generateHeader) {
88
-            $output.= self::generateRow($header, $delimiter, '"');
88
+            $output .= self::generateRow($header, $delimiter, '"');
89 89
         }
90 90
         foreach ($rows as $row) {
91
-            $output.= self::generateRow($row, $delimiter, '"');
91
+            $output .= self::generateRow($row, $delimiter, '"');
92 92
         }
93 93
 
94 94
         return $output;
@@ -104,13 +104,13 @@  discard block
 block discarded – undo
104 104
      */
105 105
     protected static function generateRow(array $row, $delimiter, $enclose)
106 106
     {
107
-        array_walk($row, function (&$item) use ($enclose) {
107
+        array_walk($row, function(&$item) use ($enclose) {
108 108
             if (!is_scalar($item)) {
109 109
                 $item = "array";
110 110
             }
111 111
             $item = $enclose.Html::encode($item).$enclose;
112 112
         });
113 113
         
114
-        return implode($delimiter, $row) . PHP_EOL;
114
+        return implode($delimiter, $row).PHP_EOL;
115 115
     }
116 116
 }
Please login to merge, or discard this patch.
core/traits/CacheableTrait.php 1 patch
Indentation   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -80,33 +80,33 @@
 block discarded – undo
80 80
     }
81 81
     
82 82
     /**
83
-    * Method combines both [[setHasCache()]] and [[getHasCache()]] methods to retrieve value identified by a $key,
84
-    * or to store the result of $closure execution if there is no cache available for the $key.
85
-    *
86
-    * Usage example:
87
-    *
88
-    * ```php
89
-    * use CacheableTrait;
90
-    *
91
-    * public function getTopProducts($count = 10)
92
-    * {
93
-    *     return $this->getOrSetHasCache(['top-n-products', 'n' => $count], function ($cache) use ($count) {
94
-    *         return Products::find()->mostPopular()->limit(10)->all();
95
-    *     }, 1000);
96
-    * }
97
-    * ```
98
-    *
99
-    * @param mixed $key a key identifying the value to be cached. This can be a simple string or
100
-    * a complex data structure consisting of factors representing the key.
101
-    * @param \Closure $closure the closure that will be used to generate a value to be cached.
102
-    * In case $closure returns `false`, the value will not be cached.
103
-    * @param int $duration default duration in seconds before the cache will expire. If not set,
104
-    * [[defaultDuration]] value will be used. 0 means never expire.
105
-    * @param Dependency $dependency dependency of the cached item. If the dependency changes,
106
-    * the corresponding value in the cache will be invalidated when it is fetched via [[get()]].
107
-    * This parameter is ignored if [[serializer]] is `false`.
108
-    * @return mixed result of $closure execution
109
-    */
83
+     * Method combines both [[setHasCache()]] and [[getHasCache()]] methods to retrieve value identified by a $key,
84
+     * or to store the result of $closure execution if there is no cache available for the $key.
85
+     *
86
+     * Usage example:
87
+     *
88
+     * ```php
89
+     * use CacheableTrait;
90
+     *
91
+     * public function getTopProducts($count = 10)
92
+     * {
93
+     *     return $this->getOrSetHasCache(['top-n-products', 'n' => $count], function ($cache) use ($count) {
94
+     *         return Products::find()->mostPopular()->limit(10)->all();
95
+     *     }, 1000);
96
+     * }
97
+     * ```
98
+     *
99
+     * @param mixed $key a key identifying the value to be cached. This can be a simple string or
100
+     * a complex data structure consisting of factors representing the key.
101
+     * @param \Closure $closure the closure that will be used to generate a value to be cached.
102
+     * In case $closure returns `false`, the value will not be cached.
103
+     * @param int $duration default duration in seconds before the cache will expire. If not set,
104
+     * [[defaultDuration]] value will be used. 0 means never expire.
105
+     * @param Dependency $dependency dependency of the cached item. If the dependency changes,
106
+     * the corresponding value in the cache will be invalidated when it is fetched via [[get()]].
107
+     * This parameter is ignored if [[serializer]] is `false`.
108
+     * @return mixed result of $closure execution
109
+     */
110 110
     public function getOrSetHasCache($key, \Closure $closure, $duration = null, $dependency = null)
111 111
     {
112 112
         if (($value = $this->getHasCache($key)) !== false) {
Please login to merge, or discard this patch.