Completed
Pull Request — master (#1997)
by Basil
02:41
created
core/console/Controller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
      * If a message is not a string, it will return var export to generate
47 47
      * a returnable string from a message.
48 48
      * 
49
-     * @param mixed $message
49
+     * @param string $message
50 50
      * @return string
51 51
      * @since 1.0.22
52 52
      */
Please login to merge, or discard this patch.
core/console/Command.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     {
41 41
         if ($this->verbose) {
42 42
             $message = $this->printableMessage($message);
43
-            $this->output(!empty($section) ? $section . ': ' . $message : $message);
43
+            $this->output(!empty($section) ? $section.': '.$message : $message);
44 44
         }
45 45
     }
46 46
     
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
             $name = substr($name, 0, -(strlen($suffix)));
119 119
         }
120 120
     
121
-        return $name . $suffix;
121
+        return $name.$suffix;
122 122
     }
123 123
     
124 124
     /**
Please login to merge, or discard this patch.
core/Config.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@
 block discarded – undo
188 188
      *
189 189
      * @param string $id The id of the component
190 190
      * @param string|array $config The configuration for the given module. If a string is given this will be taken as `class` property.
191
-     * @param string $runtime The runtime for the component: all, web or console
191
+     * @param integer $runtime The runtime for the component: all, web or console
192 192
      * @return ConfigDefinition
193 193
      */
194 194
     public function component($id, $config, $runtime = self::RUNTIME_ALL)
Please login to merge, or discard this patch.
core/widgets/SubmitButtonWidget.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -89,10 +89,10 @@
 block discarded – undo
89 89
             $(document).on('beforeSubmit', function (e) {                
90 90
                 var buttonSelector = $(e.target).find(':submit');
91 91
                 var formSelector = $(e.target);
92
-                if (formSelector.find('div." . $this->_activeForm->errorCssClass . "').length === 0) {
92
+                if (formSelector.find('div." . $this->_activeForm->errorCssClass."').length === 0) {
93 93
                     buttonSelector.attr('disabled', true);
94
-                    var newButtonLabel = '" . $this->pushed . "';
95
-                    if (newButtonLabel) { buttonSelector.html('" . $this->pushed . "'); }                            
94
+                    var newButtonLabel = '" . $this->pushed."';
95
+                    if (newButtonLabel) { buttonSelector.html('" . $this->pushed."'); }                            
96 96
                 }
97 97
                 return true;});");
98 98
         } else {
Please login to merge, or discard this patch.
core/helpers/Url.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public static function trailing($url, $slash = '/')
36 36
     {
37
-        return rtrim($url, $slash) . $slash;
37
+        return rtrim($url, $slash).$slash;
38 38
     }
39 39
     
40 40
     /**
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     public static function ensureHttp($url, $https = false)
88 88
     {
89 89
         if (!preg_match("~^(?:f|ht)tps?://~i", $url)) {
90
-            $url = ($https ? "https://" : "http://") . $url;
90
+            $url = ($https ? "https://" : "http://").$url;
91 91
         }
92 92
         
93 93
         return $url;
@@ -156,14 +156,14 @@  discard block
 block discarded – undo
156 156
         if (StringHelper::contains('?', $url)) {
157 157
             // seperator already existing
158 158
             if (StringHelper::endsWith($url, '&') || StringHelper::endsWith($url, '?')) {
159
-                return $url . $append;
159
+                return $url.$append;
160 160
             }
161 161
 
162 162
             // add seperator
163
-            return $url . '&' . $append;
163
+            return $url.'&'.$append;
164 164
         }
165 165
         
166 166
         // use ?
167
-        return $url . '?' . $append;
167
+        return $url.'?'.$append;
168 168
     }
169 169
 }
Please login to merge, or discard this patch.
core/texttospeech/TextToSpeechWidget.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@
 block discarded – undo
139 139
             var tts = $.textToSpeech({$config});
140 140
             var playButton = $('{$this->playButtonSelector}');
141 141
             var pauseButton = $('{$this->pauseButtonSelector}');
142
-            " . ($this->targetSelector ? "tts.setText($('{$this->targetSelector}').text());" : "") . "
142
+            ".($this->targetSelector ? "tts.setText($('{$this->targetSelector}').text());" : "")."
143 143
             var applyPlayClasses = function () {
144 144
                 playButton.addClass('{$this->playButtonActiveClass}');
145 145
                 pauseButton.removeClass('{$this->pauseButtonActiveClass}');
Please login to merge, or discard this patch.
core/theme/ThemeManager.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use luya\base\PackageConfig;
6 6
 use luya\Exception;
7
-use luya\helpers\FileHelper;
8 7
 use luya\helpers\Json;
9 8
 use Yii;
10 9
 use yii\base\InvalidArgumentException;
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -53,13 +53,13 @@  discard block
 block discarded – undo
53 53
         if (strpos($basePath, '@') === 0) {
54 54
             $dir = Yii::getAlias($basePath);
55 55
         } elseif (strpos($basePath, '/') !== 0) {
56
-            $dir = $basePath = Yii::$app->basePath . DIRECTORY_SEPARATOR . $basePath;
56
+            $dir = $basePath = Yii::$app->basePath.DIRECTORY_SEPARATOR.$basePath;
57 57
         } else {
58 58
             $dir = $basePath;
59 59
         }
60 60
         
61 61
         if (!is_dir($dir) || !is_readable($dir)) {
62
-            throw new Exception('Theme directory not exists or readable: ' . $dir);
62
+            throw new Exception('Theme directory not exists or readable: '.$dir);
63 63
         }
64 64
         
65 65
         // $basePath is an absolute path = /VENDOR/NAME/theme.json
@@ -68,9 +68,9 @@  discard block
 block discarded – undo
68 68
             // if basePath is the theme file itself and existing process:
69 69
             $basePath = pathinfo($basePath, PATHINFO_DIRNAME);
70 70
         } else {
71
-            $themeFile = $dir . DIRECTORY_SEPARATOR . 'theme.json';
71
+            $themeFile = $dir.DIRECTORY_SEPARATOR.'theme.json';
72 72
             if (!file_exists($themeFile)) {
73
-                throw new InvalidConfigException('Theme config file missing at: ' . $themeFile);
73
+                throw new InvalidConfigException('Theme config file missing at: '.$themeFile);
74 74
             }
75 75
         }
76 76
         
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
         
173 173
         if (file_exists(Yii::getAlias('@app/themes'))) {
174 174
             foreach (glob(Yii::getAlias('@app/themes/*')) as $dirPath) {
175
-                $themeDefinitions[] = "@app/themes/" . basename($dirPath);
175
+                $themeDefinitions[] = "@app/themes/".basename($dirPath);
176 176
             }
177 177
         }
178 178
         
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
         
219 219
         $this->_themes[$basePath] = $themeConfig;
220 220
         
221
-        Yii::setAlias('@' . basename($basePath) . 'Theme', $basePath);
221
+        Yii::setAlias('@'.basename($basePath).'Theme', $basePath);
222 222
     }
223 223
     
224 224
     /**
Please login to merge, or discard this patch.