Completed
Pull Request — master (#975)
by Martin
03:40
created
core/base/Boot.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     /**
101 101
      * Run the application based on the Sapi Name.
102 102
      *
103
-     * @return luya\web\Application|luya\cli\Application Application objected based on the sapi name.
103
+     * @return null|integer Application objected based on the sapi name.
104 104
      */
105 105
     public function run()
106 106
     {
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
     /**
134 134
      * Run Web-Application based on the provided config file.
135 135
      * 
136
-     * @return string|void Returns the Yii Application run() method if mock is disabled. Otherwise returns void
136
+     * @return integer|null Returns the Yii Application run() method if mock is disabled. Otherwise returns void
137 137
      */
138 138
     public function applicationWeb()
139 139
     {
Please login to merge, or discard this patch.
core/console/commands/BlockController.php 1 patch
Doc Comments   +16 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,6 +56,11 @@  discard block
 block discarded – undo
56 56
         ];
57 57
     }
58 58
     
59
+    /**
60
+     * @param string $type
61
+     * @param string $varName
62
+     * @param string $func
63
+     */
59 64
     private function getExtraVarDef($type, $varName, $func)
60 65
     {
61 66
         $info = [
@@ -72,6 +77,9 @@  discard block
 block discarded – undo
72 77
         return false;
73 78
     }
74 79
 
80
+    /**
81
+     * @param string $type
82
+     */
75 83
     private function getVariableTypeOption($type)
76 84
     {
77 85
         $types = $this->getVariableTypesOptions();
@@ -79,6 +87,9 @@  discard block
 block discarded – undo
79 87
         return $types[$type];
80 88
     }
81 89
 
90
+    /**
91
+     * @param string $type
92
+     */
82 93
     private function hasVariableTypeOption($type)
83 94
     {
84 95
         return array_key_exists($type, $this->getVariableTypesOptions());
@@ -292,6 +303,9 @@  discard block
 block discarded – undo
292 303
         return $this->outputError("Error while creating file '$file'");
293 304
     }
294 305
 
306
+    /**
307
+     * @param string $prefix
308
+     */
295 309
     private function placeholderCreator($prefix)
296 310
     {
297 311
         $this->output(PHP_EOL.'-> Create new '.$prefix, Console::FG_YELLOW);
@@ -310,8 +324,8 @@  discard block
 block discarded – undo
310 324
 
311 325
     /**
312 326
      * 
313
-     * @param unknown $prefix
314
-     * @param string $type 'var', 'cfg'
327
+     * @param string $prefix
328
+     * @param string $typeCast
315 329
      * @return multitype:string Ambigous <string, array>
316 330
      */
317 331
     private function varCreator($prefix, $typeCast)
Please login to merge, or discard this patch.
core/console/commands/MigrateController.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -42,6 +42,11 @@
 block discarded – undo
42 42
         }
43 43
     }
44 44
 
45
+    /**
46
+     * @param string|boolean $module
47
+     *
48
+     * @return string
49
+     */
45 50
     private function getModuleMigrationDirectorie($module)
46 51
     {
47 52
         if (!array_key_exists($module, $this->moduleMigrationDirectories)) {
Please login to merge, or discard this patch.
core/helpers/Url.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
      *
38 38
      * @param string $route
39 39
      * @param array  $params
40
-     * @param boolean $sheme Whether to return static url or not
40
+     * @param boolean $scheme Whether to return static url or not
41 41
      * @todo we have to remove this method as it provides no additinal functions to the yii\helpers\url to method
42 42
      */
43 43
     public static function toManager($route, array $params = [], $scheme = false)
Please login to merge, or discard this patch.
core/console/Importer.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,6 @@
 block discarded – undo
71 71
      * $this->addLog('block', 'new block <ID> have been found and added to database');
72 72
      * ```
73 73
      * 
74
-     * @param string $section
75 74
      * @param string $value
76 75
 	 * @todo trigger deprecated section call
77 76
      */
Please login to merge, or discard this patch.
core/web/UrlManager.php 1 patch
Doc Comments   +11 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,6 +35,7 @@  discard block
 block discarded – undo
35 35
      * 
36 36
      * {@inheritDoc}
37 37
      * @see \yii\web\UrlManager::parseRequest()
38
+     * @param Request $request
38 39
      */
39 40
     public function parseRequest($request)
40 41
     {
@@ -139,7 +140,7 @@  discard block
 block discarded – undo
139 140
      * Remove the base url from a route
140 141
      * 
141 142
      * @param string $route The route where the baseUrl should be removed from.
142
-     * @return mixed
143
+     * @return string
143 144
      */
144 145
     public function removeBaseUrl($route)
145 146
     {
@@ -187,7 +188,7 @@  discard block
 block discarded – undo
187 188
      * Yii2 createUrl base implementation extends the prepand of the comosition
188 189
      * 
189 190
      * @param string|array $params An array with params or not (e.g. `['module/controller/action', 'param1' => 'value1']`)
190
-     * @param null|object $composition Composition instance to change the route behavior
191
+     * @param Composition $composition Composition instance to change the route behavior
191 192
      * @return string
192 193
      */
193 194
     public function internalCreateUrl($params, $composition = null)
@@ -234,6 +235,11 @@  discard block
 block discarded – undo
234 235
         return $url;
235 236
     }
236 237
     
238
+    /**
239
+     * @param string $route
240
+     *
241
+     * @return string
242
+     */
237 243
     private function findModuleInRoute($route)
238 244
     {
239 245
         $parts = array_values(array_filter(explode('/', $route)));
@@ -247,6 +253,9 @@  discard block
 block discarded – undo
247 253
         return false;
248 254
     }
249 255
     
256
+    /**
257
+     * @param string $url
258
+     */
250 259
     private function urlReplaceModule($url, $navItemId, \luya\web\Composition $composition)
251 260
     {
252 261
         $route = $this->removeBaseUrl($url);
Please login to merge, or discard this patch.
core/traits/CacheableTrait.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -73,6 +73,7 @@
 block discarded – undo
73 73
      * @param string $key The identifier key
74 74
      * @param mixed $value The value to store in the cache component.
75 75
      * @param \yii\caching\Dependency $dependency Dependency of the cached item. If the dependency changes, the corresponding value in the cache will be invalidated when it is fetched via get(). This parameter is ignored if $serializer is false.
76
+     * @param integer $cacheExpiration
76 77
      * @return void
77 78
      */
78 79
     public function setHasCache($key, $value, $dependency = null, $cacheExpiration = null)
Please login to merge, or discard this patch.