Application::handleRequest() - Code Metrics - Inspection of "removed beta and alpha changelog items" - luyadev/luya - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5fc968...929a6e )

by Basil

created 2018-03-19 09:59 UTC

Application::handleRequest() A

↳ Parent: Project

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	3
eloc	4
nc	2
nop	1

<?php

namespace luya\web;

use luya\traits\ApplicationTrait;
use yii\web\ForbiddenHttpException;

/**
 * Luya Web Application.
 *
 *
 * @property \luya\cms\Menu $menu Menu component in order to build navigation from CMS module.
 * @property \luya\admin\storage\BaseFileSystemStorage $storage Storage component for reading, saving and holding files from the Admin module.
 * @property \luya\web\Composition $composition Composition component.
 * @property \luya\web\Element $element The element component.
 * @property \luya\web\View $view The view component.
 * @property \luya\web\Request $request The request component.
 * @property \luya\web\ErrorHandler $errorHandler The error handler component.
 *
 * @author Basil Suter <[email protected]>
 * @since 1.0.0
 */
class Application extends \yii\web\Application
{
    use ApplicationTrait;

    /**
     * @inheritdoc
     */
    public function handleRequest($request)
    {
        if ($this->ensureSecureConnection && !$request->isSecureConnection) {
            throw new ForbiddenHttpException("Insecure connection is not allowed.");
        }
        
        return parent::handleRequest($request);

    }
    
    /**
     * @inheritdoc
     */
    public function coreComponents()
    {
        return array_merge($this->luyaCoreComponents(), [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'request' => ['class' => 'luya\web\Request'],
            'errorHandler' => ['class' => 'luya\web\ErrorHandler'],
            'urlManager' => ['class' => 'luya\web\UrlManager'],
            'view' => ['class' => 'luya\web\View'],
            'element' => ['class' => 'luya\web\Element'],
            'composition' => ['class' => 'luya\web\Composition'],
            'assetManager' => [
                'class' => 'luya\web\AssetManager',
                'forceCopy' => YII_DEBUG,
                'appendTimestamp' => !YII_DEBUG,
            ],
        ]);
    }
}


1			<?php
2
3			namespace luya\web;
4
5			use luya\traits\ApplicationTrait;
6			use yii\web\ForbiddenHttpException;
7
8			/**
9			* Luya Web Application.
10			*
11			*
12			* @property \luya\cms\Menu $menu Menu component in order to build navigation from CMS module.
13			* @property \luya\admin\storage\BaseFileSystemStorage $storage Storage component for reading, saving and holding files from the Admin module.
14			* @property \luya\web\Composition $composition Composition component.
15			* @property \luya\web\Element $element The element component.
16			* @property \luya\web\View $view The view component.
17			* @property \luya\web\Request $request The request component.
18			* @property \luya\web\ErrorHandler $errorHandler The error handler component.
19			*
20			* @author Basil Suter <[email protected]>
21			* @since 1.0.0
22			*/
23			class Application extends \yii\web\Application
24			{
25			use ApplicationTrait;
26
27			/**
28			* @inheritdoc
29			*/
30			public function handleRequest($request)
31			{
32			if ($this->ensureSecureConnection && !$request->isSecureConnection) {
33			throw new ForbiddenHttpException("Insecure connection is not allowed.");
34			}
35
36			return parent::handleRequest($request);
			0 ignored issues – show Compatibility introduced 2018-03-19 10:02 UTC by Report Bug Copy Issue Report `$request` of type `object<yii\base\Request>` is not a sub-type of `object<yii\web\Request>`. It seems like you assume a child class of the class `yii\base\Request` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
37			}
38
39			/**
40			* @inheritdoc
41			*/
42			public function coreComponents()
43			{
44			return array_merge($this->luyaCoreComponents(), [
			0 ignored issues – show Bug Best Practice introduced 2017-03-21 14:10 UTC by Report Bug Copy Issue Report The return type of `return array_merge($this...tamp' => !YII_DEBUG)));` (`array<string,array<string,string\|boolean>>`) is incompatible with the return type of the parent method `yii\web\Application::coreComponents` of type `array<string,array<string,string>>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
45			'request' => ['class' => 'luya\web\Request'],
46			'errorHandler' => ['class' => 'luya\web\ErrorHandler'],
47			'urlManager' => ['class' => 'luya\web\UrlManager'],
48			'view' => ['class' => 'luya\web\View'],
49			'element' => ['class' => 'luya\web\Element'],
50			'composition' => ['class' => 'luya\web\Composition'],
51			'assetManager' => [
52			'class' => 'luya\web\AssetManager',
53			'forceCopy' => YII_DEBUG,
54			'appendTimestamp' => !YII_DEBUG,
55			],
56			]);
57			}
58			}
59

luyadev / luya

Push — master ( 5fc968...929a6e )

Application::handleRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like