luyadev / luya

envs/dev/properties/TestProperty.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace app\properties;
 
-use Yii;
-
 class TestProperty extends \admin\base\Property
 {
     public function init()

modules/admin/apis/StorageController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Yii;
 use Exception;
 use admin\helpers\Storage;
-use admin\models\StorageImage;
 use admin\models\StorageFile;
 use admin\models\StorageFolder;
 use admin\Module;

Indentation +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * @todo http://php.net/manual/en/features.file-upload.errors.php
      *
      * @return array|json Key represents the uploaded file name, value represents the id in the database.
-    */
+     */
     public function actionFilesUpload()
     {
         foreach ($_FILES as $k => $file) {

modules/admin/base/Filter.php

Doc Comments +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
     /**
      * Get an array with all the effect param options, based on the effect params defintion.
      *
-     * @param array $effectParamsDefintion
+     * @param array $effectParams
      *
      * @throws Exception When the vars key does not exists in the effect definition.
      *

modules/admin/base/RestVerbController.php

Doc Comments +3 added lines

@@ -48,6 +48,9 @@
         $this->throwException(__METHOD__);
     }
 
+    /**
+     * @param string $method
+     */
     private function throwException($method)
     {
         throw new \Exception('The action '.$method.' is not yet supported.');

modules/admin/components/Auth.php

Doc Comments +4 added lines, -3 removed lines

@@ -25,6 +25,10 @@ 
         return ($create + $update + $delete);
     }
 
+    /**
+     * @param integer $type
+     * @param integer $permissionWeight
+     */
     public function permissionVerify($type, $permissionWeight)
     {
         $numbers = [];
@@ -76,9 +80,6 @@ 
     /**
      * see if the user id matches against the moduleName, controllerName, actionName inside of the rights database.
      *
-     * @param string $moduleName     Module Name
-     * @param string $controllerName The name of the controller without suffix "Controller"
-     * @param string $actionName     The name of the action without prefix "action";
      *
      * @return bool
      */

modules/admin/components/StorageContainer.php

Doc Comments +4 added lines, -1 removed lines

@@ -417,7 +417,7 @@ 
     /**
      * 
      * @param unknown $folderName
-     * @param number $parentFolderId
+     * @param integer $parentFolderId
      * @return boolean
      */
     public function addFolder($folderName, $parentFolderId = 0)
@@ -453,6 +453,9 @@ 
         return (isset($this->filtersArray[$filterIdentifier])) ? $this->filtersArray[$filterIdentifier] : false;
     }
     
+    /**
+     * @param string $key
+     */
     protected function getQueryCacheHelper(\yii\db\Query $query, $key)
     {
         $data = $this->getHasCache($key);

Spacing +4 added lines, -4 removed lines

@@ -110,7 +110,7 @@ 
     public function getHttpPath()
     {
         if ($this->_httpPath === null) {
-            $this->_httpPath = $this->request->baseUrl . '/storage';
+            $this->_httpPath = $this->request->baseUrl.'/storage';
         }
         
         return $this->_httpPath;
@@ -123,7 +123,7 @@ 
     public function getServerPath()
     {
         if ($this->_serverPath === null) {
-            $this->_serverPath = Yii::getAlias('@webroot') . '/storage';
+            $this->_serverPath = Yii::getAlias('@webroot').'/storage';
         }
         
         return $this->_serverPath;
@@ -230,7 +230,7 @@ 
         
         $newName = implode([$baseName.'_'.$fileHashName, $fileInfo->extension], '.');
         
-        $savePath = $this->serverPath . '/' . $newName;
+        $savePath = $this->serverPath.'/'.$newName;
         
         if (is_uploaded_file($fileSource)) {
             if (!@move_uploaded_file($fileSource, $savePath)) {
@@ -322,7 +322,7 @@ 
             $image = $imagine->open($fileQuery->serverSource);
             
             $fileName = $filterId.'_'.$fileQuery->systemFileName;
-            $fileSavePath = $this->serverPath . '/' . $fileName;
+            $fileSavePath = $this->serverPath.'/'.$fileName;
             if (empty($filterId)) {
                 $save = $image->save($fileSavePath);
             } else {

modules/admin/controllers/DefaultController.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace admin\controllers;
 
 use Yii;
-use admin\Module;
 use luya\helpers\Url;
 use yii\helpers\Json;
 

Spacing +2 added lines, -2 removed lines

@@ -14,10 +14,10 @@
     public function actionIndex()
     {
         // register auth token
-        $this->view->registerJs("var authToken='".Yii::$app->adminuser->identity->authToken ."';", \luya\web\View::POS_HEAD);
+        $this->view->registerJs("var authToken='".Yii::$app->adminuser->identity->authToken."';", \luya\web\View::POS_HEAD);
         $this->view->registerJs("var homeUrl='".Url::home(true)."';", \luya\web\View::POS_HEAD);
         // register admin js translations from module
-        $this->view->registerJs('var i18n=' . Json::encode($this->module->jsTranslations), \luya\web\View::POS_HEAD);
+        $this->view->registerJs('var i18n='.Json::encode($this->module->jsTranslations), \luya\web\View::POS_HEAD);
         // Init ElementQueries after page load
         // $this->view->registerJs('setTimeout( function() {ElementQueries.listen(); ElementQueries.init();}, 1500);', \luya\web\View::POS_LOAD);
         // return and render index view file

modules/admin/helpers/Storage.php

Doc Comments +3 added lines, -2 removed lines

@@ -29,6 +29,7 @@ 
      * So you need to use the "%u" formatter of sprintf() or printf() to get the string representation of the unsigned crc32() checksum in decimal format.
      *
      * @var string
+     * @param string $fileName
      */
     public static function createFileHash($fileName)
     {
@@ -133,7 +134,7 @@ 
     /**
      * 
      * @param array $fileArray Its an entry of the files array like $_FILEs['logo_image'];
-     * @param number $toFolder
+     * @param integer $toFolder
      * @param string $isHidden
      */
     public static function uploadFromFileArray(array $fileArray, $toFolder = 0, $isHidden = false)
@@ -194,7 +195,7 @@ 
     /**
      * 
      * @param array $filesArray Use $_FILES
-     * @param number $toFolder
+     * @param integer $toFolder
      * @param string $isHidden
      * 
      * @todo what happen if $files does have more then one entry, as the response is limit to 1

Spacing +2 added lines, -2 removed lines

@@ -103,8 +103,8 @@
         $height = 0;
         
         if (isset($dimensions[0]) && isset($dimensions[1])) {
-            $width = (int)$dimensions[0];
-            $height = (int)$dimensions[1];
+            $width = (int) $dimensions[0];
+            $height = (int) $dimensions[1];
         } elseif ($throwException) {
             throw new Exception("Unable to determine the resoltuions of the file $filePath.");
         }

modules/admin/image/Item.php

Doc Comments +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
     
     /**
      * 
-     * @return string|boolean
+     * @return string|false
      */
     public function getSource()
     {
@@ -53,7 +53,7 @@ 
     
     /**
      * 
-     * @return string|boolean
+     * @return string|false
      */
     public function getServerSource()
     {

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
             $apply = Yii::$app->storage->addImage($this->getFileId(), $this->getFilterId());
         }
         
-        return ($this->getFile()) ? Yii::$app->storage->httpPath . '/' . $this->getFilterId() . '_' . $this->getFile()->getSystemFileName() : false;
+        return ($this->getFile()) ? Yii::$app->storage->httpPath.'/'.$this->getFilterId().'_'.$this->getFile()->getSystemFileName() : false;
     }
     
     /**
@@ -57,7 +57,7 @@ 
      */
     public function getServerSource()
     {
-        return ($this->getFile()) ? Yii::$app->storage->serverPath . '/' . $this->getFilterId() . '_' . $this->getFile()->getSystemFileName() : false;
+        return ($this->getFile()) ? Yii::$app->storage->serverPath.'/'.$this->getFilterId().'_'.$this->getFile()->getSystemFileName() : false;
     }
     
     /**