luyadev / luya

core/web/Composition.php

Doc Comments +1 added lines, -1 removed lines

@@ -398,7 +398,7 @@
      *
      * @see ArrayAccess::offsetGet()
      * @param string $offset The key to get from the array.
-     * @return mixed The value for the offset key from the array.
+     * @return string|boolean The value for the offset key from the array.
      */
     public function offsetGet($offset)
     {

core/web/UrlManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
      * Remove the base url from a route
      *
      * @param string $route The route where the baseUrl should be removed from.
-     * @return mixed
+     * @return string
      */
     public function removeBaseUrl($route)
     {

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
         $length = strlen($composition);
         $route = $parsedRequest[0];
         
-        if (substr($route, 0, $length+1) == $composition.'/') {
+        if (substr($route, 0, $length + 1) == $composition.'/') {
             $parsedRequest[0] = substr($parsedRequest[0], $length);
         }
         
@@ -302,10 +302,10 @@ 
         $params = (array) $params;
         $url = $this->internalCreateUrl($params);
         if (strpos($url, '://') === false) {
-            $url = $this->getHostInfo() . $url;
+            $url = $this->getHostInfo().$url;
         }
         if (is_string($scheme) && ($pos = strpos($url, '://')) !== false) {
-            $url = $scheme . substr($url, $pos);
+            $url = $scheme.substr($url, $pos);
         }
         return $url;
     }

core/base/ModuleReflection.php

Spacing +2 added lines, -2 removed lines

@@ -190,7 +190,7 @@ 
         
         return [
             'module' => $this->module->id,
-            'route' => $this->module->id . '/' . $request['route'],
+            'route' => $this->module->id.'/'.$request['route'],
             'params' => $request['args'],
         ];
     }
@@ -212,7 +212,7 @@ 
             throw new NotFoundHttpException(sprintf("Unable to create controller '%s' for module '%s'.", $requestRoute['route'], $this->module->id));
         }
         
-        Yii::info('LUYA module run module "'.$this->module->id.'" route ' . $requestRoute['route'], __METHOD__);
+        Yii::info('LUYA module run module "'.$this->module->id.'" route '.$requestRoute['route'], __METHOD__);
         
         /**
          * issue: https://github.com/zephir/luya/issues/754

core/base/Widget.php

Spacing +1 added lines, -1 removed lines

@@ -39,6 +39,6 @@
         // get reflection
         $class = new ReflectionClass($this);
         // get path with alias
-        return '@app/views/widgets/' . Inflector::camel2id($class->getShortName());
+        return '@app/views/widgets/'.Inflector::camel2id($class->getShortName());
     }
 }

core/web/Twig.php

Spacing +11 added lines, -11 removed lines

@@ -41,38 +41,38 @@ 
     public function getFunctions()
     {
         return [
-            'menuFindAll' => function ($container, $parentNavId) {
+            'menuFindAll' => function($container, $parentNavId) {
                 return Yii::$app->menu->findAll(['container' => $container, 'parent_nav_id' => $parentNavId]);
             },
-            'menuFindOne' => function ($id) {
+            'menuFindOne' => function($id) {
                 return Yii::$app->menu->findOne(['id' => $id]);
             },
-            'menuCurrent' => function () {
+            'menuCurrent' => function() {
                 return Yii::$app->menu->current;
             },
-            'menuCurrentLevel' => function ($level) {
+            'menuCurrentLevel' => function($level) {
                 return Yii::$app->menu->getLevelCurrent($level);
             },
-            'menuLevelContainer' => function ($level) {
+            'menuLevelContainer' => function($level) {
                 return Yii::$app->menu->getLevelContainer($level);
             },
-            'asset' => function ($name) {
+            'asset' => function($name) {
                 return Yii::$app->getAssetManager()->getBundle($name);
             },
-            'filterApply' => function ($imageId, $filterIdentifier) {
+            'filterApply' => function($imageId, $filterIdentifier) {
                 return Yii::$app->storage->getImage($imageId)->applyFilter($filterIdentifier);
             },
-            'image' => function ($imageId) {
+            'image' => function($imageId) {
                 return Yii::$app->storage->getImage($imageId);
             },
-            'element' => function () {
+            'element' => function() {
                 $args = func_get_args();
                 $method = $args[0];
                 unset($args[0]);
 
                 return Yii::$app->element->getElement($method, $args);
             },
-            't' => function () {
+            't' => function() {
                 $args = func_get_args();
 
                 return call_user_func_array(['Yii', 't'], $args);
@@ -111,7 +111,7 @@ 
             $twig->addFunction(new Twig_SimpleFunction($name, $lambda));
         }
         
-        $twig->addFilter(new Twig_SimpleFilter('strftime', function ($timestamp, $format) {
+        $twig->addFilter(new Twig_SimpleFilter('strftime', function($timestamp, $format) {
             if (is_numeric($timestamp)) {
                 return strftime($format, $timestamp);
             }

core/web/Element.php

Spacing +2 added lines, -2 removed lines

@@ -275,13 +275,13 @@
     {
         if ($this->renderEngine == 'php') {
             $view = new View();
-            return $view->renderPhpFile(rtrim($this->getFolder(), DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . FileHelper::ensureExtension($file, 'php'), $args);
+            return $view->renderPhpFile(rtrim($this->getFolder(), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.FileHelper::ensureExtension($file, 'php'), $args);
         } elseif ($this->renderEngine == 'twig') {
             // @deprecated 1.0.0-RC2 Marked as deprecated and will be removed on 1.0.0 release.
             $twig = Yii::$app->twig->env(new Twig_Loader_Filesystem($this->getFolder()));
             return $twig->render(FileHelper::ensureExtension($file, 'twig'), $args);
         }
         
-        throw new Exception('Not supported render engine: ' . $this->renderEngine);
+        throw new Exception('Not supported render engine: '.$this->renderEngine);
     }
 }

core/TagParser.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     {
         if (!is_object($this->tags[$tag])) {
             $this->tags[$tag] = Yii::createObject($this->tags[$tag]);
-            Yii::trace('tag parser object generated for:'. $tag, __CLASS__);
+            Yii::trace('tag parser object generated for:'.$tag, __CLASS__);
         }
     }
     

core/console/commands/HealthController.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         
         @chdir(Yii::getAlias('@app'));
 
-        $this->output('The directory the health commands is applying to: ' . Yii::getAlias('@app'));
+        $this->output('The directory the health commands is applying to: '.Yii::getAlias('@app'));
         
         foreach ($this->folders as $folder => $writable) {
             $mode = ($writable) ? 0777 : 0775;

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Yii;
 use yii\helpers\FileHelper;
-use yii\helpers\Console;
 use yii\imagine\Image;
 
 /**

core/console/commands/views/crud/create_model.php

Spacing +4 added lines, -4 removed lines

@@ -12,8 +12,8 @@ 
  * 
  * <?=$luyaVersion; ?> 
  *
-<?php foreach ($properties as $name => $type): ?> * @property <?= $type; ?> $<?= $name . PHP_EOL; ?>
-<?php endforeach;?>
+<?php foreach ($properties as $name => $type): ?> * @property <?= $type; ?> $<?= $name.PHP_EOL; ?>
+<?php endforeach; ?>
  */
 class <?= $className; ?> extends NgRestModel
 {
@@ -53,7 +53,7 @@ 
      */
     public $i18n = ['<?= implode("', '", $textFields); ?>'];
 
-<?php endif;?>
+<?php endif; ?>
     /**
      * @return array An array containing all field which can be lookedup during the admin search process.
      */
@@ -77,7 +77,7 @@ 
     {
         return [
         <?php foreach ($ngrestFieldConfig as $name => $type): ?>
-    '<?=$name; ?>' => '<?= $type;?>',
+    '<?=$name; ?>' => '<?= $type; ?>',
         <?php endforeach; ?>];
     }