Completed
Pull Request — master (#1319)
by Alexander
03:11
created
core/web/ExternalLink.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     public function setHref($href)
54 54
     {
55 55
         if (StringHelper::startsWith($href, '//')) {
56
-            $this->_href = Url::base(true) . str_replace('//', '/', $href);
56
+            $this->_href = Url::base(true).str_replace('//', '/', $href);
57 57
         } else {
58 58
             $this->_href = Url::ensureHttp($href);
59 59
         }
Please login to merge, or discard this patch.
core/base/Boot.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -210,9 +210,9 @@
 block discarded – undo
210 210
         if (file_exists($this->_baseYiiFile)) {
211 211
             defined('LUYA_YII_VENDOR') ?: define('LUYA_YII_VENDOR', dirname($this->_baseYiiFile));
212 212
             
213
-            $require = require_once(dirname($this->_baseYiiFile) . DIRECTORY_SEPARATOR . 'BaseYii.php');
213
+            $require = require_once(dirname($this->_baseYiiFile).DIRECTORY_SEPARATOR.'BaseYii.php');
214 214
             
215
-            require_once($this->getCoreBasePath() . '/Yii.php');
215
+            require_once($this->getCoreBasePath().'/Yii.php');
216 216
             
217 217
             Yii::setAlias('@luya', $this->getCoreBasePath());
218 218
             return $require;
Please login to merge, or discard this patch.
core/Yii.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,5 +18,5 @@
 block discarded – undo
18 18
 }
19 19
 
20 20
 spl_autoload_register(['Yii', 'autoload'], true, true);
21
-Yii::$classMap = require(LUYA_YII_VENDOR . '/classes.php');
21
+Yii::$classMap = require(LUYA_YII_VENDOR.'/classes.php');
22 22
 Yii::$container = new yii\di\Container();
Please login to merge, or discard this patch.
core/traits/ApplicationTrait.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
                 case 'en':
116 116
                     return 'en_US';
117 117
                 default:
118
-                    return strtolower($lang) . '_' . strtoupper($lang);
118
+                    return strtolower($lang).'_'.strtoupper($lang);
119 119
             }
120 120
         }
121 121
         
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     public function getWebroot()
146 146
     {
147 147
         if ($this->_webroot === null) {
148
-            $this->_webroot = realpath(realpath($this->basePath) . DIRECTORY_SEPARATOR . $this->webrootDirectory);
148
+            $this->_webroot = realpath(realpath($this->basePath).DIRECTORY_SEPARATOR.$this->webrootDirectory);
149 149
         }
150 150
         
151 151
         return $this->_webroot;
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -202,14 +202,14 @@
 block discarded – undo
202 202
      */
203 203
     public function getAdminModules()
204 204
     {
205
-    	$modules = [];
205
+        $modules = [];
206 206
     	
207
-    	foreach ($this->getModules() as $id => $obj) {
208
-    		if ($obj instanceof Module && $obj instanceof AdminModuleInterface) {
209
-    			$modules[$id] = $obj;
210
-    		}
211
-    	}
207
+        foreach ($this->getModules() as $id => $obj) {
208
+            if ($obj instanceof Module && $obj instanceof AdminModuleInterface) {
209
+                $modules[$id] = $obj;
210
+            }
211
+        }
212 212
     	
213
-    	return $modules;
213
+        return $modules;
214 214
     }
215 215
 }
Please login to merge, or discard this patch.
core/traits/CacheableTrait.php 1 patch
Indentation   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -79,34 +79,34 @@
 block discarded – undo
79 79
         return $this->_cachable;
80 80
     }
81 81
     
82
-     /**
83
-     * Method combines both [[setHasCache()]] and [[getHasCache()]] methods to retrieve value identified by a $key,
84
-     * or to store the result of $closure execution if there is no cache available for the $key.
85
-     *
86
-     * Usage example:
87
-     *
88
-     * ```php
89
-     * use CacheableTrait;
90
-     *
91
-     * public function getTopProducts($count = 10)
92
-     * {
93
-     *     return $this->getOrSetHasCache(['top-n-products', 'n' => $count], function ($cache) use ($count) {
94
-     *         return Products::find()->mostPopular()->limit(10)->all();
95
-     *     }, 1000);
96
-     * }
97
-     * ```
98
-     *
99
-     * @param mixed $key a key identifying the value to be cached. This can be a simple string or
100
-     * a complex data structure consisting of factors representing the key.
101
-     * @param \Closure $closure the closure that will be used to generate a value to be cached.
102
-     * In case $closure returns `false`, the value will not be cached.
103
-     * @param int $duration default duration in seconds before the cache will expire. If not set,
104
-     * [[defaultDuration]] value will be used.
105
-     * @param Dependency $dependency dependency of the cached item. If the dependency changes,
106
-     * the corresponding value in the cache will be invalidated when it is fetched via [[get()]].
107
-     * This parameter is ignored if [[serializer]] is `false`.
108
-     * @return mixed result of $closure execution
109
-     */
82
+        /**
83
+         * Method combines both [[setHasCache()]] and [[getHasCache()]] methods to retrieve value identified by a $key,
84
+         * or to store the result of $closure execution if there is no cache available for the $key.
85
+         *
86
+         * Usage example:
87
+         *
88
+         * ```php
89
+         * use CacheableTrait;
90
+         *
91
+         * public function getTopProducts($count = 10)
92
+         * {
93
+         *     return $this->getOrSetHasCache(['top-n-products', 'n' => $count], function ($cache) use ($count) {
94
+         *         return Products::find()->mostPopular()->limit(10)->all();
95
+         *     }, 1000);
96
+         * }
97
+         * ```
98
+         *
99
+         * @param mixed $key a key identifying the value to be cached. This can be a simple string or
100
+         * a complex data structure consisting of factors representing the key.
101
+         * @param \Closure $closure the closure that will be used to generate a value to be cached.
102
+         * In case $closure returns `false`, the value will not be cached.
103
+         * @param int $duration default duration in seconds before the cache will expire. If not set,
104
+         * [[defaultDuration]] value will be used.
105
+         * @param Dependency $dependency dependency of the cached item. If the dependency changes,
106
+         * the corresponding value in the cache will be invalidated when it is fetched via [[get()]].
107
+         * This parameter is ignored if [[serializer]] is `false`.
108
+         * @return mixed result of $closure execution
109
+         */
110 110
     public function getOrSetHasCache($key, \Closure $closure, $duration = null, $dependency = null)
111 111
     {
112 112
         if (($value = $this->getHasCache($key)) !== false) {
Please login to merge, or discard this patch.
core/console/Bootstrap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,15 +36,15 @@
 block discarded – undo
36 36
     public function run($app)
37 37
     {
38 38
         foreach ($app->getApplicationModules() as $id => $module) {
39
-            $folder = $module->basePath . DIRECTORY_SEPARATOR . 'commands';
39
+            $folder = $module->basePath.DIRECTORY_SEPARATOR.'commands';
40 40
             if (file_exists($folder) && is_dir($folder)) {
41 41
                 foreach (FileHelper::findFiles($folder) as $file) {
42 42
                     
43
-                    $module->controllerNamespace = $module->namespace . '\commands';
43
+                    $module->controllerNamespace = $module->namespace.'\commands';
44 44
                     
45
-                    $className = '\\'.$module->getNamespace().'\\commands\\' . pathinfo($file, PATHINFO_FILENAME);
45
+                    $className = '\\'.$module->getNamespace().'\\commands\\'.pathinfo($file, PATHINFO_FILENAME);
46 46
 
47
-                    $command = str_replace('-controller', '', $module->id . '/' . Inflector::camel2id(pathinfo($file, PATHINFO_FILENAME)));
47
+                    $command = str_replace('-controller', '', $module->id.'/'.Inflector::camel2id(pathinfo($file, PATHINFO_FILENAME)));
48 48
                     
49 49
                     Yii::$app->controllerMap[$command] = ['class' => $className];
50 50
                 }
Please login to merge, or discard this patch.
core/base/Module.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -278,6 +278,6 @@
 block discarded – undo
278 278
      */
279 279
     public function getControllerPath()
280 280
     {
281
-        return Yii::getAlias('@' . str_replace('\\', '/', $this->controllerNamespace), false);
281
+        return Yii::getAlias('@'.str_replace('\\', '/', $this->controllerNamespace), false);
282 282
     }
283 283
 }
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace luya\base;
4 4
 
5 5
 use yii;
6
-
7 6
 use luya\helpers\FileHelper;
8 7
 use yii\helpers\Inflector;
9 8
 use luya\console\interfaces\ImportControllerInterface;
Please login to merge, or discard this patch.
core/console/commands/ImportController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -164,18 +164,18 @@
 block discarded – undo
164 164
         }
165 165
         
166 166
         foreach ($this->getLog() as $section => $value) {
167
-            $this->outputInfo(PHP_EOL . $section . ":");
167
+            $this->outputInfo(PHP_EOL.$section.":");
168 168
             foreach ($value as $k => $v) {
169 169
                 if (is_array($v)) {
170 170
                     foreach ($v as $kk => $kv) {
171 171
                         if (is_array($kv)) {
172
-                            $this->output(" - {$kk}: " . print_r($kv, true));
172
+                            $this->output(" - {$kk}: ".print_r($kv, true));
173 173
                         } else {
174 174
                             $this->output(" - {$kk}: {$kv}");
175 175
                         }
176 176
                     }
177 177
                 } else {
178
-                    $this->output(" - " . $v);
178
+                    $this->output(" - ".$v);
179 179
                 }
180 180
             }
181 181
         }
Please login to merge, or discard this patch.
core/helpers/ArrayHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     public static function search(array $array, $searchText, $sensitive = false)
97 97
     {
98 98
         $function = ($sensitive) ? 'strpos' : 'stripos';
99
-        return array_filter($array, function ($item) use ($searchText, $function) {
99
+        return array_filter($array, function($item) use ($searchText, $function) {
100 100
             $response = false;
101 101
             foreach ($item as $key => $value) {
102 102
                 if ($response) {
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     {
137 137
         $key = array_search($search, array_column($array, $column));
138 138
         
139
-        return ($key !== false) ?  $array[$key] : false;
139
+        return ($key !== false) ? $array[$key] : false;
140 140
     }
141 141
     
142 142
     /**
Please login to merge, or discard this patch.