luyadev / luya

core/console/commands/ModuleController.php

Doc Comments +1 added lines

@@ -17,6 +17,7 @@
     /**
      * Humanize the class name
      *
+     * @param string $name
      * @return string The humanized name.
      */
     public function humanizeName($name)

Spacing +14 added lines, -14 removed lines

@@ -106,23 +106,23 @@ 
             }
         }
         
-        $appModulesFolder = Yii::$app->basePath . DIRECTORY_SEPARATOR . 'modules';
-        $moduleFolder = $appModulesFolder . DIRECTORY_SEPARATOR . $moduleName;
+        $appModulesFolder = Yii::$app->basePath.DIRECTORY_SEPARATOR.'modules';
+        $moduleFolder = $appModulesFolder.DIRECTORY_SEPARATOR.$moduleName;
         
         if (file_exists($moduleFolder)) {
-            return $this->outputError("The folder " . $moduleFolder . " exists already.");
+            return $this->outputError("The folder ".$moduleFolder." exists already.");
         }
         
         $folders = [
             'basePath' => $moduleFolder,
-            'adminPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin',
-            'adminAwsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin' . DIRECTORY_SEPARATOR . 'aws',
-            'adminMigrationPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin' . DIRECTORY_SEPARATOR . 'migrations',
-            'frontendPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend',
-            'frontendBlocksPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'blocks',
-            'frontendControllersPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'controllers',
-            'frontendViewsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'views',
-            'modelsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'models',
+            'adminPath' => $moduleFolder.DIRECTORY_SEPARATOR.'admin',
+            'adminAwsPath' => $moduleFolder.DIRECTORY_SEPARATOR.'admin'.DIRECTORY_SEPARATOR.'aws',
+            'adminMigrationPath' => $moduleFolder.DIRECTORY_SEPARATOR.'admin'.DIRECTORY_SEPARATOR.'migrations',
+            'frontendPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend',
+            'frontendBlocksPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend'.DIRECTORY_SEPARATOR.'blocks',
+            'frontendControllersPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend'.DIRECTORY_SEPARATOR.'controllers',
+            'frontendViewsPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend'.DIRECTORY_SEPARATOR.'views',
+            'modelsPath' => $moduleFolder.DIRECTORY_SEPARATOR.'models',
         ];
 
         $ns = 'app\\modules\\'.$moduleName;
@@ -132,9 +132,9 @@ 
         }
         
         $contents = [
-            $moduleFolder. DIRECTORY_SEPARATOR . 'README.md' => $this->renderReadme($folders, $moduleName, $ns),
-            $moduleFolder. DIRECTORY_SEPARATOR . 'admin/Module.php' => $this->renderAdmin($folders, $moduleName, $ns),
-            $moduleFolder. DIRECTORY_SEPARATOR . 'frontend/Module.php' => $this->renderFrontend($folders, $moduleName, $ns),
+            $moduleFolder.DIRECTORY_SEPARATOR.'README.md' => $this->renderReadme($folders, $moduleName, $ns),
+            $moduleFolder.DIRECTORY_SEPARATOR.'admin/Module.php' => $this->renderAdmin($folders, $moduleName, $ns),
+            $moduleFolder.DIRECTORY_SEPARATOR.'frontend/Module.php' => $this->renderFrontend($folders, $moduleName, $ns),
         ];
         
         foreach ($contents as $fileName => $content) {

core/helpers/StringHelper.php

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
             return true;
         }
         
-        return ($value == (string)(float) $value);
+        return ($value == (string) (float) $value);
     }
     
     /**

Doc Comments +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
      * @param string $search Search string to look for.
      * @param string $replace Replacement value for the first found occurrence.
      * @param string $subject The string you want to look up to replace the first element.
-     * @return mixed Replaced string
+     * @return string Replaced string
      */
     public static function replaceFirst($search, $replace, $subject)
     {

core/web/Composition.php

Doc Comments +1 added lines, -1 removed lines

@@ -398,7 +398,7 @@
      *
      * @see ArrayAccess::offsetGet()
      * @param string $offset The key to get from the array.
-     * @return mixed The value for the offset key from the array.
+     * @return string|boolean The value for the offset key from the array.
      */
     public function offsetGet($offset)
     {

core/web/UrlManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
      * Remove the base url from a route
      *
      * @param string $route The route where the baseUrl should be removed from.
-     * @return mixed
+     * @return string
      */
     public function removeBaseUrl($route)
     {

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
         $length = strlen($composition);
         $route = $parsedRequest[0];
         
-        if (substr($route, 0, $length+1) == $composition.'/') {
+        if (substr($route, 0, $length + 1) == $composition.'/') {
             $parsedRequest[0] = substr($parsedRequest[0], $length);
         }
         
@@ -302,10 +302,10 @@ 
         $params = (array) $params;
         $url = $this->internalCreateUrl($params);
         if (strpos($url, '://') === false) {
-            $url = $this->getHostInfo() . $url;
+            $url = $this->getHostInfo().$url;
         }
         if (is_string($scheme) && ($pos = strpos($url, '://')) !== false) {
-            $url = $scheme . substr($url, $pos);
+            $url = $scheme.substr($url, $pos);
         }
         return $url;
     }

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace luya\web;
 
 use Yii;
-
 use yii\web\BadRequestHttpException;
 
 /**

core/base/Widget.php

Spacing +1 added lines, -1 removed lines

@@ -39,6 +39,6 @@
         // get reflection
         $class = new ReflectionClass($this);
         // get path with alias
-        return '@app/views/widgets/' . Inflector::camel2id($class->getShortName());
+        return '@app/views/widgets/'.Inflector::camel2id($class->getShortName());
     }
 }

core/TagParser.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     {
         if (!is_object($this->tags[$tag])) {
             $this->tags[$tag] = Yii::createObject($this->tags[$tag]);
-            Yii::trace('tag parser object generated for:'. $tag, __CLASS__);
+            Yii::trace('tag parser object generated for:'.$tag, __CLASS__);
         }
     }
     

core/console/commands/HealthController.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         
         @chdir(Yii::getAlias('@app'));
 
-        $this->output('The directory the health commands is applying to: ' . Yii::getAlias('@app'));
+        $this->output('The directory the health commands is applying to: '.Yii::getAlias('@app'));
         
         foreach ($this->folders as $folder => $writable) {
             $mode = ($writable) ? 0777 : 0775;

Doc Comments +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
     /**
      * Create all required directories an check whether they are writeable or not.
      *
-     * @return string The action output.
+     * @return integer The action output.
      */
     public function actionIndex()
     {
@@ -97,7 +97,7 @@ 
     /**
      * Test Mail-Component (Use --verbose=1 to enable smtp debug output)
      *
-     * @return boolean Whether successfull or not.
+     * @return integer|null Whether successfull or not.
      * @throws Exception On smtp failure
      */
     public function actionMailer()

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Yii;
 use yii\helpers\FileHelper;
-
 use yii\imagine\Image;
 
 /**

core/tag/tags/TelTag.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      */
     public function parse($value, $sub)
     {
-        return Html::a(empty($sub) ? $value : $sub, 'tel:' . $this->ensureNumber($value));
+        return Html::a(empty($sub) ? $value : $sub, 'tel:'.$this->ensureNumber($value));
     }
         
     private function ensureNumber($number)

core/web/filters/ResponseCache.php

Spacing +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
             return $response->send();
         }
         
-        $response->on(Response::EVENT_AFTER_SEND, function ($event) use ($action) {
+        $response->on(Response::EVENT_AFTER_SEND, function($event) use ($action) {
             $this->callActionCallable($action->id, $event->sender->content);
         });